Files
orca/src
NeilandOrca 02eca244b5 review: harden #8283 fix — classify folder workspaces by repo-id prefix, not suffix-strip
The committed fix keyed folder detection off the ::workspace:<uuid> suffix
strip (isFolderWorkspace = worktreePath !== parsed.worktreePath). That leaves
two folder-workspace placeholders git-classified during hydration:
  - the bare root worktree id (folder-workspace:<pgid>::<path>, no suffix), and
  - any instance when the suffix-less root key is processed first (the
    if (!existingRepo) early insert then skips the kind:'folder' tag).
Both still hit the isGitRepoKind-gated status poll (verified reproducing).

Key folder detection off the folder-workspace:<pgid> repo-id prefix instead
(new shared isFolderWorkspaceRepoId predicate), which is exclusive to folder
repos (git repo ids are bare UUIDs) and order-independent. Still strips the
suffix via splitWorktreeIdForFilesystem for a real folder cwd. Adds root-only
and root-before-instance regression tests; strengthens the instance test so it
can't pass vacuously. Framing unchanged: root-cause/churn fix, raw ENOENT
already guarded on main.

Co-authored-by: Orca <help@stably.ai>
2026-07-13 17:53:09 -07:00
..
2026-07-12 22:45:33 -07:00
2026-07-13 00:34:04 -07:00