mirror of
https://github.com/stablyai/orca.git
synced 2026-10-22 08:03:37 +00:00
Neil
063827d4b1
Both findings are right, and the first is pointed: this script demonstrates that signalling a pid you have not re-verified can kill someone else's work, and its own teardown did that twice. The staged daemon is killed on purpose in phase 1. Once Node reaps that child its pid is free for reuse, and teardown signalled the remembered number anyway; it now signals only while the child object still reports no exit. The markers were half-verified. Each proves its own identity by tag before being signalled, but its session leader was killed on a number remembered from staging a minute earlier — and the leader is the one pid here that can be recycled while its child lives on under a new parent. The leader is now re-read from the live marker and signalled only when the marker still claims it. Second finding: isRealUserDaemon matched a hardcoded macOS userData path, so on Linux a real daemon could never be recognised — the assertion that this run harmed nothing was inert on the platform where nobody would notice. Now matched per platform, with a loose fallback rather than a silent false. Repro re-run end to end: all three phases pass, pre-existing daemons still running, real userData daemon untouched.