Files
orca/src/main/linux-package-install-command.ts
T
NeilandClaude 6d8e4cfef2 refactor(shell): one shell-argument-quoting module for the duplicated quote copies (#30564)
* refactor(shell): one shell-argument-quoting module for the duplicated quote copies

Each former copy now calls the canonical function with its exact spelling; a table test pins
byte-identical output for every copy over hostile inputs. Distinct spellings stay distinct
functions: '\'' vs '"'"', the two plain-word sets, and the cmd.exe doubled quote.

Co-Authored-By: Claude <noreply@anthropic.com>

* style: keep the quoting import at the top of two import-less files

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-18 23:12:27 -07:00

95 lines
3.8 KiB
TypeScript

import { quotePosixShellDoubleQuotedApostrophe } from '../shared/shell-argument-quoting'
import { statSync } from 'node:fs'
import path from 'node:path'
import type { LinuxRootPackageType } from '../shared/update-status-types'
// Why: an absolute but user-writable PATH entry must never be treated as a trusted package manager.
const TRUSTED_EXECUTABLE_DIRECTORIES = ['/usr/bin', '/bin', '/usr/sbin', '/sbin']
const DEB_PACKAGE_MANAGERS: { name: string; args: string[] }[] = [
{ name: 'apt', args: ['install', '--'] },
{ name: 'dpkg', args: ['-i', '--'] }
]
// No `--` terminator: these tools do not accept one. Safe because capture requires an absolute path,
// so the argument can never be read as an option.
const RPM_PACKAGE_MANAGERS: { name: string; args: string[] }[] = [
{
name: 'zypper',
args: ['--no-refresh', 'install', '--allow-unsigned-rpm', '-f']
},
{ name: 'dnf', args: ['install', '--nogpgcheck'] },
{ name: 'yum', args: ['install', '--nogpgcheck'] },
{ name: 'rpm', args: ['-Uvh'] }
]
export type LinuxPackageInstallCommandResult =
| { ok: true; command: string }
| { ok: false; reason: 'no-sudo' | 'no-package-manager' | 'invalid-package-path' }
/**
* Resolves an executable strictly from the trusted system directories. A symlink inside those
* directories is fine — its target is what `statSync` checks — but nothing outside them is consulted
* and no shell is ever invoked for discovery.
*/
export function resolveTrustedExecutable(name: string): string | null {
for (const directory of TRUSTED_EXECUTABLE_DIRECTORIES) {
// posix.join: these are POSIX paths, and this module only ever runs on Linux.
const candidate = path.posix.join(directory, name)
try {
const stats = statSync(candidate)
if (stats.isFile() && (stats.mode & 0o111) !== 0) {
return candidate
}
} catch {
// Absent here; keep looking in the remaining trusted directories.
}
}
return null
}
/**
* Whether this host has any package manager able to install the marker's format. A repackaged
* install (AUR, Nix, a container rebuild) inherits the `package-type` marker from the .deb/.rpm it
* was built from, so the marker alone never proves the host can act on it.
*/
export function hasTrustedPackageManagerFor(packageType: LinuxRootPackageType): boolean {
const candidates = packageType === 'deb' ? DEB_PACKAGE_MANAGERS : RPM_PACKAGE_MANAGERS
return candidates.some((candidate) => resolveTrustedExecutable(candidate.name) !== null)
}
/**
* Builds the interactive command the user pastes into their own terminal. Every token except the
* package path is a fixed literal, and the path is POSIX-single-quoted — Orca never runs this.
*/
export function buildLinuxPackageInstallCommand(
packageType: LinuxRootPackageType,
packagePath: string
): LinuxPackageInstallCommandResult {
// Why: several package managers accept no `--` terminator, so a relative or dash-leading path would
// be read as an option. Hold that property here rather than relying on a caller two modules away.
if (!path.isAbsolute(packagePath)) {
return { ok: false, reason: 'invalid-package-path' }
}
const sudoPath = resolveTrustedExecutable('sudo')
if (!sudoPath) {
return { ok: false, reason: 'no-sudo' }
}
const candidates = packageType === 'deb' ? DEB_PACKAGE_MANAGERS : RPM_PACKAGE_MANAGERS
for (const candidate of candidates) {
const managerPath = resolveTrustedExecutable(candidate.name)
if (!managerPath) {
continue
}
// No -y/--noconfirm: the user must see and confirm the privileged transaction.
const tokens = [
sudoPath,
managerPath,
...candidate.args,
quotePosixShellDoubleQuotedApostrophe(packagePath)
]
return { ok: true, command: tokens.join(' ') }
}
return { ok: false, reason: 'no-package-manager' }
}