mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 08:03:13 +00:00
NeilandOrca
46646d7ff1
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
94 lines
2.9 KiB
TypeScript
94 lines
2.9 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { resolveWithSshG } from './ssh-config-parser'
|
|
|
|
vi.mock('os', () => ({
|
|
homedir: () => '/home/testuser'
|
|
}))
|
|
|
|
vi.mock('child_process', () => ({
|
|
execFile: vi.fn()
|
|
}))
|
|
|
|
describe('resolveWithSshG', () => {
|
|
beforeEach(async () => {
|
|
const { execFile } = await import('node:child_process')
|
|
vi.mocked(execFile).mockReset()
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
it('returns parsed config on success', async () => {
|
|
const { execFile } = await import('node:child_process')
|
|
const mockExecFile = vi.mocked(execFile)
|
|
mockExecFile.mockImplementation(
|
|
(_cmd: unknown, _args: unknown, _opts: unknown, cb: unknown) => {
|
|
const callback = cb as (err: Error | null, stdout: string) => void
|
|
callback(null, 'hostname 10.0.0.1\nuser admin\nport 22')
|
|
return undefined as never
|
|
}
|
|
)
|
|
|
|
const result = await resolveWithSshG('myhost')
|
|
expect(result).toBeDefined()
|
|
expect(result!.hostname).toBe('10.0.0.1')
|
|
expect(result!.user).toBe('admin')
|
|
})
|
|
|
|
it('calls ssh -G with the given host', async () => {
|
|
const { execFile } = await import('node:child_process')
|
|
const mockExecFile = vi.mocked(execFile)
|
|
mockExecFile.mockImplementation(
|
|
(_cmd: unknown, _args: unknown, _opts: unknown, cb: unknown) => {
|
|
const callback = cb as (err: Error | null, stdout: string) => void
|
|
callback(null, 'hostname example.com\nport 22')
|
|
return undefined as never
|
|
}
|
|
)
|
|
|
|
await resolveWithSshG('testserver')
|
|
expect(mockExecFile).toHaveBeenCalledWith(
|
|
'ssh',
|
|
['-G', '--', 'testserver'],
|
|
expect.objectContaining({ timeout: 5000 }),
|
|
expect.any(Function)
|
|
)
|
|
})
|
|
|
|
it('returns null when ssh -G fails', async () => {
|
|
const { execFile } = await import('node:child_process')
|
|
const mockExecFile = vi.mocked(execFile)
|
|
mockExecFile.mockImplementation(
|
|
(_cmd: unknown, _args: unknown, _opts: unknown, cb: unknown) => {
|
|
const callback = cb as (err: Error | null, stdout: string) => void
|
|
callback(new Error('ssh not found'), '')
|
|
return undefined as never
|
|
}
|
|
)
|
|
|
|
const result = await resolveWithSshG('myhost')
|
|
expect(result).toBeNull()
|
|
})
|
|
|
|
it('returns null when ssh -G never reports completion', async () => {
|
|
vi.useFakeTimers()
|
|
const { execFile } = await import('node:child_process')
|
|
const mockExecFile = vi.mocked(execFile)
|
|
const killMock = vi.fn()
|
|
mockExecFile.mockImplementation(() => ({ kill: killMock }) as never)
|
|
|
|
let settled = false
|
|
const resultPromise = resolveWithSshG('stuck-host').then((result) => {
|
|
settled = true
|
|
return result
|
|
})
|
|
|
|
await vi.advanceTimersByTimeAsync(5000)
|
|
|
|
expect(settled).toBe(true)
|
|
await expect(resultPromise).resolves.toBeNull()
|
|
expect(killMock).toHaveBeenCalled()
|
|
})
|
|
})
|