mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 00:03:20 +00:00
* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket Unify mobile workspace creation with desktop. The "+" Create Workspace modal now has a primary "Start from" field that opens a tabbed search drawer (Branch · GitHub · GitLab · Linear), letting a user start a workspace from an existing/new git branch, a GitHub issue/PR, a GitLab issue/MR, or a Linear ticket — in addition to the default blank workspace. No new backend is required: the search RPCs (github.listWorkItems, gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and the worktree.create linked-item params were already used by the mobile Tasks screen. This surfaces them in the create flow, reusing the existing pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint, filterAvailableTaskProviders). Details: - New pure modules: workspace-source-selection, use-workspace-source-search, source-workspace-create, worktree-create-retry, blank-workspace-create (the blank/retry path extracted from the modal for reuse + line budget). - New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer (extracted from the modal). - Older paired desktops (missing the mobile.tasks.v1 capability) degrade to Branch + Blank only; GitLab/Linear tabs appear only when available. - GitHub/GitLab sources pin their repo; switching repos resets the source. PR/MR sources resolve their base branch at create time; SSH repos gate search until connected (Linear search is repo/SSH-independent). * fix(mobile): hydrate settings/trust before availability probes settle Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer wait on status.get/preflight.check/linear.status (a first-open preflight.check can take seconds, widening the spurious setup-trust re-prompt window). Also adds param-parity tests for createBlankWorkspace and a GitLab MR base-resolve test. * feat(mobile): match desktop's Smart source picker exactly Rework the mobile create-workspace source picker to be a faithful port of desktop's Smart picker instead of the earlier divergent "Start from" drawer. The mobile field is now the workspace-name input AND the source search, with the exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart" fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'" row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo switch prompt). Selecting a source shows a pill and moves the editable name into Advanced. The invented "Blank workspace" concept is removed — the neutral state is just a typed/empty name (blank submit still yields a creature name). DRY: the pure desktop logic (smart-workspace-source-results, -command-value, github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity) moves to src/shared/new-workspace/ with re-export shims at the old renderer paths, so both renderer and mobile share one implementation. composer-branch-selection and workspace-name were already shared and are reused directly. Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo, gitlab.workItemByPath). New mobile modules are split for max-lines: use-mobile-composer-source (selection state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source + smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration), composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes (pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields. Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection, use-workspace-source-search, and MobileWorkspaceNameInput. Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch preserves slashy names, cross-repo PR base resolves against the item's own repo, displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass. * fix(mobile): keep smart source drawer fully visible * refactor: share workspace creation behavior across clients * fix: address workspace creation review findings --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
143 lines
4.4 KiB
TypeScript
143 lines
4.4 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
deriveRepoSlug,
|
|
findRepoMatchingSlug,
|
|
findRepoMatchingSlugForPaste,
|
|
resolvePasteIntent,
|
|
type PasteRepoCandidate
|
|
} from './smart-source-paste-intent'
|
|
import type { RpcClient } from '../transport/rpc-client'
|
|
|
|
describe('resolvePasteIntent', () => {
|
|
it('classifies a GitHub issue/PR URL as a github-link', () => {
|
|
expect(resolvePasteIntent('https://github.com/acme/widgets/pull/12')).toEqual({
|
|
kind: 'github-link',
|
|
link: { slug: { owner: 'acme', repo: 'widgets' }, number: 12, type: 'pr' }
|
|
})
|
|
})
|
|
|
|
it('classifies a bare #number as a github-number', () => {
|
|
expect(resolvePasteIntent('#42')).toEqual({ kind: 'github-number', number: 42 })
|
|
})
|
|
|
|
it('classifies a GitLab MR URL as a gitlab-link', () => {
|
|
const intent = resolvePasteIntent('https://gitlab.com/group/proj/-/merge_requests/8')
|
|
expect(intent?.kind).toBe('gitlab-link')
|
|
if (intent?.kind === 'gitlab-link') {
|
|
expect(intent.link).toMatchObject({ number: 8, type: 'mr' })
|
|
}
|
|
})
|
|
|
|
it('returns null for plain search text', () => {
|
|
expect(resolvePasteIntent('login bug')).toBeNull()
|
|
})
|
|
|
|
it('rejects oversized paste intents before any exact lookup', () => {
|
|
expect(
|
|
resolvePasteIntent(`https://github.com/acme/widgets/issues/12/${'x'.repeat(2048)}`)
|
|
).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('deriveRepoSlug', () => {
|
|
it('prefers the upstream identity', () => {
|
|
expect(deriveRepoSlug({ upstream: { owner: 'up', repo: 'stream' } })).toEqual({
|
|
owner: 'up',
|
|
repo: 'stream'
|
|
})
|
|
})
|
|
|
|
it('parses an SSH remote URL', () => {
|
|
expect(
|
|
deriveRepoSlug({ gitRemoteIdentity: { remoteUrl: 'git@github.com:acme/widgets.git' } })
|
|
).toEqual({ owner: 'acme', repo: 'widgets' })
|
|
})
|
|
|
|
it('parses an HTTPS remote URL', () => {
|
|
expect(
|
|
deriveRepoSlug({ gitRemoteIdentity: { remoteUrl: 'https://github.com/acme/widgets' } })
|
|
).toEqual({ owner: 'acme', repo: 'widgets' })
|
|
})
|
|
|
|
it('returns null when no slug can be derived', () => {
|
|
expect(deriveRepoSlug({})).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('findRepoMatchingSlug', () => {
|
|
const repos: PasteRepoCandidate[] = [
|
|
{ id: 'a', displayName: 'A', slug: { owner: 'acme', repo: 'widgets' } },
|
|
{ id: 'b', displayName: 'B', slug: null }
|
|
]
|
|
|
|
it('matches case-insensitively', () => {
|
|
expect(findRepoMatchingSlug(repos, { owner: 'Acme', repo: 'Widgets' })?.id).toBe('a')
|
|
})
|
|
|
|
it('returns null when no repo matches', () => {
|
|
expect(findRepoMatchingSlug(repos, { owner: 'other', repo: 'thing' })).toBeNull()
|
|
})
|
|
|
|
it('falls back to the host-aware repo slug RPC for SSH and enterprise repos', async () => {
|
|
const calls: string[] = []
|
|
const client = {
|
|
sendRequest: async (_method: string, params: unknown) => {
|
|
const repo = (params as { repo: string }).repo
|
|
calls.push(repo)
|
|
return {
|
|
ok: true,
|
|
result: repo === 'id:b' ? { owner: 'enterprise', repo: 'widgets' } : null
|
|
}
|
|
}
|
|
} as unknown as RpcClient
|
|
await expect(
|
|
findRepoMatchingSlugForPaste(
|
|
client,
|
|
repos,
|
|
{ owner: 'enterprise', repo: 'widgets' },
|
|
new Map()
|
|
)
|
|
).resolves.toMatchObject({ id: 'b' })
|
|
expect(calls).toEqual(['id:a', 'id:b'])
|
|
})
|
|
|
|
it('keeps local matching usable when an older desktop lacks the repo slug RPC', async () => {
|
|
let calls = 0
|
|
const client = {
|
|
sendRequest: async () => {
|
|
calls += 1
|
|
return {
|
|
ok: false,
|
|
error: { code: 'method_not_found', message: 'Unknown method: github.repoSlug' }
|
|
}
|
|
}
|
|
} as unknown as RpcClient
|
|
const cache = new Map<string, { owner: string; repo: string } | null>()
|
|
|
|
await expect(
|
|
findRepoMatchingSlugForPaste(client, repos, { owner: 'enterprise', repo: 'widgets' }, cache)
|
|
).resolves.toBeNull()
|
|
await expect(
|
|
findRepoMatchingSlugForPaste(client, repos, { owner: 'enterprise', repo: 'other' }, cache)
|
|
).resolves.toBeNull()
|
|
expect(calls).toBe(1)
|
|
})
|
|
|
|
it('keeps local matching usable when the optional repo slug lookup rejects', async () => {
|
|
const client = {
|
|
sendRequest: async () => {
|
|
throw new Error('connection closed')
|
|
}
|
|
} as unknown as RpcClient
|
|
|
|
await expect(
|
|
findRepoMatchingSlugForPaste(
|
|
client,
|
|
repos,
|
|
{ owner: 'enterprise', repo: 'widgets' },
|
|
new Map()
|
|
)
|
|
).resolves.toBeNull()
|
|
})
|
|
})
|