mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 16:02:32 +00:00
* refactor(tests): split oversized test files off the max-lines suppression list Every `*.test.ts`/`*.spec.ts` that carried an `eslint/oxlint-disable max-lines` directive is now split into focused, behavior-scoped suites that fit the 800-line test budget, with shared setup extracted into co-located `*-test-harness.ts` / `*-test-fixtures.ts` modules (300-line budget). 83 files became ~930; the largest output is 797 effective lines. `orca-runtime.test.ts` is intentionally untouched. Test bodies were moved by scripted line-range slicing rather than retyped, so assertions are byte-identical. The only permitted body edits were mechanical rebinding where a shared value moved into a harness (e.g. `tmpHome` -> `homes.tmpHome`). Registries that enumerate test files were updated in lockstep: - config/max-lines-baseline.txt: pruned 341 -> 258 entries (all 83 removed). - config/reliability-gates.jsonc: 33 gates repointed at the split files, with assertionRefs split per file where a gate's coverage now spans several. - .github/workflows/pr.yml: the real-zsh lane now lists the 4 split files that actually exercise zsh, so they keep running in the dedicated shell lane. Also renamed agent-hooks `server-test-fixtures.ts` to `server.test-fixtures.ts` so the global-fetch call-site audit keeps skipping it, and added `.js` extensions to the CLI suites' dynamic harness imports (node16 resolution) to unbreak `build:cli`. Verification: full suite 52,449 passing vs 52,448 at baseline with zero assertions lost; `pnpm lint`, `pnpm typecheck`, and `pnpm build:cli` all exit 0; the terminal-pane e2e spec runs 31/31 headless. * refactor(tests): split hook-idle arbitration suite that oxfmt pushed over budget The pre-commit oxfmt pass reflowed pty-connection-hook-idle-arbitration.test.ts to 811 effective lines, 11 over the test budget. Split the hook-completion side effect and replacement-agent veto cases into their own suite; both files now sit well under the cap and the 15 tests are unchanged. * test: port upstream test changes into the split files after rebase Rebasing onto main surfaced 27 tests that main had added to files this branch deleted, plus edits to tests that had already moved. Taking the deletion side of those modify/delete conflicts would have dropped that coverage silently, so each upstream change is ported into the split file that now owns the behavior — for example main's six orchestration mailbox tests land across orchestration-runs, -send, and -check. Also repoints `orchestration.notification-mailbox-consistency`, a gate main added after this branch's gate remap, at those same three split files, and re-prunes the max-lines baseline against main's (257 entries). Verified: all 27 upstream test titles present; full suite 52,761 passing with the only diff vs baseline being 12 tests main itself removed and 3 that moved from skipped to passing; lint and typecheck exit 0. * fix(test): flush pending continuations before tearing down terminal test globals CI shard 5/16 failed on both Node 24 and 26 with `ReferenceError: window is not defined` from pty-connection.ts, surfacing through pty-connection-daemon-snapshot-replay.test.ts. The reattach/settle chains `await` a real promise and then touch `window.api`. Under fake timers those continuations cannot run, so they only become schedulable once restoreTerminalTestGlobals() switches back to real timers — which previously happened immediately before `delete globalThis.window`, so a late continuation threw and failed the whole file. Flush async ticks in that window instead. This is latent in the source rather than new: the pre-split 25k-line file kept running other tests after these, which gave the chains time to settle before teardown. Splitting the file moved teardown directly behind them. * fix(test): keep an inert window after terminal test teardown instead of deleting it The async-tick flush was not enough: the reattach/settle chain can resolve after teardown regardless of how long we drain, so CI shard 5/16 still failed with `ReferenceError: window is not defined` from pty-connection.ts. A real renderer never loses `window`, so deleting it was the artificial part. Swap in an inert proxy whose properties resolve to callables and whose calls resolve to undefined, making a late `window.api.pty.*` call a harmless no-op. The next test replaces it wholesale via installTerminalTestGlobals(), and no test asserts that `window` is absent.
622 lines
22 KiB
TypeScript
622 lines
22 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
vi.mock('electron', async () =>
|
|
(await import('./createMainWindow-test-harness')).electronModuleMock()
|
|
)
|
|
vi.mock('@electron-toolkit/utils', async () =>
|
|
(await import('./createMainWindow-test-harness')).electronToolkitUtilsMock()
|
|
)
|
|
vi.mock('./macos-tahoe-release', async () =>
|
|
(await import('./createMainWindow-test-harness')).macosTahoeReleaseMock()
|
|
)
|
|
vi.mock('../app-icon', async () => (await import('./createMainWindow-test-harness')).appIconMock())
|
|
vi.mock('../browser/browser-manager', async () =>
|
|
(await import('./createMainWindow-test-harness')).browserManagerMock()
|
|
)
|
|
|
|
import { createMainWindow, loadMainWindow } from './createMainWindow'
|
|
import { ipcMain } from 'electron'
|
|
import { resetExpectedTeardownStateForTest } from '../crash-reporting/expected-teardown-state'
|
|
import {
|
|
attachGuestPoliciesMock,
|
|
browserWindowMock,
|
|
macosTahoeMock,
|
|
openExternalMock,
|
|
powerMonitorOnMock,
|
|
resetMainWindowMocks,
|
|
withPlatform
|
|
} from './createMainWindow-test-harness'
|
|
|
|
describe('createMainWindow', () => {
|
|
beforeEach(() => {
|
|
resetMainWindowMocks()
|
|
resetExpectedTeardownStateForTest()
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
it('can defer renderer loading until startup IPC handlers are registered', () => {
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => true),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => [1200, 800]),
|
|
setSize: vi.fn(),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
const win = createMainWindow(null, { deferLoad: true })
|
|
|
|
expect(browserWindowInstance.loadFile).not.toHaveBeenCalled()
|
|
expect(browserWindowInstance.loadURL).not.toHaveBeenCalled()
|
|
|
|
loadMainWindow(win)
|
|
|
|
expect(browserWindowInstance.loadFile).toHaveBeenCalledTimes(1)
|
|
expect(browserWindowInstance.loadURL).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('enables renderer sandboxing and opens external links safely', () => {
|
|
const windowHandlers: Record<string, (...args: any[]) => void> = {}
|
|
const webContents = {
|
|
on: vi.fn((event, handler) => {
|
|
windowHandlers[event] = handler
|
|
}),
|
|
once: vi.fn((event, handler) => {
|
|
windowHandlers[event] = handler
|
|
}),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
setWindowOpenHandler: vi.fn((handler) => {
|
|
windowHandlers.windowOpen = handler
|
|
}),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => true),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => [1200, 800]),
|
|
setSize: vi.fn(),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
createMainWindow(null)
|
|
|
|
expect(browserWindowMock).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
webPreferences: expect.objectContaining({ sandbox: true })
|
|
})
|
|
)
|
|
const browserWindowOptions = browserWindowMock.mock.calls[0]?.[0]
|
|
// Why: macOS swallows the app-activating click unless the window accepts
|
|
// first mouse, forcing a second click to focus the floating workspace.
|
|
expect(browserWindowOptions.acceptFirstMouse).toBe(true)
|
|
if (process.platform === 'darwin') {
|
|
expect(browserWindowOptions).toMatchObject({
|
|
titleBarStyle: 'hiddenInset'
|
|
})
|
|
} else if (process.platform === 'win32') {
|
|
expect(browserWindowOptions).toMatchObject({
|
|
titleBarStyle: 'hidden'
|
|
})
|
|
} else {
|
|
// Linux: native frame is dropped so the renderer titlebar isn't stacked
|
|
// under the WM title bar (double title bar). titleBarStyle stays unset.
|
|
expect(browserWindowOptions.titleBarStyle).toBeUndefined()
|
|
expect(browserWindowOptions.frame).toBe(false)
|
|
}
|
|
|
|
expect(windowHandlers.windowOpen({ url: 'https://example.com' })).toEqual({ action: 'deny' })
|
|
expect(windowHandlers.windowOpen({ url: 'localhost:3000' })).toEqual({ action: 'deny' })
|
|
expect(windowHandlers.windowOpen({ url: 'file:///etc/passwd' })).toEqual({ action: 'deny' })
|
|
expect(windowHandlers.windowOpen({ url: 'not a url' })).toEqual({ action: 'deny' })
|
|
|
|
expect(openExternalMock).toHaveBeenCalledTimes(2)
|
|
expect(openExternalMock).toHaveBeenCalledWith('https://example.com/')
|
|
expect(openExternalMock).toHaveBeenCalledWith('http://localhost:3000/')
|
|
|
|
const preventDefault = vi.fn()
|
|
windowHandlers['will-navigate']({ preventDefault } as never, 'https://example.com/docs')
|
|
expect(preventDefault).toHaveBeenCalledTimes(1)
|
|
expect(openExternalMock).toHaveBeenCalledTimes(3)
|
|
expect(openExternalMock).toHaveBeenLastCalledWith('https://example.com/docs')
|
|
|
|
const localhostPreventDefault = vi.fn()
|
|
windowHandlers['will-navigate'](
|
|
{ preventDefault: localhostPreventDefault } as never,
|
|
'localhost:3000'
|
|
)
|
|
expect(localhostPreventDefault).toHaveBeenCalledTimes(1)
|
|
expect(openExternalMock).toHaveBeenCalledTimes(4)
|
|
expect(openExternalMock).toHaveBeenLastCalledWith('http://localhost:3000/')
|
|
|
|
const fileNavigationPreventDefault = vi.fn()
|
|
windowHandlers['will-navigate'](
|
|
{ preventDefault: fileNavigationPreventDefault } as never,
|
|
'file:///etc/passwd'
|
|
)
|
|
expect(fileNavigationPreventDefault).toHaveBeenCalledTimes(1)
|
|
expect(openExternalMock).toHaveBeenCalledTimes(4)
|
|
|
|
const allowBlankEvent = { preventDefault: vi.fn() }
|
|
const allowBlankPrefs = { partition: 'persist:orca-browser' }
|
|
windowHandlers['will-attach-webview'](
|
|
allowBlankEvent as never,
|
|
allowBlankPrefs as never,
|
|
{ src: 'data:text/html,' } as never
|
|
)
|
|
expect(allowBlankEvent.preventDefault).not.toHaveBeenCalled()
|
|
expect(allowBlankPrefs).toMatchObject({
|
|
disableHtmlFullscreenWindowResize: true,
|
|
partition: 'persist:orca-browser',
|
|
preload: expect.stringMatching(/browser-window-close-preload\.js$/),
|
|
sandbox: true
|
|
})
|
|
|
|
const denyInlineHtmlEvent = { preventDefault: vi.fn() }
|
|
windowHandlers['will-attach-webview'](
|
|
denyInlineHtmlEvent as never,
|
|
{ partition: 'persist:orca-browser' } as never,
|
|
{ src: 'data:text/html,<script>alert(1)</script>' } as never
|
|
)
|
|
expect(denyInlineHtmlEvent.preventDefault).toHaveBeenCalledTimes(1)
|
|
|
|
const guest = { marker: 'guest' }
|
|
windowHandlers['did-attach-webview']({} as never, guest as never)
|
|
expect(attachGuestPoliciesMock).toHaveBeenCalledWith(guest)
|
|
|
|
const untrustedPreloadParams = {
|
|
src: 'data:text/html,',
|
|
preload: 'file:///tmp/untrusted-preload.js'
|
|
}
|
|
const hardenedPrefs = {
|
|
partition: 'persist:orca-browser',
|
|
preload: '/tmp/untrusted-preload.js'
|
|
}
|
|
windowHandlers['will-attach-webview'](
|
|
{ preventDefault: vi.fn() } as never,
|
|
hardenedPrefs as never,
|
|
untrustedPreloadParams as never
|
|
)
|
|
expect(untrustedPreloadParams.preload).toBeUndefined()
|
|
expect(hardenedPrefs.preload).toMatch(/browser-window-close-preload\.js$/)
|
|
expect(hardenedPrefs.preload).not.toContain('untrusted-preload')
|
|
|
|
const secondGuest = { marker: 'second-guest' }
|
|
windowHandlers['did-attach-webview']({} as never, secondGuest as never)
|
|
expect(attachGuestPoliciesMock).toHaveBeenLastCalledWith(secondGuest)
|
|
})
|
|
|
|
it('sets platform-specific titlebar and frame options for every desktop platform', () => {
|
|
for (const [platform, expected] of [
|
|
['darwin', { titleBarStyle: 'hiddenInset', frame: undefined }],
|
|
['win32', { titleBarStyle: 'hidden', frame: undefined }],
|
|
['linux', { titleBarStyle: undefined, frame: false }]
|
|
] satisfies [
|
|
NodeJS.Platform,
|
|
{ titleBarStyle: string | undefined; frame: boolean | undefined }
|
|
][]) {
|
|
browserWindowMock.mockReset()
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => true),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => [1200, 800]),
|
|
setSize: vi.fn(),
|
|
setWindowButtonPosition: vi.fn(),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
withPlatform(platform, () => createMainWindow(null))
|
|
|
|
const browserWindowOptions = browserWindowMock.mock.calls[0]?.[0]
|
|
expect(browserWindowOptions.titleBarStyle).toBe(expected.titleBarStyle)
|
|
expect(browserWindowOptions.frame).toBe(expected.frame)
|
|
}
|
|
})
|
|
|
|
it('never requests macOS vibrancy or transparency when window blur is enabled (#8482)', () => {
|
|
for (const [platform, expected] of [
|
|
['darwin', { backgroundMaterial: undefined }],
|
|
['win32', { backgroundMaterial: 'acrylic' }],
|
|
['linux', { backgroundMaterial: undefined }]
|
|
] satisfies [NodeJS.Platform, { backgroundMaterial: string | undefined }][]) {
|
|
browserWindowMock.mockReset()
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => false),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => [1200, 800]),
|
|
getBounds: vi.fn(() => ({ x: 10, y: 20, width: 1000, height: 700 })),
|
|
setSize: vi.fn(),
|
|
setWindowButtonPosition: vi.fn(),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
withPlatform(platform, () =>
|
|
createMainWindow({
|
|
getUI: () => ({}),
|
|
getSettings: () => ({ windowBackgroundBlur: true }),
|
|
updateUI: vi.fn()
|
|
} as never)
|
|
)
|
|
|
|
const browserWindowOptions = browserWindowMock.mock.calls[0]?.[0]
|
|
expect(browserWindowOptions.vibrancy).toBeUndefined()
|
|
expect(browserWindowOptions.transparent).toBeUndefined()
|
|
expect(browserWindowOptions.backgroundMaterial).toBe(expected.backgroundMaterial)
|
|
expect(browserWindowOptions.backgroundColor).toBe('#ffffff')
|
|
}
|
|
})
|
|
|
|
it('keeps macOS background throttling enabled while repainting visibility transitions', () => {
|
|
vi.useFakeTimers()
|
|
const windowHandlers = new Map<string, ((...args: any[]) => void)[]>()
|
|
let windowSize: [number, number] = [1200, 800]
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn((event: string, handler: (...args: any[]) => void) => {
|
|
const handlers = windowHandlers.get(event) ?? []
|
|
handlers.push(handler)
|
|
windowHandlers.set(event, handlers)
|
|
}),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => false),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => windowSize),
|
|
setSize: vi.fn((width: number, height: number) => {
|
|
windowSize = [width, height]
|
|
}),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
withPlatform('darwin', () => createMainWindow(null))
|
|
|
|
expect(webContents.setBackgroundThrottling).toHaveBeenCalledWith(true)
|
|
expect(webContents.setBackgroundThrottling).not.toHaveBeenCalledWith(false)
|
|
expect(windowHandlers.get('restore')).toHaveLength(1)
|
|
expect(windowHandlers.get('show')).toHaveLength(1)
|
|
expect(windowHandlers.get('focus')).toHaveLength(1)
|
|
|
|
windowHandlers.get('show')?.[0]?.()
|
|
windowHandlers.get('restore')?.[0]?.()
|
|
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(2)
|
|
// Why: the size nudge must never run inside the show/restore dispatch itself.
|
|
expect(browserWindowInstance.setSize).not.toHaveBeenCalled()
|
|
|
|
vi.advanceTimersByTime(0)
|
|
expect(browserWindowInstance.setSize).toHaveBeenNthCalledWith(1, 1201, 800)
|
|
expect(browserWindowInstance.setSize).toHaveBeenCalledTimes(1)
|
|
|
|
vi.advanceTimersByTime(32)
|
|
expect(browserWindowInstance.setSize).toHaveBeenNthCalledWith(2, 1200, 800)
|
|
|
|
vi.advanceTimersByTime(217)
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(2)
|
|
|
|
vi.advanceTimersByTime(1)
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(3)
|
|
|
|
// Why: focus covers occlusion-uncover with invalidate only — no setSize
|
|
// jiggle that would resize terminals on every window focus.
|
|
const setSizeCalls = browserWindowInstance.setSize.mock.calls.length
|
|
windowHandlers.get('focus')?.[0]?.()
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(4)
|
|
expect(browserWindowInstance.setSize).toHaveBeenCalledTimes(setSizeCalls)
|
|
})
|
|
|
|
it('runs a full repaint when the renderer relays a genuine window reveal (STA-2383)', () => {
|
|
vi.useFakeTimers()
|
|
const windowHandlers = new Map<string, ((...args: any[]) => void)[]>()
|
|
let windowSize: [number, number] = [1200, 800]
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn((event: string, handler: (...args: any[]) => void) => {
|
|
const handlers = windowHandlers.get(event) ?? []
|
|
handlers.push(handler)
|
|
windowHandlers.set(event, handlers)
|
|
}),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => false),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => windowSize),
|
|
setSize: vi.fn((width: number, height: number) => {
|
|
windowSize = [width, height]
|
|
}),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
withPlatform('darwin', () => createMainWindow(null))
|
|
|
|
const revealHandler = vi
|
|
.mocked(ipcMain.on)
|
|
.mock.calls.find(([channel]) => channel === 'ui:window-revealed')?.[1]
|
|
expect(revealHandler).toBeTypeOf('function')
|
|
|
|
// Why: a reveal relayed by another window's webContents must not repaint this one.
|
|
revealHandler?.({ sender: {} } as never)
|
|
expect(browserWindowInstance.setSize).not.toHaveBeenCalled()
|
|
expect(webContents.invalidate).not.toHaveBeenCalled()
|
|
|
|
// The genuine reveal runs the pre-Tahoe compositor jiggle that bare focus avoids.
|
|
revealHandler?.({ sender: webContents } as never)
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(1)
|
|
// Why: the nudge is deferred off the event dispatch turn.
|
|
expect(browserWindowInstance.setSize).not.toHaveBeenCalled()
|
|
vi.advanceTimersByTime(0)
|
|
expect(browserWindowInstance.setSize).toHaveBeenNthCalledWith(1, 1201, 800)
|
|
vi.advanceTimersByTime(32)
|
|
expect(browserWindowInstance.setSize).toHaveBeenNthCalledWith(2, 1200, 800)
|
|
|
|
// Repeated reveal signals while a jiggle is active repaint but do not multiply terminal resizes.
|
|
revealHandler?.({ sender: webContents } as never)
|
|
revealHandler?.({ sender: webContents } as never)
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(3)
|
|
vi.advanceTimersByTime(0)
|
|
expect(browserWindowInstance.setSize).toHaveBeenNthCalledWith(3, 1201, 800)
|
|
expect(browserWindowInstance.setSize).toHaveBeenCalledTimes(3)
|
|
|
|
// A user resize that lands during the jiggle must not be rolled back to stale bounds.
|
|
windowSize = [1400, 900]
|
|
vi.advanceTimersByTime(32)
|
|
expect(browserWindowInstance.setSize).toHaveBeenCalledTimes(3)
|
|
|
|
windowHandlers.get('closed')?.[0]?.()
|
|
expect(ipcMain.removeListener).toHaveBeenCalledWith('ui:window-revealed', revealHandler)
|
|
})
|
|
|
|
it('repaints without the size nudge on macOS 26+ where re-entrant frame updates can deadlock AppKit', () => {
|
|
vi.useFakeTimers()
|
|
macosTahoeMock.value = true
|
|
const windowHandlers = new Map<string, ((...args: any[]) => void)[]>()
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn((event: string, handler: (...args: any[]) => void) => {
|
|
const handlers = windowHandlers.get(event) ?? []
|
|
handlers.push(handler)
|
|
windowHandlers.set(event, handlers)
|
|
}),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => false),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => [1200, 800]),
|
|
setSize: vi.fn(),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
withPlatform('darwin', () => createMainWindow(null))
|
|
|
|
windowHandlers.get('show')?.[0]?.()
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(1)
|
|
|
|
// Why: the delayed second repaint must also stay setSize-free on Tahoe.
|
|
vi.advanceTimersByTime(300)
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(2)
|
|
expect(browserWindowInstance.setSize).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('invalidates a maximized macOS 26 window without changing its frame', () => {
|
|
vi.useFakeTimers()
|
|
macosTahoeMock.value = true
|
|
const windowHandlers = new Map<string, ((...args: any[]) => void)[]>()
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn((event: string, handler: (...args: any[]) => void) => {
|
|
const handlers = windowHandlers.get(event) ?? []
|
|
handlers.push(handler)
|
|
windowHandlers.set(event, handlers)
|
|
}),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => true),
|
|
isFullScreen: vi.fn(() => true),
|
|
getSize: vi.fn(() => [1200, 800]),
|
|
setSize: vi.fn(),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
withPlatform('darwin', () => createMainWindow(null))
|
|
|
|
windowHandlers.get('show')?.[0]?.()
|
|
vi.advanceTimersByTime(300)
|
|
|
|
expect(webContents.invalidate).toHaveBeenCalledTimes(2)
|
|
expect(browserWindowInstance.setSize).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('invalidates without frame or device emulation when macOS 26 wakes from sleep', () => {
|
|
vi.useFakeTimers()
|
|
macosTahoeMock.value = true
|
|
const windowHandlers = new Map<string, ((...args: any[]) => void)[]>()
|
|
const webContents = {
|
|
on: vi.fn(),
|
|
setZoomLevel: vi.fn(),
|
|
setBackgroundThrottling: vi.fn(),
|
|
invalidate: vi.fn(),
|
|
isDestroyed: vi.fn(() => false),
|
|
setWindowOpenHandler: vi.fn(),
|
|
send: vi.fn(),
|
|
isDevToolsOpened: vi.fn(),
|
|
openDevTools: vi.fn(),
|
|
closeDevTools: vi.fn(),
|
|
enableDeviceEmulation: vi.fn(),
|
|
disableDeviceEmulation: vi.fn()
|
|
}
|
|
const browserWindowInstance = {
|
|
webContents,
|
|
on: vi.fn((event: string, handler: (...args: any[]) => void) => {
|
|
const handlers = windowHandlers.get(event) ?? []
|
|
handlers.push(handler)
|
|
windowHandlers.set(event, handlers)
|
|
}),
|
|
isDestroyed: vi.fn(() => false),
|
|
isMaximized: vi.fn(() => false),
|
|
isFullScreen: vi.fn(() => false),
|
|
getSize: vi.fn(() => [1200, 800]),
|
|
setSize: vi.fn(),
|
|
maximize: vi.fn(),
|
|
show: vi.fn(),
|
|
loadFile: vi.fn(),
|
|
loadURL: vi.fn()
|
|
}
|
|
browserWindowMock.mockImplementation(function () {
|
|
return browserWindowInstance
|
|
})
|
|
|
|
withPlatform('darwin', () => createMainWindow(null))
|
|
|
|
const resumeHandler = powerMonitorOnMock.mock.calls.find(
|
|
([event]) => event === 'resume'
|
|
)?.[1] as (() => void) | undefined
|
|
expect(resumeHandler).toBeDefined()
|
|
resumeHandler?.()
|
|
|
|
expect(webContents.invalidate).toHaveBeenCalled()
|
|
vi.advanceTimersByTime(300)
|
|
expect(browserWindowInstance.setSize).not.toHaveBeenCalled()
|
|
expect(webContents.enableDeviceEmulation).not.toHaveBeenCalled()
|
|
expect(webContents.disableDeviceEmulation).not.toHaveBeenCalled()
|
|
})
|
|
})
|