mirror of
https://github.com/stablyai/orca.git
synced 2026-10-20 16:03:20 +00:00
* feat(github): bind projects to a specific gh account Adds per-project `Repo.ghAccount` so repo-scoped gh calls (create-worktree issue/PR search, work items, hosted-review reads and mutations) run as the bound account via ephemeral child-env token injection instead of the globally active gh login. Multi-account resolution is capability-gated (gh >= 2.40) and fails closed when the bound account or host is unavailable; Project View stays ambient by design. Repository settings gains a section for selecting or clearing a keyring-backed account (shadcn `Select`), with mixed-version "not enforced" handling for older remote runtimes. Attached `-Rhost/owner/repo` forms are covered by the host-drift guard and its tests; es/ja/ko/zh catalogs carry the section's strings. `getLocalProjectGhExecOptions` centralizes the binding lookup so every gh execution path picks it up, including the Electron `hostedReview:*` handlers that previously stayed on the ambient login. `gh auth token` (a keyring read) is exempt from the rate-limit breaker gate so a tripped bucket cannot turn a bound-token resolve into a false "unavailable". The `ghAccount` update field and the two binding RPC methods live in the shared RPC params contract; the generated catalog is regenerated. Fixes #13612 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012B3QEP5iP4WGGEpPLtkHqA * fix(settings): make GitHub account refresh secondary * fix(github): satisfy strict casting quality checks * test(rpc): use runtime fixture for repo binding * fix(github): preserve project account for PR worktree lookups * test(rpc): avoid incomplete runtime settings fixture * fix(i18n): add GitHub account refresh label * fix(i18n): refresh runtime required catalog * fix(windows): preserve mobile patch bytes --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Neil <neil@stably.ai>
114 lines
3.1 KiB
TypeScript
114 lines
3.1 KiB
TypeScript
import type { GitHubCreateIssueFields, GitHubIssueUpdate } from '../../shared/issue-mutation-types'
|
|
import type { GitHubOwnerRepo } from '../../shared/github/pull-request-types'
|
|
import type { GitHubPRReviewCommentInput } from '../../shared/github/comment-types'
|
|
import type { Repo } from '../../shared/repo-types'
|
|
import type { LocalProjectGhExecOptions } from '../project-runtime-git-options'
|
|
import {
|
|
addIssueComment,
|
|
addPRReviewComment,
|
|
addPRReviewCommentReply,
|
|
createIssue,
|
|
updateIssue
|
|
} from '../github/client'
|
|
|
|
type LocalGitArgs = [] | [LocalProjectGhExecOptions]
|
|
|
|
type RuntimeGitHubIssueCommentCommandsDeps = {
|
|
resolveRepo: (selector: string) => Promise<Repo>
|
|
getLocalGitArgs: (repo: Repo) => LocalGitArgs
|
|
}
|
|
|
|
export class RuntimeGitHubIssueCommentCommands {
|
|
constructor(private readonly deps: RuntimeGitHubIssueCommentCommandsDeps) {}
|
|
|
|
async createRepoIssue(
|
|
repoSelector: string,
|
|
title: string,
|
|
body: string,
|
|
fields?: GitHubCreateIssueFields
|
|
): Promise<Awaited<ReturnType<typeof createIssue>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return createIssue(
|
|
repo.path,
|
|
title,
|
|
body,
|
|
repo.issueSourcePreference,
|
|
repo.connectionId ?? null,
|
|
fields,
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
|
|
async updateRepoIssue(
|
|
repoSelector: string,
|
|
number: number,
|
|
updates: GitHubIssueUpdate
|
|
): Promise<Awaited<ReturnType<typeof updateIssue>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return updateIssue(
|
|
repo.path,
|
|
number,
|
|
updates,
|
|
repo.connectionId ?? null,
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
|
|
async addRepoIssueComment(
|
|
repoSelector: string,
|
|
number: number,
|
|
body: string,
|
|
prRepo?: GitHubOwnerRepo | null
|
|
): Promise<Awaited<ReturnType<typeof addIssueComment>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return addIssueComment(
|
|
repo.path,
|
|
number,
|
|
body,
|
|
repo.connectionId ?? null,
|
|
prRepo ?? null,
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
|
|
async addRepoPRReviewComment(
|
|
repoSelector: string,
|
|
args: Omit<GitHubPRReviewCommentInput, 'repoPath'>
|
|
): Promise<Awaited<ReturnType<typeof addPRReviewComment>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return addPRReviewComment({
|
|
repoPath: repo.path,
|
|
connectionId: repo.connectionId ?? null,
|
|
localGitOptions: this.deps.getLocalGitArgs(repo)[0],
|
|
...args
|
|
})
|
|
}
|
|
|
|
async addRepoPRReviewCommentReply(
|
|
repoSelector: string,
|
|
args: {
|
|
prNumber: number
|
|
commentId: number
|
|
body: string
|
|
threadId?: string
|
|
path?: string
|
|
line?: number
|
|
prRepo?: GitHubOwnerRepo | null
|
|
}
|
|
): Promise<Awaited<ReturnType<typeof addPRReviewCommentReply>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return addPRReviewCommentReply(
|
|
repo.path,
|
|
args.prNumber,
|
|
args.commentId,
|
|
args.body,
|
|
args.threadId,
|
|
args.path,
|
|
args.line,
|
|
repo.connectionId ?? null,
|
|
args.prRepo ?? null,
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
}
|