mirror of
https://github.com/stablyai/orca.git
synced 2026-09-26 00:02:34 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
144 lines
4.4 KiB
TypeScript
144 lines
4.4 KiB
TypeScript
import { existsSync } from 'node:fs'
|
|
import { win32 as pathWin32 } from 'node:path'
|
|
import { WINDOWS_GIT_BASH_SHELL } from '../shared/windows-terminal-shell'
|
|
|
|
type GitBashPathOptions = {
|
|
env?: NodeJS.ProcessEnv
|
|
exists?: (path: string) => boolean
|
|
platform?: NodeJS.Platform
|
|
}
|
|
|
|
function readEnv(env: NodeJS.ProcessEnv, names: string[]): string | undefined {
|
|
for (const name of names) {
|
|
const value = env[name]
|
|
if (value) {
|
|
return value
|
|
}
|
|
}
|
|
return undefined
|
|
}
|
|
|
|
function normalizePathSegment(segment: string): string {
|
|
const trimmed = segment.trim()
|
|
return trimmed.startsWith('"') && trimmed.endsWith('"') ? trimmed.slice(1, -1) : trimmed
|
|
}
|
|
|
|
function pushCandidate(
|
|
candidates: string[],
|
|
seen: Set<string>,
|
|
candidate: string | undefined
|
|
): void {
|
|
if (!candidate) {
|
|
return
|
|
}
|
|
const normalized = pathWin32.normalize(candidate)
|
|
const key = normalized.toLowerCase()
|
|
if (!seen.has(key)) {
|
|
seen.add(key)
|
|
candidates.push(normalized)
|
|
}
|
|
}
|
|
|
|
export function getGitBashCandidatePaths(env: NodeJS.ProcessEnv = process.env): string[] {
|
|
const candidates: string[] = []
|
|
const seen = new Set<string>()
|
|
const roots = [
|
|
readEnv(env, ['ProgramFiles', 'PROGRAMFILES']),
|
|
readEnv(env, ['ProgramW6432', 'PROGRAMW6432']),
|
|
readEnv(env, ['ProgramFiles(x86)', 'PROGRAMFILES(X86)']),
|
|
readEnv(env, ['LOCALAPPDATA', 'LocalAppData'])
|
|
]
|
|
|
|
for (const root of roots) {
|
|
if (!root) {
|
|
continue
|
|
}
|
|
pushCandidate(candidates, seen, pathWin32.join(root, 'Git', 'bin', 'bash.exe'))
|
|
pushCandidate(candidates, seen, pathWin32.join(root, 'Git', 'usr', 'bin', 'bash.exe'))
|
|
pushCandidate(candidates, seen, pathWin32.join(root, 'Programs', 'Git', 'bin', 'bash.exe'))
|
|
pushCandidate(
|
|
candidates,
|
|
seen,
|
|
pathWin32.join(root, 'Programs', 'Git', 'usr', 'bin', 'bash.exe')
|
|
)
|
|
}
|
|
|
|
const pathValue = readEnv(env, ['Path', 'PATH'])
|
|
if (pathValue) {
|
|
for (const rawSegment of pathValue.split(pathWin32.delimiter)) {
|
|
const segment = normalizePathSegment(rawSegment)
|
|
if (!segment) {
|
|
continue
|
|
}
|
|
const directBashCandidate = pathWin32.join(segment, 'bash.exe')
|
|
if (isGitForWindowsBashPath(directBashCandidate)) {
|
|
pushCandidate(candidates, seen, directBashCandidate)
|
|
}
|
|
|
|
const basename = pathWin32.basename(segment).toLowerCase()
|
|
const parent = pathWin32.dirname(segment)
|
|
const parentBasename = pathWin32.basename(parent).toLowerCase()
|
|
if (basename === 'cmd' && (parentBasename === 'git' || parentBasename === 'portablegit')) {
|
|
pushCandidate(candidates, seen, pathWin32.join(parent, 'bin', 'bash.exe'))
|
|
pushCandidate(candidates, seen, pathWin32.join(parent, 'usr', 'bin', 'bash.exe'))
|
|
} else if (basename === 'git' || basename === 'portablegit') {
|
|
pushCandidate(candidates, seen, pathWin32.join(segment, 'bin', 'bash.exe'))
|
|
pushCandidate(candidates, seen, pathWin32.join(segment, 'usr', 'bin', 'bash.exe'))
|
|
}
|
|
}
|
|
}
|
|
|
|
return candidates
|
|
}
|
|
|
|
export function resolveGitBashPath(options: GitBashPathOptions = {}): string | null {
|
|
const platform = options.platform ?? process.platform
|
|
if (platform !== 'win32') {
|
|
return null
|
|
}
|
|
const exists = options.exists ?? existsSync
|
|
for (const candidate of getGitBashCandidatePaths(options.env ?? process.env)) {
|
|
if (isGitForWindowsBashPath(candidate) && exists(candidate)) {
|
|
return candidate
|
|
}
|
|
}
|
|
return null
|
|
}
|
|
|
|
export function isGitBashAvailable(): boolean {
|
|
return resolveGitBashPath() !== null
|
|
}
|
|
|
|
export function isGitForWindowsBashPath(shellPath: string): boolean {
|
|
const normalized = pathWin32.normalize(shellPath).toLowerCase()
|
|
return /(?:^|\\)(?:git|portablegit)(?:\\usr)?\\bin\\bash\.exe$/.test(normalized)
|
|
}
|
|
|
|
export function resolveWindowsGitBashShellPath(
|
|
shell: string,
|
|
options: GitBashPathOptions = {}
|
|
): string | null {
|
|
const trimmed = shell.trim()
|
|
if (!trimmed) {
|
|
return null
|
|
}
|
|
if (trimmed === WINDOWS_GIT_BASH_SHELL) {
|
|
return resolveGitBashPath(options)
|
|
}
|
|
|
|
const shellBasename = pathWin32.basename(trimmed).toLowerCase()
|
|
if (shellBasename !== 'bash.exe') {
|
|
return null
|
|
}
|
|
|
|
if (pathWin32.isAbsolute(trimmed) || trimmed.includes('\\') || trimmed.includes('/')) {
|
|
return isGitForWindowsBashPath(trimmed) ? trimmed : null
|
|
}
|
|
|
|
return resolveGitBashPath(options)
|
|
}
|
|
|
|
export function isWindowsGitBashShellPath(shellPath: string): boolean {
|
|
return isGitForWindowsBashPath(shellPath)
|
|
}
|