mirror of
https://github.com/stablyai/orca.git
synced 2026-10-01 08:01:56 +00:00
Neil
77f23b013f
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
79 lines
3.1 KiB
TypeScript
79 lines
3.1 KiB
TypeScript
import type {
|
|
EnrichedDetectedPort,
|
|
PortForwardEntry,
|
|
SshConfigHostListArgs,
|
|
SshConfigHostListResult,
|
|
SshConfigHostResolution,
|
|
SshConfigImportResult,
|
|
SshConnectionState,
|
|
SshTarget,
|
|
SshTargetAddResult
|
|
} from '../../shared/ssh-types'
|
|
import type { FilesystemPathFlavor } from '../../shared/filesystem-entry-types'
|
|
|
|
export type SshApi = {
|
|
listTargets: () => Promise<SshTarget[]>
|
|
// Removed-target id → last known label, for a friendly host name on workspaces still pinned to a removed target.
|
|
listRemovedTargetLabels: () => Promise<Record<string, string>>
|
|
addTarget: (args: { target: Omit<SshTarget, 'id'> }) => Promise<SshTargetAddResult>
|
|
updateTarget: (args: {
|
|
id: string
|
|
updates: Partial<Omit<SshTarget, 'id'>>
|
|
}) => Promise<SshTarget>
|
|
removeTarget: (args: { id: string }) => Promise<void>
|
|
importConfig: (args?: { reAdopt?: boolean }) => Promise<SshConfigImportResult>
|
|
listConfigHosts: (args?: SshConfigHostListArgs) => Promise<SshConfigHostListResult>
|
|
resolveConfigHost: (args: { alias: string }) => Promise<SshConfigHostResolution | null>
|
|
connect: (args: { targetId: string }) => Promise<SshConnectionState | null>
|
|
disconnect: (args: { targetId: string }) => Promise<void>
|
|
terminateSessions: (args: { targetId: string }) => Promise<void>
|
|
resetRelay: (args: { targetId: string }) => Promise<void>
|
|
getState: (args: { targetId: string }) => Promise<SshConnectionState | null>
|
|
needsPassphrasePrompt: (args: { targetId: string }) => Promise<boolean>
|
|
testConnection: (args: {
|
|
targetId: string
|
|
}) => Promise<{ success: boolean; error?: string; state?: SshConnectionState }>
|
|
onStateChanged: (
|
|
callback: (data: { targetId: string; state: SshConnectionState }) => void
|
|
) => () => void
|
|
addPortForward: (args: {
|
|
targetId: string
|
|
localPort: number
|
|
remoteHost: string
|
|
remotePort: number
|
|
label?: string
|
|
}) => Promise<PortForwardEntry>
|
|
updatePortForward: (args: {
|
|
id: string
|
|
targetId: string
|
|
localPort: number
|
|
remoteHost: string
|
|
remotePort: number
|
|
label?: string
|
|
}) => Promise<PortForwardEntry>
|
|
removePortForward: (args: { id: string }) => Promise<PortForwardEntry | null>
|
|
listPortForwards: (args?: { targetId?: string }) => Promise<PortForwardEntry[]>
|
|
listDetectedPorts: (args: { targetId: string }) => Promise<EnrichedDetectedPort[]>
|
|
onPortForwardsChanged: (
|
|
callback: (data: { targetId: string; forwards: PortForwardEntry[] }) => void
|
|
) => () => void
|
|
onDetectedPortsChanged: (
|
|
callback: (data: { targetId: string; ports: EnrichedDetectedPort[] }) => void
|
|
) => () => void
|
|
browseDir: (args: { targetId: string; dirPath: string }) => Promise<{
|
|
entries: { name: string; isDirectory: boolean }[]
|
|
resolvedPath: string
|
|
pathFlavor: FilesystemPathFlavor
|
|
}>
|
|
onCredentialRequest: (
|
|
callback: (data: {
|
|
requestId: string
|
|
targetId: string
|
|
kind: 'passphrase' | 'password'
|
|
detail: string
|
|
}) => void
|
|
) => () => void
|
|
onCredentialResolved: (callback: (data: { requestId: string }) => void) => () => void
|
|
submitCredential: (args: { requestId: string; value: string | null }) => Promise<void>
|
|
}
|