mirror of
https://github.com/stablyai/orca.git
synced 2026-10-20 08:03:28 +00:00
Jinwoo-H
eb7e27ba0b
Every guide leads with Result / Done / Safe failure, states conditions instead of case lists, keeps one done bar and one autonomy envelope, and loads references at the point of use via `skills get <topic> --full`. orca-cli drops from 424 to 260 always-loaded lines with three references; orca-per-workspace-env from 794 to 397 with five. Defects fixed in shipped guides: `emulator camera` (no such command), iOS `permissions` (backend refuses it), Android pane described as in development, `relayGracePeriodSeconds: 0` documented as immediate teardown (it is unbounded), doctor `ok: true` hiding `warn`, an SSH exemplar setting both `jumpHost` and `proxyCommand`, a provisioned-root fetch from `origin`, and the Linear unconfirmed-write rule keyed on four verbs when ten emit it. The resolver ladder, placeholder rule, and older-binary fallback shared by every installable SKILL.md now come from one skill-stubs/_shared/cli-resolution.md fragment composed by the generator, which also bundles per-guide references into --full. New guards: every ORCA invocation and flag resolves against COMMAND_SPECS, descriptions carry no angle-bracket tokens, reference routing is checked both ways, and an always-loaded size ratchet (300 lines) that guides may leave but never join.
53 lines
2.1 KiB
JavaScript
53 lines
2.1 KiB
JavaScript
import { readdirSync, readFileSync } from 'node:fs'
|
|
import { join, resolve } from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
import { parse } from 'yaml'
|
|
|
|
const skillsDir = resolve(import.meta.dirname, '../../skills')
|
|
// Why: the Agent Skills spec caps `description` at 1024 chars and conforming installers
|
|
// reject the whole skill (#17935); the frontmatter is what the installer parses, so check it.
|
|
const MAX_DESCRIPTION_LENGTH = 1024
|
|
// Why raw, not backtick-stripped: NVIDIA SkillEvaluator rejects `<tag>` in a description as a
|
|
// schema error, and Cowork's validator parses descriptions as HTML and fails the whole plugin
|
|
// silently (compound-engineering #602). Neither honors backticks, so placeholders belong in the body.
|
|
const ANGLE_BRACKET_TOKEN = /<[A-Za-z][\w.-]*>/u
|
|
|
|
function readDescription(skillName) {
|
|
const skillMarkdown = readFileSync(join(skillsDir, skillName, 'SKILL.md'), 'utf8')
|
|
const frontmatter = /^---\r?\n([\s\S]*?)\r?\n---\r?\n/u.exec(skillMarkdown)?.[1]
|
|
|
|
expect(frontmatter, `${skillName}: missing frontmatter`).toBeDefined()
|
|
|
|
return parse(frontmatter ?? '').description
|
|
}
|
|
|
|
describe('bundled skill descriptions', () => {
|
|
const skillNames = readdirSync(skillsDir, { withFileTypes: true })
|
|
.filter((entry) => entry.isDirectory())
|
|
.map((entry) => entry.name)
|
|
|
|
it('discovers the bundled skills', () => {
|
|
expect(skillNames).toContain('orchestration')
|
|
})
|
|
|
|
it.each(skillNames)('%s keeps description within the Agent Skills spec limit', (name) => {
|
|
const description = readDescription(name)
|
|
|
|
expect(typeof description, `${name}: description must be a string`).toBe('string')
|
|
expect(description.trim().length, `${name}: description is empty`).toBeGreaterThan(0)
|
|
expect(
|
|
description.length,
|
|
`${name}: description is ${description.length} chars`
|
|
).toBeLessThanOrEqual(MAX_DESCRIPTION_LENGTH)
|
|
})
|
|
|
|
it.each(skillNames)('%s keeps angle-bracket placeholders out of its description', (name) => {
|
|
const token = ANGLE_BRACKET_TOKEN.exec(readDescription(name) ?? '')
|
|
|
|
expect(
|
|
token?.[0],
|
|
`${name}: rephrase or move "${token?.[0] ?? ''}" into the skill body`
|
|
).toBeUndefined()
|
|
})
|
|
})
|