mirror of
https://github.com/stablyai/orca.git
synced 2026-11-13 17:37:40 +00:00
Neil
1824515698
Orca already drops protected strings when it loads a language pack and keeps its own English text for trust, permission and destructive dialogs. validate:plugin and orca plugin validate still rejected the whole pack, so the community directory refused otherwise-good packs. They now report how many protected strings are ignored as a warning; every other pack rule stays strict.
65 lines
2.4 KiB
JavaScript
65 lines
2.4 KiB
JavaScript
import { mkdtemp, rm, writeFile } from 'node:fs/promises'
|
|
import { tmpdir } from 'node:os'
|
|
import path from 'node:path'
|
|
import process from 'node:process'
|
|
import { runProcess } from '@orca/process-host'
|
|
import { afterEach, describe, expect, it } from 'vitest'
|
|
import { createPluginFromTemplate } from '../../../../src/cli/plugin-authoring/plugin-create'
|
|
|
|
const SCRIPT = path.join(import.meta.dirname, './validate-plugin-files.mjs')
|
|
const roots = []
|
|
|
|
async function tempRoot() {
|
|
const root = await mkdtemp(path.join(tmpdir(), 'orca-validate-plugin-files-'))
|
|
roots.push(root)
|
|
return root
|
|
}
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(roots.splice(0).map((root) => rm(root, { recursive: true, force: true })))
|
|
})
|
|
|
|
function validate(...targets) {
|
|
return runProcess({
|
|
program: process.execPath,
|
|
args: [SCRIPT, ...targets],
|
|
timeoutMs: 60_000
|
|
})
|
|
}
|
|
|
|
describe('validate-plugin-files', () => {
|
|
it('fails with exit 1 when a file the manifest names is missing', async () => {
|
|
const dir = path.join(await tempRoot(), 'panel')
|
|
await createPluginFromTemplate({ dir, template: 'panel', publisher: 'acme' })
|
|
await rm(path.join(dir, 'panel', 'index.html'))
|
|
const result = await validate(dir)
|
|
expect(result.code).toBe(1)
|
|
expect(result.stderr).toContain('panel/index.html')
|
|
}, 60_000)
|
|
|
|
it('passes a scaffolded plugin, explaining why there is no release entry outside Git', async () => {
|
|
const dir = path.join(await tempRoot(), 'dusk')
|
|
await createPluginFromTemplate({ dir, template: 'theme', publisher: 'acme' })
|
|
const result = await validate(dir)
|
|
expect(result.code, result.stderr).toBe(0)
|
|
expect(result.stdout).toContain('not in a Git repository')
|
|
}, 60_000)
|
|
|
|
it('passes a language pack that translates protected copy, warning that Orca ignores it', async () => {
|
|
const dir = path.join(await tempRoot(), 'portuguese')
|
|
await createPluginFromTemplate({ dir, template: 'language-pack', publisher: 'acme' })
|
|
await writeFile(
|
|
path.join(dir, 'locales', 'pt-BR.json'),
|
|
JSON.stringify({
|
|
common: { cancel: 'Cancelar' },
|
|
components: { 'native-chat': { approval: { allow: 'Permitir', deny: 'Negar' } } }
|
|
})
|
|
)
|
|
const result = await validate(dir)
|
|
expect(result.code, result.stderr).toBe(0)
|
|
expect(result.stderr).toContain(
|
|
'warning: contributes.languagePacks "pt-BR" (locales/pt-BR.json): 2 protected strings are ignored'
|
|
)
|
|
}, 60_000)
|
|
})
|