mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 17:17:38 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
465 lines
18 KiB
JavaScript
465 lines
18 KiB
JavaScript
import { spawnSync } from 'node:child_process'
|
|
import {
|
|
copyFileSync,
|
|
existsSync,
|
|
mkdirSync,
|
|
mkdtempSync,
|
|
readFileSync,
|
|
rmSync,
|
|
writeFileSync
|
|
} from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { createRequire } from 'node:module'
|
|
import { isAbsolute, join, parse } from 'node:path'
|
|
import { fileURLToPath, pathToFileURL } from 'node:url'
|
|
import { describe, expect, it } from 'vitest'
|
|
import { runProcessSync } from '@orca/process-host'
|
|
import { DEFAULT_MAX_OUTPUT_BYTES } from '@orca/process-host/process-spec'
|
|
import { resolveCliCommand } from '../../src/shared/node-cli-command-resolution.ts'
|
|
import { removeTreeSync } from '../../src/shared/windows-transient-lock-removal.ts'
|
|
import { resolvePnpmCliInvocation } from './pnpm-cli-invocation.mjs'
|
|
import { copyScriptWithLocalModules } from './script-module-dependencies.mjs'
|
|
import {
|
|
nodeGypRebuildInvocation,
|
|
nodeGypRebuildTimeoutMs
|
|
} from './windows-process-tree-gyp-rebuild.mjs'
|
|
|
|
const sourceScriptPath = fileURLToPath(new URL('./ensure-native-runtime.mjs', import.meta.url))
|
|
// Fixture import walk misses createRequire CJS edges; name siblings explicitly or temp project cannot load.
|
|
const REQUIRED_CJS_SIBLINGS = [
|
|
'node-pty-job-ownership.cjs',
|
|
'windows-process-tree-creation-time.cjs'
|
|
]
|
|
|
|
describe('ensure-native-runtime', () => {
|
|
it('rechecks Node native modules in fresh child processes after rebuilding', () => {
|
|
const projectDir = mkTempProject()
|
|
|
|
try {
|
|
const scriptPath = join(projectDir, 'config', 'scripts', 'ensure-native-runtime.mjs')
|
|
const logPath = join(projectDir, 'native-runtime.log')
|
|
const markerPath = join(projectDir, 'rebuilt.marker')
|
|
writeFakeNativeModules(projectDir)
|
|
writeNodePtyPatchFile(projectDir)
|
|
writeFakeNodeGyp(projectDir)
|
|
const verboseOutputBytes = DEFAULT_MAX_OUTPUT_BYTES + 1024 * 1024
|
|
|
|
const result = spawnSync(process.execPath, [scriptPath, '--runtime=node'], {
|
|
cwd: projectDir,
|
|
encoding: 'utf8',
|
|
maxBuffer: DEFAULT_MAX_OUTPUT_BYTES * 4,
|
|
env: envForNativeFixture(projectDir, {
|
|
ORCA_NATIVE_TEST_LOG: logPath,
|
|
ORCA_NATIVE_TEST_MARKER: markerPath,
|
|
ORCA_NATIVE_TEST_VERBOSE_OUTPUT_BYTES: String(verboseOutputBytes)
|
|
})
|
|
})
|
|
|
|
expect(result.status, result.stderr).toBe(0)
|
|
expect(result.stdout.indexOf('node-gyp stdout complete\n')).toBe(verboseOutputBytes)
|
|
expect(/^x+$/.test(result.stdout.slice(0, verboseOutputBytes))).toBe(true)
|
|
expect(result.stderr).toContain('node-gyp stderr complete\n')
|
|
const log = readFileSync(logPath, 'utf8')
|
|
expect(log).toContain(`node-gyp rebuild --arch=${process.arch}\n`)
|
|
expect(log).toContain(`node-gyp timeout=${nodeGypRebuildTimeoutMs('node-pty')}\n`)
|
|
expect(log).toContain(`trackFileAccess=${process.platform === 'win32' ? 'false' : ''}\n`)
|
|
expect(log).toContain(join('node_modules', 'node-pty'))
|
|
if (process.platform === 'linux') {
|
|
expect(log).toMatch(/^cxxflags=(?:.*\s)?-std=gnu\+\+2a$/m)
|
|
}
|
|
expect(log.split('\n').filter((line) => line.startsWith('node-pty child '))).toEqual([
|
|
expect.stringMatching(/^node-pty child (?:conpty|pty) marker=false$/),
|
|
expect.stringMatching(/^node-pty child (?:conpty|pty) marker=true$/)
|
|
])
|
|
} finally {
|
|
rmSync(projectDir, { recursive: true, force: true })
|
|
}
|
|
})
|
|
|
|
it.skipIf(process.platform !== 'win32').each([
|
|
{ trackingEnv: {}, tracking: 'false' },
|
|
{ trackingEnv: { TrackFileAccess: 'true' }, tracking: 'true' },
|
|
{ trackingEnv: { trackfileaccess: 'true' }, tracking: 'true' },
|
|
{ trackingEnv: { tRaCkFiLeAcCeSs: 'false' }, tracking: 'false' }
|
|
])(
|
|
'rebuilds other failed Windows addons with patched node-pty and tracking=$tracking',
|
|
({ trackingEnv, tracking }) => {
|
|
const projectDir = mkTempProject()
|
|
|
|
try {
|
|
const scriptPath = join(projectDir, 'config', 'scripts', 'ensure-native-runtime.mjs')
|
|
const logPath = join(projectDir, 'native-runtime.log')
|
|
const markerPath = join(projectDir, 'rebuilt.marker')
|
|
writeFakeNativeModules(projectDir, { windowsRegistryRequiresMarker: true })
|
|
writeNodePtyPatchFile(projectDir)
|
|
writeFakeNodeGyp(projectDir)
|
|
|
|
const result = spawnSync(process.execPath, [scriptPath, '--runtime=node'], {
|
|
cwd: projectDir,
|
|
encoding: 'utf8',
|
|
env: envForNativeFixture(projectDir, {
|
|
...trackingEnv,
|
|
ORCA_NATIVE_TEST_LOG: logPath,
|
|
ORCA_NATIVE_TEST_MARKER: markerPath
|
|
})
|
|
})
|
|
|
|
expect(result.status, result.stderr).toBe(0)
|
|
const log = readFileSync(logPath, 'utf8')
|
|
expect(
|
|
log.split('\n').filter((line) => line === `node-gyp rebuild --arch=${process.arch}`)
|
|
).toHaveLength(2)
|
|
expect(
|
|
log.split('\n').filter((line) => line === `trackFileAccess=${tracking}`)
|
|
).toHaveLength(2)
|
|
expect(log).toContain(join('node_modules', 'node-pty'))
|
|
expect(log).toContain(join('node_modules', '@orca', 'windows-registry'))
|
|
} finally {
|
|
rmSync(projectDir, { recursive: true, force: true })
|
|
}
|
|
}
|
|
)
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'rebuilds patched node-pty artifacts even when the Node load check passes',
|
|
() => {
|
|
const projectDir = mkTempProject()
|
|
|
|
try {
|
|
const scriptPath = join(projectDir, 'config', 'scripts', 'ensure-native-runtime.mjs')
|
|
const logPath = join(projectDir, 'native-runtime.log')
|
|
const markerPath = join(projectDir, 'rebuilt.marker')
|
|
writeLoadableNativeModules(projectDir)
|
|
writeNodePtyPatchFile(projectDir)
|
|
writeFakeNodeGyp(projectDir)
|
|
|
|
const result = spawnSync(process.execPath, [scriptPath, '--runtime=node'], {
|
|
cwd: projectDir,
|
|
encoding: 'utf8',
|
|
env: envForNativeFixture(projectDir, {
|
|
ORCA_NATIVE_TEST_LOG: logPath,
|
|
ORCA_NATIVE_TEST_MARKER: markerPath
|
|
})
|
|
})
|
|
|
|
expect(result.status, result.stderr).toBe(0)
|
|
expect(result.stderr).toContain(
|
|
'Patched node-pty build artifacts are missing; rebuilding native deps.'
|
|
)
|
|
expect(readFileSync(logPath, 'utf8')).toContain(`node-gyp rebuild --arch=${process.arch}\n`)
|
|
} finally {
|
|
rmSync(projectDir, { recursive: true, force: true })
|
|
}
|
|
}
|
|
)
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'rebuilds when patched artifacts exist but node-pty resolves to prebuilds',
|
|
() => {
|
|
const projectDir = mkTempProject()
|
|
|
|
try {
|
|
const scriptPath = join(projectDir, 'config', 'scripts', 'ensure-native-runtime.mjs')
|
|
const logPath = join(projectDir, 'native-runtime.log')
|
|
const markerPath = join(projectDir, 'rebuilt.marker')
|
|
writeLoadableNativeModules(projectDir)
|
|
writeNodePtyPatchFile(projectDir)
|
|
writePatchedNodePtyBuildArtifacts(projectDir)
|
|
writeFakeNodeGyp(projectDir)
|
|
|
|
const result = spawnSync(process.execPath, [scriptPath, '--runtime=node'], {
|
|
cwd: projectDir,
|
|
encoding: 'utf8',
|
|
env: envForNativeFixture(projectDir, {
|
|
ORCA_NATIVE_TEST_LOG: logPath,
|
|
ORCA_NATIVE_TEST_MARKER: markerPath
|
|
})
|
|
})
|
|
|
|
expect(result.status, result.stderr).toBe(0)
|
|
expect(result.stderr).toContain("expected build/Release so Orca's node-pty patch is active")
|
|
expect(readFileSync(logPath, 'utf8')).toContain(`node-gyp rebuild --arch=${process.arch}\n`)
|
|
} finally {
|
|
rmSync(projectDir, { recursive: true, force: true })
|
|
}
|
|
}
|
|
)
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'keeps the fast path when the platform-specific patched artifacts exist',
|
|
() => {
|
|
const projectDir = mkTempProject()
|
|
|
|
try {
|
|
const scriptPath = join(projectDir, 'config', 'scripts', 'ensure-native-runtime.mjs')
|
|
const logPath = join(projectDir, 'native-runtime.log')
|
|
const markerPath = join(projectDir, 'rebuilt.marker')
|
|
writeLoadableNativeModules(projectDir, { nativeDir: '../build/Release/' })
|
|
writeNodePtyPatchFile(projectDir)
|
|
writePatchedNodePtyBuildArtifacts(projectDir)
|
|
writeFakeNodeGyp(projectDir)
|
|
|
|
const result = spawnSync(process.execPath, [scriptPath, '--runtime=node'], {
|
|
cwd: projectDir,
|
|
encoding: 'utf8',
|
|
env: envForNativeFixture(projectDir, {
|
|
ORCA_NATIVE_TEST_LOG: logPath,
|
|
ORCA_NATIVE_TEST_MARKER: markerPath
|
|
})
|
|
})
|
|
|
|
expect(result.status, result.stderr).toBe(0)
|
|
expect(result.stderr).not.toContain('Patched node-pty build artifacts are missing')
|
|
expect(readFileSync(logPath, 'utf8')).not.toContain('node-gyp rebuild')
|
|
} finally {
|
|
rmSync(projectDir, { recursive: true, force: true })
|
|
}
|
|
}
|
|
)
|
|
it('finds the installed node-gyp entry from an addon without build tools on PATH', () => {
|
|
const { command, prefixArgs } = resolvePnpmCliInvocation()
|
|
const program = isAbsolute(command) ? command : resolveCliCommand(parse(command).name)
|
|
expect(isAbsolute(program), 'pnpm must be installed for the native rebuild contract').toBe(true)
|
|
const projectDir = mkTempProject()
|
|
try {
|
|
writeFakeNativeModules(projectDir)
|
|
const addonDir = join(projectDir, 'node_modules', 'node-pty')
|
|
const env = { ...process.env, ORCA_BACKGROUND_LAUNCH: '1' }
|
|
for (const key of Object.keys(env)) {
|
|
if (key.toLowerCase() === 'path') {
|
|
env[key] = ''
|
|
}
|
|
}
|
|
const oldInvocation = runProcessSync({
|
|
program,
|
|
args: [
|
|
...prefixArgs,
|
|
'--config.verify-deps-before-run=false',
|
|
'exec',
|
|
'node-gyp',
|
|
'--version'
|
|
],
|
|
cwd: addonDir,
|
|
env,
|
|
timeoutMs: 20_000
|
|
})
|
|
expect(oldInvocation.code).not.toBe(0)
|
|
expect(`${oldInvocation.stdout}\n${oldInvocation.stderr}`).toContain(
|
|
'Command "node-gyp" not found'
|
|
)
|
|
const { args, cwd } = nodeGypRebuildInvocation(process.arch, addonDir)
|
|
const installedInvocation = runProcessSync({
|
|
program: process.execPath,
|
|
args: [args[0], '--version'],
|
|
cwd,
|
|
env,
|
|
timeoutMs: 20_000
|
|
})
|
|
expect(
|
|
installedInvocation.code,
|
|
`${installedInvocation.stdout}\n${installedInvocation.stderr}`
|
|
).toBe(0)
|
|
const manifest = JSON.parse(
|
|
readFileSync(new URL('../../node_modules/node-gyp/package.json', import.meta.url), 'utf8')
|
|
)
|
|
expect(installedInvocation.stdout.trim()).toBe(`v${manifest.version}`)
|
|
expect(existsSync(join(addonDir, 'pnpm-lock.yaml'))).toBe(false)
|
|
} finally {
|
|
removeTreeSync(projectDir)
|
|
}
|
|
})
|
|
})
|
|
|
|
function mkTempProject() {
|
|
const projectDir = mkdtempSync(join(tmpdir(), 'orca-native-runtime-'))
|
|
// Copy walked windows-process-tree-gyp-rebuild dependency or every case fails before its intended check.
|
|
copyScriptWithLocalModules(sourceScriptPath, join(projectDir, 'config', 'scripts'))
|
|
const processPackage = join(projectDir, 'node_modules', '@orca', 'process-host')
|
|
mkdirSync(processPackage, { recursive: true })
|
|
writeFileSync(
|
|
join(processPackage, 'package.json'),
|
|
JSON.stringify({ name: '@orca/process-host', type: 'module', exports: './index.mjs' })
|
|
)
|
|
writeFileSync(
|
|
join(processPackage, 'index.mjs'),
|
|
`import { appendFileSync } from 'node:fs'
|
|
import { runProcessSync as run } from ${JSON.stringify(pathToFileURL(createRequire(import.meta.url).resolve('@orca/process-host')).href)}
|
|
export function runProcessSync(options) {
|
|
appendFileSync(process.env.ORCA_NATIVE_TEST_LOG, \`node-gyp timeout=\${options.timeoutMs}\\n\`)
|
|
return run(options)
|
|
}
|
|
`
|
|
)
|
|
for (const name of REQUIRED_CJS_SIBLINGS) {
|
|
copyFileSync(
|
|
fileURLToPath(new URL(`./${name}`, import.meta.url)),
|
|
join(projectDir, 'config', 'scripts', name)
|
|
)
|
|
}
|
|
return projectDir
|
|
}
|
|
|
|
function envForNativeFixture(projectDir, extraEnv) {
|
|
// An inherited tracking preference would mask the Windows default under test.
|
|
const inherited = Object.fromEntries(
|
|
Object.entries(process.env).filter(([key]) => key.toLowerCase() !== 'trackfileaccess')
|
|
)
|
|
return {
|
|
...inherited,
|
|
...extraEnv,
|
|
npm_config_node_gyp: join(projectDir, 'node_modules', 'node-gyp', 'bin', 'node-gyp.js')
|
|
}
|
|
}
|
|
|
|
function writeFakeNativeModules(projectDir, { windowsRegistryRequiresMarker = false } = {}) {
|
|
const nodePtyDir = join(projectDir, 'node_modules', 'node-pty')
|
|
mkdirSync(join(nodePtyDir, 'lib'), { recursive: true })
|
|
writeFileSync(
|
|
join(nodePtyDir, 'package.json'),
|
|
'{"name":"node-pty","version":"1.1.0","main":"index.js"}\n'
|
|
)
|
|
mkdirSync(join(nodePtyDir, 'scripts'), { recursive: true })
|
|
writeFileSync(join(nodePtyDir, 'scripts', 'post-install.js'), '')
|
|
|
|
writeFileSync(join(nodePtyDir, 'index.js'), 'module.exports = {}\n')
|
|
writeFileSync(
|
|
join(nodePtyDir, 'lib', 'utils.js'),
|
|
`
|
|
const { appendFileSync, existsSync } = require('node:fs')
|
|
|
|
exports.loadNativeModule = function loadNativeModule(nativeName) {
|
|
const markerExists = existsSync(process.env.ORCA_NATIVE_TEST_MARKER)
|
|
appendFileSync(
|
|
process.env.ORCA_NATIVE_TEST_LOG,
|
|
\`node-pty \${process.argv.includes('--check-only') ? 'child' : 'parent'} \${nativeName} marker=\${markerExists}\\n\`
|
|
)
|
|
if (!markerExists) {
|
|
throw new Error('ABI mismatch sentinel')
|
|
}
|
|
return {
|
|
dir: '../build/Release/',
|
|
module: {
|
|
listJobProcessIds() {},
|
|
terminateJob() {},
|
|
assignCurrentProcessToJob() {}
|
|
}
|
|
}
|
|
}
|
|
`
|
|
)
|
|
writeFakeWindowsRegistry(projectDir, { requiresMarker: windowsRegistryRequiresMarker })
|
|
if (process.platform === 'win32') {
|
|
const buildDir = join(nodePtyDir, 'build', 'Release')
|
|
writePatchedNodePtyBuildArtifacts(projectDir)
|
|
writeFileSync(join(buildDir, 'conpty.node'), Buffer.from('msys-2.0.dll', 'utf16le'))
|
|
}
|
|
}
|
|
|
|
function writeLoadableNativeModules(projectDir, { nativeDir = null } = {}) {
|
|
const nodePtyDir = join(projectDir, 'node_modules', 'node-pty')
|
|
mkdirSync(join(nodePtyDir, 'lib'), { recursive: true })
|
|
writeFileSync(
|
|
join(nodePtyDir, 'package.json'),
|
|
'{"name":"node-pty","version":"1.1.0","main":"index.js"}\n'
|
|
)
|
|
mkdirSync(join(nodePtyDir, 'scripts'), { recursive: true })
|
|
writeFileSync(join(nodePtyDir, 'scripts', 'post-install.js'), '')
|
|
|
|
writeFileSync(join(nodePtyDir, 'index.js'), 'module.exports = {}\n')
|
|
writeFileSync(
|
|
join(nodePtyDir, 'lib', 'utils.js'),
|
|
`
|
|
const { appendFileSync, existsSync } = require('node:fs')
|
|
|
|
exports.loadNativeModule = function loadNativeModule(nativeName) {
|
|
const rebuilt = existsSync(process.env.ORCA_NATIVE_TEST_MARKER)
|
|
const dir = ${JSON.stringify(nativeDir)} ??
|
|
(rebuilt ? '../build/Release/' : '../prebuilds/' + process.platform + '-' + process.arch + '/')
|
|
appendFileSync(process.env.ORCA_NATIVE_TEST_LOG, \`node-pty load \${nativeName} dir=\${dir}\\n\`)
|
|
return {
|
|
dir,
|
|
module: {
|
|
listJobProcessIds: () => [],
|
|
terminateJob: () => true,
|
|
assignCurrentProcessToJob: () => true
|
|
}
|
|
}
|
|
}
|
|
`
|
|
)
|
|
writeFakeWindowsRegistry(projectDir)
|
|
}
|
|
|
|
function writeFakeWindowsRegistry(projectDir, { requiresMarker = false } = {}) {
|
|
if (process.platform !== 'win32') {
|
|
return
|
|
}
|
|
const registryDir = join(projectDir, 'node_modules', '@orca', 'windows-registry')
|
|
mkdirSync(registryDir, { recursive: true })
|
|
writeFileSync(
|
|
join(registryDir, 'package.json'),
|
|
'{"name":"@orca/windows-registry","version":"1.0.0","main":"index.js"}\n'
|
|
)
|
|
const markerGate = requiresMarker
|
|
? `if (!require('node:fs').existsSync(process.env.ORCA_NATIVE_TEST_MARKER)) { throw new Error('registry ABI mismatch sentinel') }`
|
|
: ''
|
|
writeFileSync(
|
|
join(registryDir, 'index.js'),
|
|
`exports.HK = { CU: 0x80000001 }; exports.getRegistryKey = () => { ${markerGate}; return {} }\n`
|
|
)
|
|
const processTreeDir = join(projectDir, 'node_modules', '@vscode', 'windows-process-tree')
|
|
mkdirSync(processTreeDir, { recursive: true })
|
|
writeFileSync(
|
|
join(processTreeDir, 'index.js'),
|
|
'exports.supportedProcessDataFlags = 4; exports.getProcessCreationTime = () => 1\n'
|
|
)
|
|
const securityDir = join(projectDir, 'node_modules', '@orca', 'windows-security')
|
|
mkdirSync(securityDir, { recursive: true })
|
|
writeFileSync(join(securityDir, 'index.js'), "exports.currentUserSid = () => 'S-1-5-18'\n")
|
|
}
|
|
|
|
function writeNodePtyPatchFile(projectDir) {
|
|
mkdirSync(join(projectDir, 'config', 'patches'), { recursive: true })
|
|
writeFileSync(join(projectDir, 'config', 'patches', 'node-pty@1.1.0.patch'), 'patch marker\n')
|
|
}
|
|
|
|
function writePatchedNodePtyBuildArtifacts(projectDir) {
|
|
const buildDir = join(projectDir, 'node_modules', 'node-pty', 'build', 'Release')
|
|
mkdirSync(buildDir, { recursive: true })
|
|
if (process.platform === 'win32') {
|
|
writeFileSync(join(buildDir, 'conpty.node'), '')
|
|
mkdirSync(join(buildDir, 'conpty'), { recursive: true })
|
|
writeFileSync(join(buildDir, 'conpty', 'conpty.dll'), '')
|
|
writeFileSync(join(buildDir, 'conpty', 'OpenConsole.exe'), '')
|
|
return
|
|
}
|
|
writeFileSync(join(buildDir, 'pty.node'), '')
|
|
if (process.platform === 'darwin') {
|
|
writeFileSync(join(buildDir, 'spawn-helper'), '')
|
|
}
|
|
}
|
|
|
|
function writeFakeNodeGyp(projectDir) {
|
|
const toolDir = join(projectDir, 'node_modules', 'node-gyp', 'bin')
|
|
mkdirSync(toolDir, { recursive: true })
|
|
writeFileSync(
|
|
join(toolDir, 'node-gyp.js'),
|
|
`
|
|
const { appendFileSync, writeFileSync, writeSync } = require('node:fs')
|
|
appendFileSync(process.env.ORCA_NATIVE_TEST_LOG, \`node-gyp \${process.argv.slice(2).join(' ')}\\n\`)
|
|
appendFileSync(process.env.ORCA_NATIVE_TEST_LOG, \`cwd=\${process.cwd()}\\n\`)
|
|
appendFileSync(process.env.ORCA_NATIVE_TEST_LOG, \`cxxflags=\${process.env.CXXFLAGS || ''}\\n\`)
|
|
appendFileSync(process.env.ORCA_NATIVE_TEST_LOG, \`trackFileAccess=\${process.env.TrackFileAccess ?? ''}\\n\`)
|
|
if (process.env.ORCA_NATIVE_TEST_VERBOSE_OUTPUT_BYTES) {
|
|
const output = Buffer.alloc(Number(process.env.ORCA_NATIVE_TEST_VERBOSE_OUTPUT_BYTES), 'x')
|
|
for (let offset = 0; offset < output.length;) {
|
|
offset += writeSync(1, output.subarray(offset))
|
|
}
|
|
writeSync(1, 'node-gyp stdout complete\\n')
|
|
writeSync(2, 'node-gyp stderr complete\\n')
|
|
}
|
|
writeFileSync(process.env.ORCA_NATIVE_TEST_MARKER, 'rebuilt')
|
|
`
|
|
)
|
|
}
|