mirror of
https://github.com/stablyai/orca.git
synced 2026-10-30 16:47:34 +00:00
Extract subprocess execution and process contracts into @orca/process-host with explicit public entry points, independent checks, and one Node 18 compatible CommonJS runtime. Migrate application consumers and integrate package builds, dependency selection, import enforcement, and runtime resource staging. Preserve daemon startup ownership and profile isolation, and qualify development rebuild recovery and concurrent output publication. Remove unnecessary aliases, test forwarding exports, and a duplicate output scan. Validation: full typechecks, changed-code quality, package and artifact checks, native Windows builds/types plus 306 runtime tests, and independent native reviews. Matched full E2E controls on original main and unchanged reviewed head both pass all 17 applicable tests (nine skips). Earlier intermittent E2E failures are documented in the PR; no assertions were weakened. The final combined-tree audit preserves both branches with no import-boundary violations.
179 lines
7.4 KiB
JavaScript
179 lines
7.4 KiB
JavaScript
import { mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { parse } from 'yaml'
|
|
import { describe, expect, it } from 'vitest'
|
|
import { classifyPrJobs } from './pr-code-change-scope.mjs'
|
|
import { runProcessSync } from '@orca/process-host'
|
|
|
|
const installerPath = '.github/actions/install-node-dependencies/action.yml'
|
|
const nativePath = '.github/actions/prepare-native-runtime/action.yml'
|
|
const installer = parse(readFileSync(installerPath, 'utf8'))
|
|
const native = parse(readFileSync(nativePath, 'utf8'))
|
|
const identity = native.runs.steps.find((step) => step.id === 'native-cache-scope')
|
|
const inputs = [...identity.env.NATIVE_SOURCE_HASH.matchAll(/'([^']+)'/g)].map((match) => match[1])
|
|
const paths = [
|
|
'node_modules/.pnpm/node-pty@*/node_modules/node-pty/build',
|
|
'native/windows-registry/build',
|
|
'node_modules/.pnpm/@vscode+windows-process-tre*/node_modules/@vscode/windows-process-tree/build'
|
|
]
|
|
|
|
function resolveIdentity({
|
|
runtime = 'node',
|
|
node = 'v24.21.0',
|
|
pnpm = '12.0.0',
|
|
os = 'Windows',
|
|
arch = 'X64',
|
|
image = 'win22',
|
|
libc = null,
|
|
sourceDigest = 'a'.repeat(64)
|
|
} = {}) {
|
|
const directory = mkdtempSync(join(tmpdir(), 'orca-native-identity-'))
|
|
try {
|
|
const output = join(directory, 'output')
|
|
const osRelease = join(directory, 'os-release')
|
|
if (libc) {
|
|
writeFileSync(osRelease, `ID=${libc.id}\nVERSION_ID=${libc.version}\n`)
|
|
}
|
|
// Isolate the container file lookup while running the production identity commands.
|
|
const script = `pnpm() { printf "%s\\n" "$TEST_PNPM_VERSION"; }\n${identity.run.replaceAll('/etc/os-release', '"$TEST_OS_RELEASE"')}`
|
|
const execution = runProcessSync({
|
|
program: 'bash',
|
|
args: ['-e', '-o', 'pipefail', '-c', script],
|
|
env: {
|
|
...process.env,
|
|
NATIVE_RUNTIME: runtime,
|
|
NODE_VERSION: node,
|
|
RUNNER_OS: os,
|
|
RUNNER_ARCH: arch,
|
|
ImageOS: image,
|
|
NATIVE_SOURCE_HASH: sourceDigest,
|
|
TEST_PNPM_VERSION: pnpm,
|
|
TEST_OS_RELEASE: osRelease,
|
|
GITHUB_OUTPUT: output
|
|
}
|
|
})
|
|
expect(execution.code, execution.stderr).toBe(0)
|
|
const result = readFileSync(output, 'utf8')
|
|
return {
|
|
key: /^key=(.+)$/m.exec(result)?.[1],
|
|
scope: /^scope=(.+)$/m.exec(result)?.[1],
|
|
path: /path<<ORCA_NATIVE_BUILD_DIRECTORIES\n([\s\S]+?)\nORCA_NATIVE_BUILD_DIRECTORIES/.exec(
|
|
result
|
|
)?.[1]
|
|
}
|
|
} finally {
|
|
rmSync(directory, { recursive: true, force: true })
|
|
}
|
|
}
|
|
|
|
describe('CI native cache ownership', () => {
|
|
it('routes every configured native cache input to native preparation', () => {
|
|
for (const file of inputs) {
|
|
expect(classifyPrJobs([file]).native_cache_changed, file).toBe(true)
|
|
}
|
|
})
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'separates runtime, Node/pnpm versions, architecture, image and libc hosts',
|
|
() => {
|
|
const baseline = resolveIdentity()
|
|
expect(baseline.path.split('\n')).toEqual(paths)
|
|
const variants = [
|
|
{ sourceDigest: 'b'.repeat(64) },
|
|
{ runtime: 'electron' },
|
|
{ node: 'v24.22.0' },
|
|
{ pnpm: '12.1.0' },
|
|
{ arch: 'ARM64' },
|
|
{ image: 'win11' },
|
|
{ os: 'Linux', image: 'ubuntu22', libc: { id: 'ubuntu', version: '22.04' } },
|
|
{ os: 'Linux', image: 'ubuntu22', libc: { id: 'almalinux', version: '8.10' } }
|
|
].map(resolveIdentity)
|
|
expect(new Set([baseline, ...variants].map(({ key }) => key)).size).toBe(variants.length + 1)
|
|
expect(variants.at(-1).scope).toBe('almalinux-8.10')
|
|
expect(variants.every(({ path }) => path === baseline.path)).toBe(true)
|
|
}
|
|
)
|
|
|
|
it('keeps early input rejection before dependency installation and native restoration', () => {
|
|
const early = installer.runs.steps.findIndex((step) => step.name === 'Validate native runtime')
|
|
const install = installer.runs.steps.findIndex((step) => step.name === 'Install dependencies')
|
|
const prepare = installer.runs.steps.findIndex((step) => step.id === 'native-runtime')
|
|
expect(early).toBeLessThan(install)
|
|
expect(install).toBeLessThan(prepare)
|
|
expect(installer.runs.steps[early].run).toContain('none|node|electron)')
|
|
expect(installer.runs.steps[prepare].if).toBe("inputs.native-runtime != 'none'")
|
|
})
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'rejects invalid runtime and missing resolved Node before cache restoration',
|
|
() => {
|
|
const early = installer.runs.steps.find((step) => step.name === 'Validate native runtime')
|
|
const validate = native.runs.steps.find((step) => step.name === 'Validate native runtime')
|
|
for (const run of [early.run, validate.run]) {
|
|
expect(
|
|
runProcessSync({
|
|
program: 'bash',
|
|
args: ['-e', '-c', run],
|
|
env: { ...process.env, NATIVE_RUNTIME: 'unsupported', NODE_VERSION: 'v24.21.0' },
|
|
stdio: 'pipe'
|
|
}).code
|
|
).not.toBe(0)
|
|
}
|
|
expect(
|
|
runProcessSync({
|
|
program: 'bash',
|
|
args: ['-e', '-c', validate.run],
|
|
env: { ...process.env, NATIVE_RUNTIME: 'node', NODE_VERSION: '' },
|
|
stdio: 'pipe'
|
|
}).code
|
|
).not.toBe(0)
|
|
}
|
|
)
|
|
|
|
it('uses requested identity on both restores and saves the Node ABI before Windows switches to Electron', () => {
|
|
for (const step of native.runs.steps.filter((step) => step.uses?.startsWith('actions/cache'))) {
|
|
expect(step.with.key).toBe('${{ steps.native-cache-scope.outputs.key }}')
|
|
expect(step.with.path.trim().split('\n')).toEqual(paths)
|
|
expect(step.with['restore-keys']).toBeUndefined()
|
|
}
|
|
const job = parse(readFileSync('.github/workflows/pr.yml', 'utf8')).jobs.package_windows
|
|
const save = job.steps.find((step) => step.name === 'Save compiled Node native modules')
|
|
const install = job.steps.find((step) => step.id === 'deps')
|
|
const build = job.steps.find((step) => step.name === 'Build package inputs')
|
|
const electron = job.steps.find((step) => step.name === 'Prepare Electron native runtime')
|
|
expect(install.with['persist-native-cache']).toBe('false')
|
|
expect(save.with).toEqual({
|
|
key: '${{ steps.deps.outputs.native-cache-key }}',
|
|
path: '${{ steps.deps.outputs.native-cache-path }}'
|
|
})
|
|
expect(job.steps.indexOf(save)).toBeLessThan(job.steps.indexOf(build))
|
|
expect(job.steps.indexOf(build)).toBeLessThan(job.steps.indexOf(electron))
|
|
expect(electron.uses).toBe('./.github/actions/prepare-native-runtime')
|
|
expect(electron.with).toEqual({
|
|
'native-runtime': 'electron',
|
|
'node-version': '${{ steps.deps.outputs.node-version }}'
|
|
})
|
|
expect(native.outputs['cache-key'].value).toBe('${{ steps.native-cache-scope.outputs.key }}')
|
|
})
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'keeps cache post-job paths when the nested step output context is absent',
|
|
() => {
|
|
const postContext = { steps: {} }
|
|
const evaluateInput = (value) =>
|
|
value.replace(
|
|
/\$\{\{\s*steps\.([\w-]+)\.outputs\.([\w-]+)\s*\}\}/g,
|
|
(_expression, step, output) => postContext.steps[step]?.outputs?.[output] ?? ''
|
|
)
|
|
expect(evaluateInput('${{ steps.native-cache-scope.outputs.path }}')).toBe('')
|
|
const emitted = resolveIdentity().path
|
|
for (const step of native.runs.steps.filter((step) =>
|
|
step.uses?.startsWith('actions/cache')
|
|
)) {
|
|
expect(evaluateInput(step.with.path).trim()).toBe(emitted)
|
|
}
|
|
}
|
|
)
|
|
})
|