mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 08:02:28 +00:00
* fix(github): load PR diffs for Enterprise remotes * fix(github): encode PR content paths by segment * Fix PR review actions failing on GitHub Enterprise remotes - Threads GitHub host identity (not just owner/repo) through the client, work-item-details, issues, and RPC layers so gh commands target the correct Enterprise server instead of silently falling back to github.com - Adds a shared github-api-repository helper to resolve/host-qualify repo identity consistently across REST, GraphQL, and CLI shorthand calls - Scopes the gh rate-limit breaker and singleton rate-limit snapshot by host/runtime so a github.com block or probe can't affect GHES or WSL - Coalesces concurrent host-auth probes and paginates PR file fetching beyond 100 results - Propagates `host` through renderer PR caches, checks-panel keys, and preload IPC types so Enterprise and github.com data never collide * Route gh host qualification through runner options instead of argv sniff Move GHES/GH_HOST resolution from parsing --hostname/--repo out of gh argv to an explicit options.host passed through ghExecFileAsync, since SSH-backed repos spawn gh with no cwd and argv sniffing couldn't reliably detect the target host. The runner now injects --hostname and qualifies --repo/-R at spawn time from options.host, and rate-limit scoping/guards use the same explicit host instead of inferring it. Also adds a shared githubRepoIdentityKey helper to keep cache/store keys consistent with the new host-aware repository identity. * Fix gh CLI GHES host pinning and rate-limit scope leaks - Pin `--host` on every gh call site so a process-level GH_HOST can't silently redirect requests, and qualify `-R`/`-R=` repo shorthand alongside the existing `--repo=` handling. - Check the target scope for an active rate-limit block before each WSL/native or host fallback retry, not just on the initial attempt, so a blocked scope can't be hit again through a fallback path. - Compute idempotency once per call instead of re-deriving it after fallback reassigns args. * Fix GitHub Enterprise host identity loss across PR/work-item paths - Thread `host` through mobile PR RPC params, IPC work-item lookups, and RPC schemas so GHES identity survives the renderer/mobile/main boundary instead of silently falling back to a same-named github.com repo. - Qualify `--repo`/`-R` args for github.com too (not just GHES), since gh resolves bare shorthand against a process-level GH_HOST that can redirect pinned github.com commands. - Cache `getOriginGitHubApiRepository` to avoid a per-call uncached `git remote get-url` round trip on connection-backed repos. - Add a local-fork fallback in `getWorkItemDetails` so PRs living on a base repo (not visible via the origin slug) still resolve via cwd. - Centralize the github.com-vs-GHES host predicate in `isDefaultGitHubHost` so cache keys, quota scoping, and identity checks can't drift out of sync. * Make repository identity host-aware across all GitHub surfaces Generalize the auth-gated enterprise resolver to any remote and build a cached hosted-identity family (origin/issue/candidates/source) on top of it, then migrate every github.com-only consumer: Tasks listing/counting, branch-to-PR discovery, push targets, fork upstream, issue operations, Projects, web links, avatars, and PR-link facts. Scope the rate-limit breaker probe per runtime:host and classify WSL UNC cwds correctly. Co-authored-by: Orca <help@stably.ai> * Fix expected slug to include host field in GitHub PR link test Updates the smart-source paste-intent test fixture to match the repository slug shape that now carries a `host` field, keeping GHES host identity intact through the paste-intent parsing path. * Surface per-host gh auth state for GitHub Enterprise diagnoseGhAuth accepts the host a surface needs credentials for, scopes the account/scope diagnosis to that host, and reports whether gh has any login there; GhAuthErrorHelp renders host-qualified login/refresh commands so an unauthenticated GHES host stops masquerading as a github.com scope problem. Also fixes the mobile paste-intent expectation for host-carrying parsed links. Co-authored-by: Orca <help@stably.ai> * Bound GHES identity caches and preserve non-default ports in host identity Cap the origin-repo and host-auth caches like ownerRepoCache; keep ports from remote/link URLs so GHES on a non-default port is a distinct identity; make positional github.com slugs explicit against GH_HOST; compare work-item sources by host-aware identity key; bail cwd-less branch lookups when no repository candidate resolved; thread host through the renderer work-item slug lookup. Co-authored-by: Orca <help@stably.ai> * Thread GitHub host through issue detail requests Incorporates ghes-issue-host-support (ed6bb96ef): one hosted issue repository identity is resolved before the details fan-out so comments, timeline, participants, and mention lookups cannot drift across hosts, with SSH guards so unresolved issue/PR repositories never fall through to gh's default host. Co-authored-by: Orca <help@stably.ai> * Scope remaining GitHub rate-limit accounting * Resolve typed PR lookups across hosted repository candidates getWorkItem's PR path probes upstream-then-origin hosted candidates instead of origin alone, so fork checkouts resolve the base repo's PR with the right host; issue detail resolution reuses the up-front hosted identity and keeps the SSH unresolved-host guards. Co-authored-by: Orca <help@stably.ai> * Refactor GitHub repository execution setup * Carry host on smart-submit link intents Co-authored-by: Orca <help@stably.ai> * Carry the project host on GitHub item dialog origins Co-authored-by: Orca <help@stably.ai> * Keep GHES web ports but drop SSH transport ports in host identity Supersedes PR #9118 on this branch: http(s) remote ports identify the Enterprise web/API endpoint and are preserved, while ssh/git transport ports (including ssh.github.com:443) never leak into gh's host identity. Replaces the ssh.github.com:443 special case with the structural protocol split and ports the PR's parsing test suite. Co-authored-by: Orca <help@stably.ai> * Support GitHub Enterprise diffs and mutations with host-scoped caches Parse GitHub host identity from work-item URLs and carry it through PR/issue mutations, labels, and assignments. Bound rate-limit and scope-probe caches (1024 and 512 entries) to prevent unbounded growth when interacting with multiple GHES instances. Normalize repository identity keys to include host so github.com and GHES slugs don't collide in cache and equality checks. * Support GitHub Enterprise diffs and mutations with host-scoped caches - Carry host identity through PR mutations and reads so fork PRs on different GHES instances don't collide in cache or state tracking. - Validate host authentication before routing requests to unconfigured Enterprise servers; ambient credentials must never reach untrusted hosts. - Scope rate-limit guards and spend tracking per host so GHES quota stays independent from github.com quota. - Respect explicit --hostname arguments in gh CLI calls ahead of GH_HOST or ambient defaults, so breaker state follows the actual request target. - Detect implicit WSL runtimes from UNC paths for consistent host auth and execution-options scoping across mobile and desktop clients. * Support GitHub Enterprise work-item diffs with host-scoped execution Enterprise PRs must use their selected host consistently across diff, comments, and file-content loads. Validate repository slugs before authenticated execution to prevent path-injection via renderer overrides. Scope project browsing cache and rate-limit tracking by host to prevent cross-host pollution. Use parsed URLs as authoritative over ambient hosts for project resolution. * Support GitHub Enterprise work-item diffs with host-scoped execution Preserve host identity on PR/issue work items throughout the mutation and diff pipeline so Enterprise instances (including ported endpoints like github.acme.test:8443) can execute mutations without ambiguity. Rate-limit gh commands by the pre-qualified --repo host, cache auth state per ported host, and surface Enterprise hosts in project metadata and error messages. * fix(review): drop dead rateLimitGuard/noteRateLimitSpend re-export Both callers (project-view.ts, mutations.ts) moved to the host-scoped repositoryRateLimitGuard/noteRepositoryRateLimitSpend; the bucket-only re-export in internals.ts had zero importers left. Co-authored-by: Orca <help@stably.ai> * fix(ci): split Enterprise host work-item tests under max-lines Move GHES/SSH host-routing cases out of work-item-details.test.ts so the suite stays within the 800-line test max-lines budget. * test(github): align mocks with host-scoped repository resolution - Route origin repository resolution through getOwnerRepoForRemote, not getOwnerRepo, to match production path - Pin github.com host on origin results so host-less fixtures pass host gate in resolveGitHubApiRepository - Add generation-based invalidation to prevent stale slug-cache writes from in-flight resolutions - Fix ref-sync race in ProjectPicker: use useLayoutEffect so committed tree owns browse cache key - Defer handledCrossRepoUrlRef assignment in SmartWorkspaceNameField until resolution succeeds - Update Enterprise host routing: found work items must not silently fall back to default host when unresolved - Normalize GHES avatar URLs: accept explicit port 443 as canonical form, not a fallback trigger --------- Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Co-authored-by: Orca <help@stably.ai>
200 lines
6.3 KiB
TypeScript
200 lines
6.3 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest'
|
|
import type { RpcResponse } from '../transport/types'
|
|
import {
|
|
fetchAddIssueComment,
|
|
fetchAddPRReviewCommentReply,
|
|
fetchDeleteIssueComment,
|
|
fetchMergePR,
|
|
fetchResolveReviewThread,
|
|
fetchUpdateIssueComment,
|
|
fetchUpdatePRTitle
|
|
} from './github-pr-mutations'
|
|
|
|
function okResponse(result: unknown): RpcResponse {
|
|
return { id: 'x', ok: true, result, _meta: { runtimeId: 'r' } }
|
|
}
|
|
|
|
function errResponse(message: string): RpcResponse {
|
|
return { id: 'x', ok: false, error: { code: 'failed', message }, _meta: { runtimeId: 'r' } }
|
|
}
|
|
|
|
function clientReturning(response: RpcResponse) {
|
|
return { sendRequest: vi.fn(async () => response) }
|
|
}
|
|
|
|
function clientRejecting(message: string) {
|
|
return {
|
|
sendRequest: vi.fn(async () => {
|
|
throw new Error(message)
|
|
})
|
|
}
|
|
}
|
|
|
|
const WORKTREE_ID = 'repo-42::/path/to/wt'
|
|
const ENTERPRISE_PR_REPO = { owner: 'o', repo: 'r', host: 'github.acme.test' }
|
|
|
|
describe('fetchResolveReviewThread / fetchUpdatePRTitle — bare-boolean host result', () => {
|
|
it('treats an explicit true as success', async () => {
|
|
const resolve = await fetchResolveReviewThread(clientReturning(okResponse(true)), WORKTREE_ID, {
|
|
threadId: 't',
|
|
resolve: true
|
|
})
|
|
expect(resolve).toEqual({ ok: true })
|
|
const title = await fetchUpdatePRTitle(clientReturning(okResponse(true)), WORKTREE_ID, {
|
|
prNumber: 1,
|
|
title: 'New'
|
|
})
|
|
expect(title).toEqual({ ok: true })
|
|
})
|
|
|
|
it('treats a missing/undefined result as failure (not success)', async () => {
|
|
const resolve = await fetchResolveReviewThread(
|
|
clientReturning(okResponse(undefined)),
|
|
WORKTREE_ID,
|
|
{ threadId: 't', resolve: true }
|
|
)
|
|
expect(resolve.ok).toBe(false)
|
|
const title = await fetchUpdatePRTitle(clientReturning(okResponse(undefined)), WORKTREE_ID, {
|
|
prNumber: 1,
|
|
title: 'New'
|
|
})
|
|
expect(title.ok).toBe(false)
|
|
})
|
|
|
|
it('treats false as failure', async () => {
|
|
const resolve = await fetchResolveReviewThread(
|
|
clientReturning(okResponse(false)),
|
|
WORKTREE_ID,
|
|
{
|
|
threadId: 't',
|
|
resolve: false
|
|
}
|
|
)
|
|
expect(resolve.ok).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('mutation transport rejection normalization', () => {
|
|
it('normalizes a thrown sendRequest into { ok:false, error } (envelope mutations)', async () => {
|
|
const out = await fetchMergePR(clientRejecting('socket hung up'), WORKTREE_ID, { prNumber: 1 })
|
|
expect(out).toEqual({ ok: false, error: 'socket hung up' })
|
|
})
|
|
|
|
it('normalizes a thrown sendRequest for bare-boolean mutations', async () => {
|
|
const resolve = await fetchResolveReviewThread(
|
|
clientRejecting('connection dropped'),
|
|
WORKTREE_ID,
|
|
{
|
|
threadId: 't',
|
|
resolve: true
|
|
}
|
|
)
|
|
expect(resolve).toEqual({ ok: false, error: 'connection dropped' })
|
|
const title = await fetchUpdatePRTitle(clientRejecting('connection dropped'), WORKTREE_ID, {
|
|
prNumber: 1,
|
|
title: 'New'
|
|
})
|
|
expect(title).toEqual({ ok: false, error: 'connection dropped' })
|
|
})
|
|
|
|
it('surfaces a transport error message on a failed response', async () => {
|
|
const out = await fetchMergePR(clientReturning(errResponse('permission denied')), WORKTREE_ID, {
|
|
prNumber: 1
|
|
})
|
|
expect(out).toEqual({ ok: false, error: 'permission denied' })
|
|
})
|
|
})
|
|
|
|
describe('Enterprise PR repo forwarding', () => {
|
|
it('forwards the host through title, root-comment, and review-reply RPCs', async () => {
|
|
const titleClient = clientReturning(okResponse(true))
|
|
await fetchUpdatePRTitle(titleClient, WORKTREE_ID, {
|
|
prNumber: 7,
|
|
title: 'New title',
|
|
prRepo: ENTERPRISE_PR_REPO
|
|
})
|
|
expect(titleClient.sendRequest).toHaveBeenCalledWith(
|
|
'github.updatePRTitle',
|
|
expect.objectContaining({ prRepo: ENTERPRISE_PR_REPO })
|
|
)
|
|
|
|
const rootClient = clientReturning(okResponse({ ok: true }))
|
|
await fetchAddIssueComment(rootClient, WORKTREE_ID, {
|
|
prNumber: 7,
|
|
body: 'Root comment',
|
|
prRepo: ENTERPRISE_PR_REPO
|
|
})
|
|
expect(rootClient.sendRequest).toHaveBeenCalledWith(
|
|
'github.addIssueComment',
|
|
expect.objectContaining({ prRepo: ENTERPRISE_PR_REPO })
|
|
)
|
|
|
|
const replyClient = clientReturning(okResponse({ ok: true }))
|
|
await fetchAddPRReviewCommentReply(replyClient, WORKTREE_ID, {
|
|
prNumber: 7,
|
|
commentId: 42,
|
|
body: 'Reply',
|
|
prRepo: ENTERPRISE_PR_REPO
|
|
})
|
|
expect(replyClient.sendRequest).toHaveBeenCalledWith(
|
|
'github.addPRReviewCommentReply',
|
|
expect.objectContaining({ prRepo: ENTERPRISE_PR_REPO })
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('fetchUpdateIssueComment / fetchDeleteIssueComment — slug-addressed envelope', () => {
|
|
it('sends owner/repo/commentId(+body) and reads the { ok } envelope', async () => {
|
|
const editClient = clientReturning(okResponse({ ok: true }))
|
|
const edit = await fetchUpdateIssueComment(editClient, {
|
|
owner: 'o',
|
|
repo: 'r',
|
|
host: 'github.acme.test',
|
|
commentId: 5,
|
|
body: 'edited'
|
|
})
|
|
expect(edit).toEqual({ ok: true })
|
|
expect(editClient.sendRequest).toHaveBeenCalledWith('github.project.updateIssueCommentBySlug', {
|
|
owner: 'o',
|
|
repo: 'r',
|
|
host: 'github.acme.test',
|
|
commentId: 5,
|
|
body: 'edited'
|
|
})
|
|
|
|
const delClient = clientReturning(okResponse({ ok: true }))
|
|
const del = await fetchDeleteIssueComment(delClient, {
|
|
owner: 'o',
|
|
repo: 'r',
|
|
host: 'github.acme.test',
|
|
commentId: 5
|
|
})
|
|
expect(del).toEqual({ ok: true })
|
|
expect(delClient.sendRequest).toHaveBeenCalledWith('github.project.deleteIssueCommentBySlug', {
|
|
owner: 'o',
|
|
repo: 'r',
|
|
host: 'github.acme.test',
|
|
commentId: 5
|
|
})
|
|
})
|
|
|
|
it('surfaces a host object error { type, message } as failure', async () => {
|
|
const out = await fetchUpdateIssueComment(
|
|
clientReturning(
|
|
okResponse({ ok: false, error: { type: 'permission', message: 'not authorized' } })
|
|
),
|
|
{ owner: 'o', repo: 'r', commentId: 5, body: 'x' }
|
|
)
|
|
expect(out).toEqual({ ok: false, error: 'not authorized' })
|
|
})
|
|
|
|
it('normalizes a transport rejection', async () => {
|
|
const out = await fetchDeleteIssueComment(clientRejecting('offline'), {
|
|
owner: 'o',
|
|
repo: 'r',
|
|
commentId: 5
|
|
})
|
|
expect(out).toEqual({ ok: false, error: 'offline' })
|
|
})
|
|
})
|