mirror of
https://github.com/stablyai/orca.git
synced 2026-10-21 00:03:46 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
66 lines
2.0 KiB
TypeScript
66 lines
2.0 KiB
TypeScript
import { readFile, stat } from 'node:fs/promises'
|
|
import type { Repo } from '../../shared/types'
|
|
import {
|
|
getRuntimePathBasename,
|
|
normalizeRuntimePathSeparators,
|
|
resolveRuntimePath
|
|
} from '../../shared/cross-platform-path'
|
|
import type { FileStat } from '../providers/types'
|
|
|
|
type GitDirectoryStat = Awaited<ReturnType<typeof stat>> | FileStat
|
|
|
|
type GitDirectoryAccess = {
|
|
stat?: (path: string) => Promise<GitDirectoryStat>
|
|
readFile?: (path: string) => Promise<string>
|
|
}
|
|
|
|
function isDirectoryStat(value: GitDirectoryStat): boolean {
|
|
return 'type' in value ? value.type === 'directory' : value.isDirectory()
|
|
}
|
|
|
|
function isFileStat(value: GitDirectoryStat): boolean {
|
|
return 'type' in value ? value.type === 'file' : value.isFile()
|
|
}
|
|
|
|
function runtimeDirname(pathValue: string): string {
|
|
const normalized = normalizeRuntimePathSeparators(pathValue).replace(/\/+$/, '')
|
|
const index = normalized.lastIndexOf('/')
|
|
if (index < 0) {
|
|
return '.'
|
|
}
|
|
if (index === 0) {
|
|
return '/'
|
|
}
|
|
return normalized.slice(0, index)
|
|
}
|
|
|
|
export async function resolveWorktreeCommonGitDirectory(
|
|
repo: Repo,
|
|
access: GitDirectoryAccess = {}
|
|
): Promise<string | null> {
|
|
const dotGitPath = resolveRuntimePath(repo.path, '.git')
|
|
const statPath = access.stat ?? stat
|
|
const readText = access.readFile ?? ((path: string) => readFile(path, 'utf8'))
|
|
try {
|
|
const dotGitStat = await statPath(dotGitPath)
|
|
if (isDirectoryStat(dotGitStat)) {
|
|
return dotGitPath
|
|
}
|
|
if (!isFileStat(dotGitStat)) {
|
|
return null
|
|
}
|
|
const content = await readText(dotGitPath)
|
|
const gitDir = content.match(/^gitdir:\s*(.+)\s*$/m)?.[1]?.trim()
|
|
if (!gitDir) {
|
|
return null
|
|
}
|
|
const resolvedGitDir = resolveRuntimePath(repo.path, gitDir)
|
|
return getRuntimePathBasename(runtimeDirname(resolvedGitDir)) === 'worktrees'
|
|
? runtimeDirname(runtimeDirname(resolvedGitDir))
|
|
: resolvedGitDir
|
|
} catch (error) {
|
|
console.warn(`[worktree-base-watcher] cannot resolve git common dir for ${repo.id}:`, error)
|
|
return null
|
|
}
|
|
}
|