mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 00:02:31 +00:00
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
200 lines
6.2 KiB
TypeScript
200 lines
6.2 KiB
TypeScript
import { useEffect, useRef, useState } from 'react'
|
|
import { View, Text, Pressable, StyleSheet } from 'react-native'
|
|
import * as Clipboard from 'expo-clipboard'
|
|
import { Check, Copy, Pencil, Play, Trash2 } from 'lucide-react-native'
|
|
import { colors, spacing, typography } from '../theme/mobile-theme'
|
|
import { MobileAgentIcon } from '../components/MobileAgentIcon'
|
|
import type { TerminalQuickCommand } from '../../../src/shared/terminal-quick-command-types'
|
|
import {
|
|
getQuickCommandDisplayPreview,
|
|
getTerminalQuickCommandBody,
|
|
isAgentQuickCommand
|
|
} from '../terminal/quick-commands'
|
|
|
|
type QuickCommandRowProps = {
|
|
command: TerminalQuickCommand
|
|
first: boolean
|
|
onLaunch: (command: TerminalQuickCommand) => void
|
|
onEdit: (command: TerminalQuickCommand) => void
|
|
onDelete: (command: TerminalQuickCommand) => void
|
|
disabled: boolean
|
|
}
|
|
|
|
type CopyFeedback = {
|
|
body: string
|
|
status: 'copied' | 'failed'
|
|
}
|
|
|
|
export function QuickCommandRow({
|
|
command,
|
|
first,
|
|
onLaunch,
|
|
onEdit,
|
|
onDelete,
|
|
disabled
|
|
}: QuickCommandRowProps) {
|
|
const isAgent = isAgentQuickCommand(command)
|
|
const body = getTerminalQuickCommandBody(command)
|
|
const canCopy = body.trim().length > 0
|
|
// Why: key feedback to the copied body so a prop change drops stale labels
|
|
// without setState-in-effect (react-doctor no-adjust-state-on-prop-change).
|
|
const [feedback, setFeedback] = useState<CopyFeedback | null>(null)
|
|
const copyResetTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null)
|
|
const mountedRef = useRef(true)
|
|
const copyStatus: 'idle' | 'copied' | 'failed' =
|
|
feedback != null && feedback.body === body ? feedback.status : 'idle'
|
|
|
|
useEffect(() => {
|
|
mountedRef.current = true
|
|
return () => {
|
|
mountedRef.current = false
|
|
if (copyResetTimerRef.current) {
|
|
clearTimeout(copyResetTimerRef.current)
|
|
}
|
|
}
|
|
}, [])
|
|
|
|
// Drop any pending reset timer when the body changes; display status is already idle.
|
|
useEffect(() => {
|
|
if (copyResetTimerRef.current) {
|
|
clearTimeout(copyResetTimerRef.current)
|
|
copyResetTimerRef.current = null
|
|
}
|
|
}, [body])
|
|
|
|
const handleCopy = async (): Promise<void> => {
|
|
if (!canCopy || disabled) {
|
|
return
|
|
}
|
|
try {
|
|
await Clipboard.setStringAsync(body)
|
|
if (!mountedRef.current) {
|
|
return
|
|
}
|
|
setFeedback({ body, status: 'copied' })
|
|
} catch {
|
|
if (!mountedRef.current) {
|
|
return
|
|
}
|
|
setFeedback({ body, status: 'failed' })
|
|
}
|
|
if (copyResetTimerRef.current) {
|
|
clearTimeout(copyResetTimerRef.current)
|
|
}
|
|
copyResetTimerRef.current = setTimeout(() => {
|
|
copyResetTimerRef.current = null
|
|
if (mountedRef.current) {
|
|
setFeedback(null)
|
|
}
|
|
}, 1500)
|
|
}
|
|
|
|
const copyDisabled = disabled || !canCopy
|
|
const copyLabel =
|
|
copyStatus === 'copied'
|
|
? 'Copied'
|
|
: copyStatus === 'failed'
|
|
? "Couldn't copy"
|
|
: canCopy
|
|
? `Copy ${command.label}`
|
|
: 'Nothing to copy'
|
|
const copyIconColor =
|
|
copyStatus === 'copied'
|
|
? colors.statusGreen
|
|
: copyStatus === 'failed'
|
|
? colors.statusRed
|
|
: colors.textSecondary
|
|
|
|
return (
|
|
<View style={[styles.row, !first && styles.rowBorder, disabled && styles.disabled]}>
|
|
<Pressable
|
|
style={({ pressed }) => [styles.rowMain, pressed && !disabled && styles.pressed]}
|
|
disabled={disabled}
|
|
onPress={() => onLaunch(command)}
|
|
accessibilityRole="button"
|
|
accessibilityLabel={`Run ${command.label}`}
|
|
>
|
|
<View style={styles.rowIcon}>
|
|
{isAgent ? (
|
|
<MobileAgentIcon agentId={command.agent} size={16} />
|
|
) : (
|
|
<Play size={14} color={colors.textPrimary} fill={colors.textPrimary} />
|
|
)}
|
|
</View>
|
|
<View style={styles.rowText}>
|
|
<Text style={styles.rowLabel} numberOfLines={1}>
|
|
{command.label}
|
|
</Text>
|
|
<Text style={[styles.rowPreview, !isAgent && styles.mono]} numberOfLines={1}>
|
|
{getQuickCommandDisplayPreview(command)}
|
|
</Text>
|
|
</View>
|
|
</Pressable>
|
|
<Pressable
|
|
style={({ pressed }) => [
|
|
styles.rowAction,
|
|
// Why: row already dims when `disabled`; only dim again for empty body.
|
|
!canCopy && styles.disabled,
|
|
pressed && !copyDisabled && styles.pressed
|
|
]}
|
|
disabled={copyDisabled}
|
|
onPress={() => void handleCopy()}
|
|
accessibilityRole="button"
|
|
accessibilityLabel={copyLabel}
|
|
accessibilityState={{ disabled: copyDisabled }}
|
|
>
|
|
{copyStatus === 'copied' ? (
|
|
<Check size={15} color={copyIconColor} />
|
|
) : (
|
|
<Copy size={15} color={copyIconColor} />
|
|
)}
|
|
</Pressable>
|
|
<Pressable
|
|
style={({ pressed }) => [styles.rowAction, pressed && !disabled && styles.pressed]}
|
|
disabled={disabled}
|
|
onPress={() => onEdit(command)}
|
|
accessibilityLabel={`Edit ${command.label}`}
|
|
>
|
|
<Pencil size={15} color={colors.textSecondary} />
|
|
</Pressable>
|
|
<Pressable
|
|
style={({ pressed }) => [styles.rowAction, pressed && !disabled && styles.pressed]}
|
|
disabled={disabled}
|
|
onPress={() => onDelete(command)}
|
|
accessibilityLabel={`Delete ${command.label}`}
|
|
>
|
|
<Trash2 size={15} color={colors.statusRed} />
|
|
</Pressable>
|
|
</View>
|
|
)
|
|
}
|
|
|
|
const styles = StyleSheet.create({
|
|
pressed: { backgroundColor: colors.bgRaised },
|
|
disabled: { opacity: 0.45 },
|
|
row: { flexDirection: 'row', alignItems: 'center' },
|
|
rowBorder: { borderTopWidth: StyleSheet.hairlineWidth, borderTopColor: colors.borderSubtle },
|
|
rowMain: {
|
|
flex: 1,
|
|
flexDirection: 'row',
|
|
alignItems: 'center',
|
|
gap: spacing.md,
|
|
paddingVertical: spacing.md,
|
|
paddingLeft: spacing.md,
|
|
minWidth: 0
|
|
},
|
|
rowIcon: {
|
|
width: 26,
|
|
height: 26,
|
|
borderRadius: 6,
|
|
backgroundColor: colors.bgRaised,
|
|
alignItems: 'center',
|
|
justifyContent: 'center'
|
|
},
|
|
rowText: { flex: 1, minWidth: 0 },
|
|
rowLabel: { fontSize: 14, fontWeight: '600', color: colors.textPrimary },
|
|
rowPreview: { fontSize: 12, color: colors.textSecondary, marginTop: 1 },
|
|
mono: { fontFamily: typography.monoFamily },
|
|
rowAction: { width: 40, height: 44, alignItems: 'center', justifyContent: 'center' }
|
|
})
|