mirror of
https://github.com/stablyai/orca.git
synced 2026-10-20 16:03:20 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
81 lines
2.2 KiB
TypeScript
81 lines
2.2 KiB
TypeScript
import { statSync } from 'node:fs'
|
|
import { safeStorage } from 'electron'
|
|
import {
|
|
credentialDecryptionMessage,
|
|
type IntegrationCredentialService
|
|
} from '../shared/integration-credential-errors'
|
|
|
|
// Why: connection status treats a token file as a saved credential; empty
|
|
// files read as "missing", so counting them would split-brain getStatus.
|
|
export function credentialFileHasContent(path: string): boolean {
|
|
try {
|
|
return statSync(path).size > 0
|
|
} catch {
|
|
return false
|
|
}
|
|
}
|
|
|
|
export class CredentialDecryptionError extends Error {
|
|
constructor(service: IntegrationCredentialService) {
|
|
super(credentialDecryptionMessage(service))
|
|
this.name = 'CredentialDecryptionError'
|
|
}
|
|
}
|
|
|
|
// Returns the stored token, null when the file is empty, and throws
|
|
// CredentialDecryptionError when the file holds ciphertext we cannot decrypt
|
|
// (e.g. the user denied the OS keychain prompt after an app re-sign).
|
|
export function readStoredCredentialToken(
|
|
service: IntegrationCredentialService,
|
|
raw: Buffer
|
|
): string | null {
|
|
if (raw.length === 0) {
|
|
return null
|
|
}
|
|
|
|
if (safeStorage.isEncryptionAvailable()) {
|
|
try {
|
|
return usableToken(safeStorage.decryptString(raw))
|
|
} catch {
|
|
return readPlaintextLegacyCredential(service, raw)
|
|
}
|
|
}
|
|
|
|
return readPlaintextLegacyCredential(service, raw)
|
|
}
|
|
|
|
function readPlaintextLegacyCredential(
|
|
service: IntegrationCredentialService,
|
|
raw: Buffer
|
|
): string | null {
|
|
const plaintext = decodeUtf8(raw)
|
|
// Why: legacy plaintext tokens are printable UTF-8; safeStorage ciphertext
|
|
// such as macOS v10 blobs must not be decoded into auth-header junk.
|
|
if (plaintext === null || hasControlCharacter(plaintext)) {
|
|
throw new CredentialDecryptionError(service)
|
|
}
|
|
return usableToken(plaintext)
|
|
}
|
|
|
|
function usableToken(token: string): string | null {
|
|
return token.length > 0 ? token : null
|
|
}
|
|
|
|
function decodeUtf8(raw: Buffer): string | null {
|
|
try {
|
|
return new TextDecoder('utf-8', { fatal: true }).decode(raw)
|
|
} catch {
|
|
return null
|
|
}
|
|
}
|
|
|
|
function hasControlCharacter(value: string): boolean {
|
|
for (let index = 0; index < value.length; index += 1) {
|
|
const code = value.charCodeAt(index)
|
|
if (code < 0x20 || code === 0x7f) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|