mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 08:03:13 +00:00
* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket Unify mobile workspace creation with desktop. The "+" Create Workspace modal now has a primary "Start from" field that opens a tabbed search drawer (Branch · GitHub · GitLab · Linear), letting a user start a workspace from an existing/new git branch, a GitHub issue/PR, a GitLab issue/MR, or a Linear ticket — in addition to the default blank workspace. No new backend is required: the search RPCs (github.listWorkItems, gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and the worktree.create linked-item params were already used by the mobile Tasks screen. This surfaces them in the create flow, reusing the existing pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint, filterAvailableTaskProviders). Details: - New pure modules: workspace-source-selection, use-workspace-source-search, source-workspace-create, worktree-create-retry, blank-workspace-create (the blank/retry path extracted from the modal for reuse + line budget). - New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer (extracted from the modal). - Older paired desktops (missing the mobile.tasks.v1 capability) degrade to Branch + Blank only; GitLab/Linear tabs appear only when available. - GitHub/GitLab sources pin their repo; switching repos resets the source. PR/MR sources resolve their base branch at create time; SSH repos gate search until connected (Linear search is repo/SSH-independent). * fix(mobile): hydrate settings/trust before availability probes settle Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer wait on status.get/preflight.check/linear.status (a first-open preflight.check can take seconds, widening the spurious setup-trust re-prompt window). Also adds param-parity tests for createBlankWorkspace and a GitLab MR base-resolve test. * feat(mobile): match desktop's Smart source picker exactly Rework the mobile create-workspace source picker to be a faithful port of desktop's Smart picker instead of the earlier divergent "Start from" drawer. The mobile field is now the workspace-name input AND the source search, with the exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart" fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'" row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo switch prompt). Selecting a source shows a pill and moves the editable name into Advanced. The invented "Blank workspace" concept is removed — the neutral state is just a typed/empty name (blank submit still yields a creature name). DRY: the pure desktop logic (smart-workspace-source-results, -command-value, github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity) moves to src/shared/new-workspace/ with re-export shims at the old renderer paths, so both renderer and mobile share one implementation. composer-branch-selection and workspace-name were already shared and are reused directly. Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo, gitlab.workItemByPath). New mobile modules are split for max-lines: use-mobile-composer-source (selection state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source + smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration), composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes (pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields. Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection, use-workspace-source-search, and MobileWorkspaceNameInput. Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch preserves slashy names, cross-repo PR base resolves against the item's own repo, displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass. * fix(mobile): keep smart source drawer fully visible * refactor: share workspace creation behavior across clients * fix: address workspace creation review findings --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
179 lines
5.8 KiB
TypeScript
179 lines
5.8 KiB
TypeScript
import type { GitHubWorkItem, GitLabWorkItem } from '../../../src/shared/types'
|
|
import {
|
|
normalizeGitHubLinkQuery,
|
|
parseGitHubIssueOrPRLink,
|
|
type GitHubIssueOrPRLink,
|
|
type RepoSlug
|
|
} from '../../../src/shared/new-workspace/github-links'
|
|
import { parseGitLabIssueOrMRLink } from '../../../src/shared/new-workspace/gitlab-links'
|
|
import { isSmartWorkspaceSourceQueryWithinLimit } from '../../../src/shared/new-workspace/smart-workspace-source-results'
|
|
import type { RpcClient } from '../transport/rpc-client'
|
|
import type { RpcSuccess } from '../transport/types'
|
|
|
|
// A repo the picker can switch to for a cross-repo GitHub paste. Slug is derived
|
|
// best-effort from the repo's remote metadata.
|
|
export type PasteRepoCandidate = {
|
|
id: string
|
|
displayName: string
|
|
slug: RepoSlug | null
|
|
}
|
|
|
|
export type GitHubPasteIntent =
|
|
| { kind: 'github-link'; link: GitHubIssueOrPRLink }
|
|
| { kind: 'github-number'; number: number }
|
|
|
|
export type GitLabPasteIntent = {
|
|
kind: 'gitlab-link'
|
|
link: NonNullable<ReturnType<typeof parseGitLabIssueOrMRLink>>
|
|
}
|
|
|
|
export type PasteIntent = GitHubPasteIntent | GitLabPasteIntent | null
|
|
|
|
// Pure: classify pasted text into a work-item lookup intent. A slug-bearing
|
|
// GitHub URL becomes 'github-link'; a bare "#123"/number becomes 'github-number';
|
|
// a GitLab issue/MR URL becomes 'gitlab-link'.
|
|
export function resolvePasteIntent(query: string): PasteIntent {
|
|
if (!isSmartWorkspaceSourceQueryWithinLimit(query)) {
|
|
return null
|
|
}
|
|
const trimmed = query.trim()
|
|
if (!trimmed) {
|
|
return null
|
|
}
|
|
const ghLink = parseGitHubIssueOrPRLink(trimmed)
|
|
if (ghLink) {
|
|
return { kind: 'github-link', link: ghLink }
|
|
}
|
|
const normalizedGh = normalizeGitHubLinkQuery(trimmed)
|
|
if (normalizedGh.directNumber !== null && !/^https?:\/\//i.test(trimmed)) {
|
|
return { kind: 'github-number', number: normalizedGh.directNumber }
|
|
}
|
|
const glLink = parseGitLabIssueOrMRLink(trimmed)
|
|
if (glLink) {
|
|
return { kind: 'gitlab-link', link: glLink }
|
|
}
|
|
return null
|
|
}
|
|
|
|
// Pure: derive an owner/repo slug from a repo's remote metadata so a pasted
|
|
// cross-repo URL can be matched to a locally known repo.
|
|
export function deriveRepoSlug(repo: {
|
|
upstream?: { owner: string; repo: string } | null
|
|
gitRemoteIdentity?: { remoteUrl?: string; canonicalKey?: string } | null
|
|
}): RepoSlug | null {
|
|
if (repo.upstream?.owner && repo.upstream.repo) {
|
|
return { owner: repo.upstream.owner, repo: repo.upstream.repo }
|
|
}
|
|
const source = repo.gitRemoteIdentity?.remoteUrl ?? repo.gitRemoteIdentity?.canonicalKey ?? ''
|
|
const match = /(?:github\.com[/:]|^)([^/\s:]+)\/([^/\s]+?)(?:\.git)?$/i.exec(source)
|
|
if (match) {
|
|
return { owner: match[1], repo: match[2] }
|
|
}
|
|
return null
|
|
}
|
|
|
|
function slugsEqual(a: RepoSlug | null, b: RepoSlug | null): boolean {
|
|
if (!a || !b) {
|
|
return false
|
|
}
|
|
return (
|
|
a.owner.toLowerCase() === b.owner.toLowerCase() && a.repo.toLowerCase() === b.repo.toLowerCase()
|
|
)
|
|
}
|
|
|
|
export function findRepoMatchingSlug(
|
|
repos: readonly PasteRepoCandidate[],
|
|
slug: RepoSlug
|
|
): PasteRepoCandidate | null {
|
|
return repos.find((repo) => slugsEqual(repo.slug, slug)) ?? null
|
|
}
|
|
|
|
export async function findRepoMatchingSlugForPaste(
|
|
client: RpcClient,
|
|
repos: readonly PasteRepoCandidate[],
|
|
slug: RepoSlug,
|
|
cache: Map<string, RepoSlug | null>
|
|
): Promise<PasteRepoCandidate | null> {
|
|
const projected = findRepoMatchingSlug(repos, slug)
|
|
if (projected) {
|
|
return projected
|
|
}
|
|
// Why: projected remote metadata is incomplete for SSH and GitHub Enterprise;
|
|
// ask each repo's owning runtime instead of assuming github.com URL syntax.
|
|
for (const repo of repos) {
|
|
let resolved = cache.get(repo.id)
|
|
if (!cache.has(repo.id)) {
|
|
try {
|
|
const response = await client.sendRequest('github.repoSlug', { repo: `id:${repo.id}` })
|
|
if (!response.ok && response.error.code === 'method_not_found') {
|
|
// Why: RPC availability is host-wide; avoid repeating an unsupported
|
|
// probe for every repo or on the next paste attempt.
|
|
repos.forEach((candidate) => cache.set(candidate.id, null))
|
|
return null
|
|
}
|
|
resolved = response.ok ? ((response as RpcSuccess).result as RepoSlug | null) : null
|
|
} catch {
|
|
resolved = null
|
|
}
|
|
cache.set(repo.id, resolved ?? null)
|
|
}
|
|
if (slugsEqual(resolved ?? null, slug)) {
|
|
return repo
|
|
}
|
|
}
|
|
return null
|
|
}
|
|
|
|
export async function lookupGitHubItemByNumber(
|
|
client: RpcClient,
|
|
repoId: string,
|
|
number: number
|
|
): Promise<GitHubWorkItem | null> {
|
|
const response = await client.sendRequest('github.workItem', { repo: `id:${repoId}`, number })
|
|
if (!response.ok) {
|
|
throw new Error(response.error.message)
|
|
}
|
|
const item = (response as RpcSuccess).result as GitHubWorkItem | null
|
|
return item ? { ...item, repoId } : null
|
|
}
|
|
|
|
export async function lookupGitHubItemByOwnerRepo(
|
|
client: RpcClient,
|
|
repoId: string,
|
|
slug: RepoSlug,
|
|
number: number,
|
|
type: 'issue' | 'pr'
|
|
): Promise<GitHubWorkItem | null> {
|
|
const response = await client.sendRequest('github.workItemByOwnerRepo', {
|
|
repo: `id:${repoId}`,
|
|
owner: slug.owner,
|
|
ownerRepo: slug.repo,
|
|
number,
|
|
type
|
|
})
|
|
if (!response.ok) {
|
|
throw new Error(response.error.message)
|
|
}
|
|
const item = (response as RpcSuccess).result as GitHubWorkItem | null
|
|
return item ? { ...item, repoId } : null
|
|
}
|
|
|
|
export async function lookupGitLabItemByPath(
|
|
client: RpcClient,
|
|
repoId: string,
|
|
link: NonNullable<ReturnType<typeof parseGitLabIssueOrMRLink>>
|
|
): Promise<GitLabWorkItem | null> {
|
|
const response = await client.sendRequest('gitlab.workItemByPath', {
|
|
repo: `id:${repoId}`,
|
|
host: link.slug.host,
|
|
path: link.slug.path,
|
|
iid: link.number,
|
|
type: link.type
|
|
})
|
|
if (!response.ok) {
|
|
throw new Error(response.error.message)
|
|
}
|
|
const item = (response as RpcSuccess).result as GitLabWorkItem | null
|
|
return item ? { ...item, repoId } : null
|
|
}
|