mirror of
https://github.com/stablyai/orca.git
synced 2026-10-25 16:03:53 +00:00
Neil
77f23b013f
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
108 lines
4.1 KiB
TypeScript
108 lines
4.1 KiB
TypeScript
import type { UpdateStatus } from '../shared/update-status-types'
|
|
import {
|
|
compareAppVersions,
|
|
isPrereleaseAppVersion,
|
|
isValidAppVersion
|
|
} from '../shared/app-version'
|
|
|
|
export const compareVersions = compareAppVersions
|
|
export const isPrereleaseVersion = isPrereleaseAppVersion
|
|
export const isValidVersion = isValidAppVersion
|
|
|
|
export function statusesEqual(left: UpdateStatus, right: UpdateStatus): boolean {
|
|
if (left.source !== right.source) {
|
|
return false
|
|
}
|
|
switch (left.state) {
|
|
case 'idle':
|
|
return right.state === 'idle'
|
|
case 'checking':
|
|
return right.state === 'checking' && left.userInitiated === right.userInitiated
|
|
case 'not-available':
|
|
return right.state === 'not-available' && left.userInitiated === right.userInitiated
|
|
case 'available':
|
|
return (
|
|
right.state === 'available' &&
|
|
left.version === right.version &&
|
|
left.activeNudgeId === right.activeNudgeId &&
|
|
left.releaseUrl === right.releaseUrl &&
|
|
// Why: fetchChangelog creates a fresh object each time, so reference
|
|
// equality is always false. Compare by presence — since update-available
|
|
// fires at most once per check cycle, this is sufficient.
|
|
Boolean(left.changelog) === Boolean(right.changelog)
|
|
)
|
|
case 'downloading':
|
|
return (
|
|
right.state === 'downloading' &&
|
|
left.version === right.version &&
|
|
left.activeNudgeId === right.activeNudgeId &&
|
|
left.percent === right.percent
|
|
)
|
|
case 'downloaded':
|
|
return (
|
|
right.state === 'downloaded' &&
|
|
left.version === right.version &&
|
|
left.activeNudgeId === right.activeNudgeId &&
|
|
left.releaseUrl === right.releaseUrl
|
|
)
|
|
case 'error':
|
|
return (
|
|
right.state === 'error' &&
|
|
left.message === right.message &&
|
|
left.userInitiated === right.userInitiated &&
|
|
left.activeNudgeId === right.activeNudgeId &&
|
|
// Why: clearing recovery must reach the renderer even when the message is unchanged, or dead actions stay enabled.
|
|
left.recovery?.kind === right.recovery?.kind &&
|
|
left.recovery?.packageType === right.recovery?.packageType &&
|
|
left.recovery?.reason === right.recovery?.reason &&
|
|
left.recovery?.version === right.recovery?.version
|
|
)
|
|
}
|
|
}
|
|
|
|
export function isGitHubReleaseTransitionFailure(normalizedMessage: string): boolean {
|
|
return (
|
|
normalizedMessage.includes('unable to find latest version on github') ||
|
|
normalizedMessage.includes('cannot find channel') ||
|
|
normalizedMessage.includes('latest.yml') ||
|
|
normalizedMessage.includes('latest-mac.yml') ||
|
|
normalizedMessage.includes('no published versions on github')
|
|
)
|
|
}
|
|
|
|
export function isMissingUpdateManifestFailure(message: string): boolean {
|
|
const normalizedMessage = message.toLowerCase()
|
|
return (
|
|
normalizedMessage.includes('404') &&
|
|
(normalizedMessage.includes('cannot find channel') ||
|
|
normalizedMessage.includes('latest.yml') ||
|
|
normalizedMessage.includes('latest-mac.yml') ||
|
|
normalizedMessage.includes('latest-linux.yml'))
|
|
)
|
|
}
|
|
|
|
export function isReleaseAssetsPublishingFailure(message: string): boolean {
|
|
return message.toLowerCase().includes('latest release assets are still publishing')
|
|
}
|
|
|
|
/** Identifies update-check failures that are transient or infrastructure-related
|
|
* (e.g. network blips, GitHub release transitions) and should NOT be surfaced
|
|
* to the user as errors. */
|
|
export function isBenignCheckFailure(message: string): boolean {
|
|
const normalizedMessage = message.toLowerCase()
|
|
|
|
if (normalizedMessage.includes('net::err_failed')) {
|
|
return true
|
|
}
|
|
|
|
// GitHub releases can briefly be in a half-published state while the
|
|
// release workflow is creating a draft and uploading update metadata.
|
|
// During that window electron-updater may fail the check even though
|
|
// nothing is wrong on the client side.
|
|
return (
|
|
isReleaseAssetsPublishingFailure(message) ||
|
|
isGitHubReleaseTransitionFailure(normalizedMessage) ||
|
|
normalizedMessage.includes('no published versions on github')
|
|
)
|
|
}
|