mirror of
https://github.com/stablyai/orca.git
synced 2026-10-08 00:02:38 +00:00
Brennan Benson
48e31b3fc0
* fix(agent-status): track Codex rollout subagents * fix(agent-status): resolve cross-day Codex child rollouts and unblock CI gate Codex files each rollout under its own local start date, so a session that runs past midnight spawns children into a sibling day directory. Scanning only the parent's directory left 13% of real subagent spawns (48/371 across local rollouts) permanently unresolved, which pinned a phantom "working" row and re-ran readdirSync every poll tick forever. Resolve the child's own day directory from occurred_at_ms, and time-box a child whose rollout stays unreadable so a deleted or never-written file can't leak a working row. Also make the hook HTTP handler return void: the changed-code quality gate keys findings by span overlap, so this PR's added line inside the pre-existing async createServer callback resurfaced no-misused-promises as a new finding. Tests cover cross-day resolution, grace-period retirement, and that the poll re-arms across successive roster changes (the prior tests passed even when the poll died after its first change). * fix(agent-status): keep the Codex subagent poll alive across nested hooks A nested non-codex CLI inherits its parent's ORCA_PANE_KEY, so its hook POST reached scheduleCodexSubagentPoll and tore the timer down before the source guard, silently ending polling while a rollout child was still live.
93 lines
2.7 KiB
TypeScript
93 lines
2.7 KiB
TypeScript
import { afterEach, describe, expect, it } from 'vitest'
|
|
import { mkdtempSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
|
|
import { createHookListenerState, normalizeHookPayload } from './agent-hook-listener'
|
|
import { makePaneKey } from './stable-pane-id'
|
|
|
|
const PANE_KEY = makePaneKey('tab-1', '11111111-1111-4111-8111-111111111111')
|
|
const CHILD_ID = '019fa65f-3144-7151-9c02-cff7a28f316f'
|
|
|
|
function jsonl(records: unknown[]): string {
|
|
return `${records.map((record) => JSON.stringify(record)).join('\n')}\n`
|
|
}
|
|
|
|
describe('Codex rollout subagent lifecycle', () => {
|
|
const dirs: string[] = []
|
|
|
|
afterEach(() => {
|
|
for (const dir of dirs) {
|
|
rmSync(dir, { recursive: true, force: true })
|
|
}
|
|
dirs.length = 0
|
|
})
|
|
|
|
it('surfaces a collaboration child without lifecycle hooks and retires it on task_complete', () => {
|
|
const dir = mkdtempSync(join(tmpdir(), 'codex-rollout-lifecycle-'))
|
|
dirs.push(dir)
|
|
const parentPath = join(dir, 'rollout-parent.jsonl')
|
|
const childPath = join(dir, `rollout-child-${CHILD_ID}.jsonl`)
|
|
writeFileSync(
|
|
parentPath,
|
|
jsonl([
|
|
{
|
|
type: 'event_msg',
|
|
payload: {
|
|
type: 'sub_agent_activity',
|
|
occurred_at_ms: 1234,
|
|
agent_thread_id: CHILD_ID,
|
|
agent_path: '/root/pr_review',
|
|
kind: 'started'
|
|
}
|
|
}
|
|
])
|
|
)
|
|
writeFileSync(childPath, jsonl([{ type: 'event_msg', payload: { type: 'task_started' } }]))
|
|
const state = createHookListenerState()
|
|
const event = (hookEventName: string): ReturnType<typeof normalizeHookPayload> =>
|
|
normalizeHookPayload(
|
|
state,
|
|
'codex',
|
|
{
|
|
paneKey: PANE_KEY,
|
|
payload: {
|
|
hook_event_name: hookEventName,
|
|
session_id: 'root-session',
|
|
transcript_path: parentPath,
|
|
tool_name: 'collaborationspawn_agent'
|
|
}
|
|
},
|
|
'production'
|
|
)
|
|
|
|
const spawned = event('PostToolUse')
|
|
expect(spawned?.payload).toMatchObject({
|
|
state: 'working',
|
|
subagents: [
|
|
{
|
|
id: CHILD_ID,
|
|
description: '/root/pr_review',
|
|
state: 'working',
|
|
startedAt: 1234
|
|
}
|
|
]
|
|
})
|
|
|
|
const leadStopped = event('Stop')
|
|
expect(leadStopped?.payload.state).toBe('working')
|
|
expect(leadStopped?.payload.subagents).toHaveLength(1)
|
|
|
|
writeFileSync(
|
|
childPath,
|
|
jsonl([
|
|
{ type: 'event_msg', payload: { type: 'task_started' } },
|
|
{ type: 'event_msg', payload: { type: 'task_complete' } }
|
|
])
|
|
)
|
|
const completed = event('Stop')
|
|
expect(completed?.payload.state).toBe('done')
|
|
expect(completed?.payload.subagents).toBeUndefined()
|
|
})
|
|
})
|