mirror of
https://github.com/stablyai/orca.git
synced 2026-10-22 16:03:47 +00:00
Neil
1f2e18acc1
* fix(e2e): repair seven specs whose assertions drifted from shipped behavior The E2E suite could not collect at all until #13758, so these seven had been failing unobserved. Each is a stale test, not a product defect — verified individually against src/ rather than by making the assertion pass. - worktree-jump-palette-filter: the palette placeholder gained chats and terminals. Hoisted to one SEARCH_PLACEHOLDER const. - tab-create-entry-file-paths: matched the omnibox by its translated aria-label. Switched to aria-controls, which is structural and unlocalized. - browser-local-https-certificate-trust: once a load settles, the toolbar reload button relabels itself "Retry" alongside the failure overlay's own Retry, so the slot-wide locator hit two elements and failed strict mode. The test only ever passed inside the window where the toolbar still read "Stop". Narrowed by visible text; the icon button has none. - repro-7732-gitlab-checks-job-details: the activity-bar label carries a failure suffix ("Checks — Error"), which an exact-name match stops seeing precisely when the checks under test fail. Anchored regex, and bounded the click so the poll retries instead of hanging on a label that flips mid-action. - floating-tab-rename: the panel's open flag is persisted, so after the restart the helper's blind toggle closed the panel it was about to assert on. Made it idempotent. - github-created-issue-start-prefill: starting an issue now routes through the quick-create composer, so the launch command only forms once that is submitted. The spec now drives it. - ssh-config-host-import: P6 waited on "All hosts already in Orca", a string that exists nowhere in src/ and never could have matched. P7 required the tombstoned host to be absent, but listing it behind a "Removed from Orca" badge is deliberate — see the rationale at ssh-config-host-picker.ts:54 and the unit test already pinning it. Both retargeted; P7 still proves the host is excluded from bulk re-adoption, which is what it was for. Verified locally: all seven pass. github-created-issue-start-prefill cannot be verified on a machine whose gh resolves to an Orca terminal-attribution shim, since hydrateShellPath puts that ahead of the fixture's fake gh; CI has no shim. Three further failures are NOT addressed here. Adversarial review found the obvious test-side fix for each would have masked a real product bug, so they are being fixed in the product instead. * fix(e2e): configure the issue spec's git remote before Electron launches The spec added origin inside the test body, after the orcaPage fixture had already launched the app and added the repo. "New GitHub issue" is disabled when no repo is task-eligible, and eligibility is decided by the git remote probe alone: repos.add runs detectRepoIconAndUpstream, and a settled "no remote" writes gitRemoteIdentity = null, which is the ineligible marker. Background enrichment then suppresses re-probing that location for five minutes, so a remote added afterwards can never recover the button. It passed only when the shared seeded repo happened to already carry an origin from an earlier spec in the same worker — github-cli-stall-repro adds one, source-control-create-pr-intent-switch removes one — which is why it passed in the sharded lane and failed in the changed-specs lane. Moved to test.beforeAll, whose worker-scoped testRepoPath runs before the test-scoped Electron fixtures. Reproduced the failure against a fresh origin-less repo, then confirmed the fix on the same, including --repeat-each=2. Note the earlier attribution was wrong: the local failure at this line was never the gh attribution shim. The button's enabled state reads `git remote -v` and never consults gh, so a shim can only bite later, at issue creation.
66 lines
3.0 KiB
TypeScript
66 lines
3.0 KiB
TypeScript
import { mkdirSync, writeFileSync } from 'node:fs'
|
|
import path from 'node:path'
|
|
import { expect, test } from './helpers/orca-app'
|
|
import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'
|
|
|
|
const relativeFilePath =
|
|
'packages/orca/src/renderer/src/components/navigation/worktree/secondary-nav/SecondaryNav.tsx'
|
|
|
|
test('new-tab file results prioritize the filename and reveal the full path on hover', async ({
|
|
orcaPage,
|
|
testRepoPath
|
|
}) => {
|
|
const filePath = path.join(testRepoPath, ...relativeFilePath.split('/'))
|
|
mkdirSync(path.dirname(filePath), { recursive: true })
|
|
writeFileSync(filePath, 'export const SecondaryNav = true\n')
|
|
|
|
await waitForSessionReady(orcaPage)
|
|
await waitForActiveWorktree(orcaPage)
|
|
await ensureTerminalVisible(orcaPage)
|
|
|
|
await orcaPage.getByRole('button', { name: 'New tab' }).click({ force: true })
|
|
// Not the placeholder/aria-label: that copy is translated and already drifted
|
|
// once. aria-controls points at the results listbox id, which is structural.
|
|
const input = orcaPage.locator('input[role="combobox"][aria-controls="tab-create-entry-results"]')
|
|
await input.fill('secondaryNav')
|
|
|
|
const row = orcaPage.locator('[role="option"]').filter({ hasText: 'Open file' }).first()
|
|
await expect(row).toBeVisible()
|
|
await expect(row).toContainText('SecondaryNav.tsx')
|
|
await expect(row).toContainText('packages/orca/src/renderer/src/components/navigation/')
|
|
const rowText = await row.textContent()
|
|
expect(rowText?.indexOf('SecondaryNav.tsx')).toBeLessThan(
|
|
rowText?.indexOf('packages/orca/src/renderer/src/components/navigation/') ?? -1
|
|
)
|
|
|
|
// The filename must survive intact; only the directory may be clipped, and the
|
|
// row itself must never spill past the dropdown.
|
|
const overflow = await row.evaluate((element) => {
|
|
const filename = element.querySelector(':scope > span:last-of-type > span:first-child')
|
|
return {
|
|
filenameClipped: filename ? filename.scrollWidth > filename.clientWidth : true,
|
|
rowClipped: element.scrollWidth > element.clientWidth
|
|
}
|
|
})
|
|
expect(overflow).toEqual({ filenameClipped: false, rowClipped: false })
|
|
|
|
// Two hovers on purpose: results stream in and remount the row, and Radix only
|
|
// opens on a pointermove it actually receives. A single hover can land before
|
|
// the remount and leave the cursor sitting still over a row that never saw it.
|
|
await row.hover({ position: { x: 20, y: 12 } })
|
|
await orcaPage.waitForTimeout(250)
|
|
await row.hover({ position: { x: 40, y: 12 } })
|
|
|
|
// Exact cursor placement is arithmetic, unit-tested via cursorTooltipOffsets.
|
|
// Asserting it here measured the app mid-reflow and was flaky; what E2E is
|
|
// uniquely good for is that the tooltip really opens with the whole path.
|
|
await expect(
|
|
orcaPage.locator('[data-slot="tooltip-content"]').filter({ hasText: relativeFilePath })
|
|
).toBeVisible()
|
|
|
|
const proofPath = process.env.ORCA_STA3424_PROOF_PATH
|
|
if (proofPath) {
|
|
await orcaPage.screenshot({ path: proofPath })
|
|
}
|
|
})
|