mirror of
https://github.com/stablyai/orca.git
synced 2026-09-24 16:02:41 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
85 lines
2.9 KiB
TypeScript
85 lines
2.9 KiB
TypeScript
import { mkdtempSync, statSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
import { encodePairingOffer } from '../../shared/pairing'
|
|
import {
|
|
addEnvironmentFromPairingCode,
|
|
getEnvironmentStorePath,
|
|
listEnvironments,
|
|
removeEnvironment,
|
|
resolveEnvironmentPairingOffer
|
|
} from './environments'
|
|
|
|
function pairingCode(endpoint = 'ws://127.0.0.1:6768'): string {
|
|
return encodePairingOffer({
|
|
v: 2,
|
|
endpoint,
|
|
deviceToken: 'device-token',
|
|
publicKeyB64: Buffer.from(new Uint8Array(32).fill(1)).toString('base64')
|
|
})
|
|
}
|
|
|
|
describe('CLI runtime environments', () => {
|
|
const posixModeIt = process.platform === 'win32' ? it.skip : it
|
|
|
|
it('saves, resolves, and removes a paired environment', () => {
|
|
const userDataPath = mkdtempSync(join(tmpdir(), 'orca-env-store-'))
|
|
const saved = addEnvironmentFromPairingCode(userDataPath, {
|
|
name: 'workstation',
|
|
pairingCode: pairingCode(),
|
|
now: 100
|
|
})
|
|
|
|
expect(listEnvironments(userDataPath)).toHaveLength(1)
|
|
expect(resolveEnvironmentPairingOffer(userDataPath, 'workstation')).toMatchObject({
|
|
endpoint: 'ws://127.0.0.1:6768',
|
|
deviceToken: 'device-token'
|
|
})
|
|
expect(resolveEnvironmentPairingOffer(userDataPath, saved.id)).toMatchObject({
|
|
endpoint: 'ws://127.0.0.1:6768'
|
|
})
|
|
expect(statSync(getEnvironmentStorePath(userDataPath)).isFile()).toBe(true)
|
|
|
|
const removed = removeEnvironment(userDataPath, 'workstation')
|
|
expect(removed.id).toBe(saved.id)
|
|
expect(listEnvironments(userDataPath)).toEqual([])
|
|
})
|
|
|
|
posixModeIt('stores paired environments with owner-only POSIX permissions', () => {
|
|
const userDataPath = mkdtempSync(join(tmpdir(), 'orca-env-store-'))
|
|
|
|
addEnvironmentFromPairingCode(userDataPath, {
|
|
name: 'workstation',
|
|
pairingCode: pairingCode(),
|
|
now: 100
|
|
})
|
|
|
|
// Why: NTFS mode bits do not prove Windows ACL hardening; shared secure-file
|
|
// tests cover that path, while POSIX hosts must keep the token store at 0600.
|
|
expect((statSync(getEnvironmentStorePath(userDataPath)).mode & 0o777).toString(8)).toBe('600')
|
|
})
|
|
|
|
it('rejects an environment with the same name', () => {
|
|
const userDataPath = mkdtempSync(join(tmpdir(), 'orca-env-store-'))
|
|
const first = addEnvironmentFromPairingCode(userDataPath, {
|
|
name: 'workstation',
|
|
pairingCode: pairingCode('ws://127.0.0.1:1111'),
|
|
now: 100
|
|
})
|
|
|
|
expect(() =>
|
|
addEnvironmentFromPairingCode(userDataPath, {
|
|
name: 'workstation',
|
|
pairingCode: pairingCode('ws://127.0.0.1:2222'),
|
|
now: 200
|
|
})
|
|
).toThrow('A server named "workstation" already exists.')
|
|
expect(listEnvironments(userDataPath)).toHaveLength(1)
|
|
expect(resolveEnvironmentPairingOffer(userDataPath, 'workstation').endpoint).toBe(
|
|
'ws://127.0.0.1:1111'
|
|
)
|
|
expect(listEnvironments(userDataPath)[0]?.id).toBe(first.id)
|
|
})
|
|
})
|