mirror of
https://github.com/stablyai/orca.git
synced 2026-10-22 16:03:47 +00:00
Resolve agent CLIs against PATH with fs instead of spawning one where/which subprocess per candidate (~34 at startup). Same found/not-found result (same env/PATH, faithful which/where semantics); subprocess spawns 34->0. Fixes #9297.
114 lines
3.8 KiB
TypeScript
114 lines
3.8 KiB
TypeScript
import { execFile } from 'node:child_process'
|
|
import path from 'node:path'
|
|
import { promisify } from 'node:util'
|
|
import { buildPosixCommandPathLookupScript } from '../../shared/posix-command-path-lookup'
|
|
import { isCommandOnLocalPath } from './command-path-resolver'
|
|
import { buildLocalPreflightEnv } from './preflight-local-env'
|
|
import { runPreflightCommandInWsl } from './preflight-wsl-command'
|
|
import type { WslPreflightTarget } from './preflight-wsl-agent-detection'
|
|
|
|
const execFileAsync = promisify(execFile)
|
|
export const PREFLIGHT_COMMAND_TIMEOUT_MS = 5000
|
|
const WSL_COMMAND_PATH_SENTINEL = '__ORCA_PREFLIGHT_COMMAND_PATH__'
|
|
|
|
export type PreflightCommandResult = { stdout: string; stderr: string }
|
|
|
|
export function shellQuote(value: string): string {
|
|
return `'${value.replace(/'/g, "'\\''")}'`
|
|
}
|
|
|
|
async function withPreflightTimeout<T>(command: string, commandPromise: Promise<T>): Promise<T> {
|
|
let timeout: ReturnType<typeof setTimeout> | null = null
|
|
try {
|
|
return await Promise.race([
|
|
commandPromise,
|
|
new Promise<never>((_resolve, reject) => {
|
|
timeout = setTimeout(() => {
|
|
const error = Object.assign(new Error(`Timed out running ${command}`), {
|
|
code: 'ETIMEDOUT'
|
|
})
|
|
reject(error)
|
|
}, PREFLIGHT_COMMAND_TIMEOUT_MS)
|
|
if (typeof timeout.unref === 'function') {
|
|
timeout.unref()
|
|
}
|
|
})
|
|
])
|
|
} finally {
|
|
if (timeout) {
|
|
clearTimeout(timeout)
|
|
}
|
|
}
|
|
}
|
|
|
|
export async function execLocalPreflightCommand(
|
|
command: string,
|
|
args: string[]
|
|
): Promise<PreflightCommandResult> {
|
|
const env = buildLocalPreflightEnv()
|
|
const commandPromise = execFileAsync(command, args, {
|
|
encoding: 'utf-8',
|
|
timeout: PREFLIGHT_COMMAND_TIMEOUT_MS,
|
|
...(env ? { env } : {})
|
|
}) as Promise<PreflightCommandResult>
|
|
|
|
return withPreflightTimeout(command, commandPromise)
|
|
}
|
|
|
|
export async function execCommandInWsl(
|
|
target: WslPreflightTarget,
|
|
command: string
|
|
): Promise<PreflightCommandResult> {
|
|
const commandPromise = runPreflightCommandInWsl(target, command, PREFLIGHT_COMMAND_TIMEOUT_MS)
|
|
return withPreflightTimeout('wsl.exe', commandPromise)
|
|
}
|
|
|
|
export async function isCommandAvailable(
|
|
command: string,
|
|
wslTarget?: WslPreflightTarget
|
|
): Promise<boolean> {
|
|
try {
|
|
await (wslTarget
|
|
? execCommandInWsl(wslTarget, `${shellQuote(command)} --version`)
|
|
: execLocalPreflightCommand(command, ['--version']))
|
|
return true
|
|
} catch {
|
|
return false
|
|
}
|
|
}
|
|
|
|
export async function isCommandOnPath(
|
|
command: string,
|
|
wslTarget?: WslPreflightTarget
|
|
): Promise<boolean> {
|
|
if (!wslTarget) {
|
|
// Why (#9297): resolve against PATH with fs instead of spawning one
|
|
// where/which subprocess per probe — privilege-management software gates
|
|
// each spawn and stalls startup. buildLocalPreflightEnv() supplies the same
|
|
// registry-merged PATH the child process previously saw (undefined = posix
|
|
// process.env), so the found/not-found result is identical.
|
|
return isCommandOnLocalPath(command, { env: buildLocalPreflightEnv() })
|
|
}
|
|
try {
|
|
// Why: preflight must validate the executable on PATH, not a shell alias or function.
|
|
const { stdout } = await execCommandInWsl(
|
|
wslTarget,
|
|
[
|
|
buildPosixCommandPathLookupScript({ kind: 'literal', value: command }),
|
|
'if [ -n "$resolved" ]; then',
|
|
`printf '${WSL_COMMAND_PATH_SENTINEL}%s\\n' "$resolved"`,
|
|
'fi'
|
|
].join('\n')
|
|
)
|
|
// Why: WSL startup chatter can contain unrelated absolute paths.
|
|
return stdout
|
|
.split(/\r?\n/)
|
|
.map((line) => line.trim())
|
|
.filter((line) => line.startsWith(WSL_COMMAND_PATH_SENTINEL))
|
|
.map((line) => line.slice(WSL_COMMAND_PATH_SENTINEL.length))
|
|
.some((line) => path.posix.isAbsolute(line))
|
|
} catch {
|
|
return false
|
|
}
|
|
}
|