Files
orca/mobile/src/session/QuickCommandsSheet.test.ts
T
Brennan BensonandOrcaWin 7c23f79622 fix(quick-commands): save agent prompts whole, bounded by what a chat message carries (#24488)
* fix(quick-commands): save agent prompts whole, bounded by what a chat message carries

Agent quick-command prompts were silently cut to 6,000 characters on save:
the editor accepted a long paste, settings normalization trimmed it, and
reopening showed the shortened copy. The 6,000 was a Windows launch speed
threshold, not a limit on prompts.

- Storage no longer trims. A save is refused, never trimmed, when a prompt's
  chat text block is over 256 KiB of JSON (measured on its real escaped size,
  the measure the chat send schema applies) or the list is too large for one
  paired reply. Host and desktop store both check before writing.
- The editor shows the size against the limit and blocks Save past it, and
  stays open with the text when the host refuses the save.
- terminal.quick-commands.long-prompts.v1: hosts withhold prompts over 6,000
  characters from clients that do not advertise it (older clients reject a
  whole list holding one); editors keep an older host's 6,000 cap.
- The phone editor no longer drops pasted text past 6,000 via maxLength.

Launch delivery of long prompts is left to the launch-prompt series
(#24257, #23962, #24080); this branch's earlier paste-after-ready delivery
duplicated it and is removed.

* fix(quick-commands): drop a stale duplicate doc comment

* fix(quick-commands): advertise long prompts to this build's own host too

* fix(quick-commands): keep submitted editor immutable until save settles

* test(quick-commands): keep storage and save lifecycle coverage focused

* fix(quick-commands): keep portalled choices within pending form ownership

* Preserve retained credentials when settings validation refuses a save

---------

Co-authored-by: OrcaWin <alpha-eng@stably.ai>
2026-10-15 18:37:41 -07:00

220 lines
6.4 KiB
TypeScript

import { createElement, type ReactNode } from 'react'
import { act, create, type ReactTestRenderer } from 'react-test-renderer'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import type { TerminalQuickCommand } from '../../../src/shared/terminal-quick-command-types'
import type { RpcClient } from '../transport/rpc-client'
import { MAX_QUICK_COMMANDS } from '../terminal/quick-commands'
import { QuickCommandsSheet } from './QuickCommandsSheet'
const mocks = vi.hoisted(() => ({
alert: vi.fn(),
commands: [] as TerminalQuickCommand[],
persist: vi.fn()
}))
const quickCommandEditorForm = 'QuickCommandEditorForm'
const quickCommandsList = 'QuickCommandsList'
const command: TerminalQuickCommand = {
id: 'command',
label: 'Test',
action: 'terminal-command',
command: 'pnpm test',
appendEnter: true,
scope: { type: 'global' }
}
vi.mock('react-native', () => ({
Alert: { alert: mocks.alert },
Pressable: 'Pressable',
StyleSheet: { create: <T>(styles: T) => styles },
Text: 'Text',
View: 'View'
}))
vi.mock('lucide-react-native', () => ({ ChevronLeft: 'ChevronLeft' }))
vi.mock('../components/BottomDrawer', () => ({
BottomDrawer: ({ children }: { children: ReactNode }) => children
}))
vi.mock('./QuickCommandEditorForm', () => ({
QuickCommandEditorForm: 'QuickCommandEditorForm'
}))
vi.mock('./QuickCommandsList', () => ({
QuickCommandAgentPicker: 'QuickCommandAgentPicker',
QuickCommandsList: 'QuickCommandsList'
}))
vi.mock('./use-quick-commands', () => ({
useQuickCommands: () => ({
commands: mocks.commands,
loading: false,
ready: true,
error: null,
persist: mocks.persist
})
}))
function deferred<T>() {
let resolve: (value: T) => void = () => {}
const promise = new Promise<T>((done) => {
resolve = done
})
return { promise, resolve }
}
describe('QuickCommandsSheet', () => {
let renderer: ReactTestRenderer | null = null
beforeEach(() => {
mocks.alert.mockReset()
mocks.commands = []
mocks.persist.mockReset()
})
afterEach(() => {
act(() => renderer?.unmount())
renderer = null
})
it('keeps the sheet open when a launch is rejected', async () => {
const onClose = vi.fn()
const onLaunch = vi.fn(() => false)
await act(async () => {
renderer = create(
createElement(QuickCommandsSheet, {
visible: true,
onClose,
client: {} as RpcClient,
repoId: 'repo-1',
repoName: 'Repo',
agentPromptMaxLength: null,
onLaunch
})
)
})
act(() => renderer!.root.findByType(quickCommandsList).props.onLaunch(command))
expect(onLaunch).toHaveBeenCalledWith(command)
expect(onClose).not.toHaveBeenCalled()
})
it('submits one full-list mutation for a same-frame double tap', async () => {
const save = deferred<boolean>()
mocks.persist.mockReturnValue(save.promise)
await act(async () => {
renderer = create(
createElement(QuickCommandsSheet, {
visible: true,
onClose: vi.fn(),
client: {} as RpcClient,
repoId: 'repo-1',
repoName: 'Repo',
agentPromptMaxLength: null,
onLaunch: () => true
})
)
})
act(() => renderer!.root.findByType(quickCommandsList).props.onAdd())
const editor = renderer!.root.findByType(quickCommandEditorForm)
act(() => {
editor.props.onChange({ label: 'Test' })
editor.props.onChange({ command: 'pnpm test' })
})
const readyEditor = renderer!.root.findByType(quickCommandEditorForm)
act(() => {
readyEditor.props.onSave()
readyEditor.props.onSave()
})
expect(mocks.persist).toHaveBeenCalledTimes(1)
await act(async () => {
save.resolve(true)
await save.promise
})
})
it('keeps creation closed when the host command limit is reached', async () => {
mocks.commands = Array.from({ length: MAX_QUICK_COMMANDS }, (_, index) => ({
...command,
id: `command-${index}`
}))
await act(async () => {
renderer = create(
createElement(QuickCommandsSheet, {
visible: true,
onClose: vi.fn(),
client: {} as RpcClient,
repoId: 'repo-1',
repoName: 'Repo',
agentPromptMaxLength: null,
onLaunch: () => true
})
)
})
const list = renderer!.root.findByType(quickCommandsList)
expect(list.props.canAdd).toBe(false)
act(() => list.props.onAdd())
expect(renderer!.root.findAllByType(quickCommandEditorForm)).toHaveLength(0)
})
it('shows only global commands and defaults new commands to global without a repo', async () => {
const repoCommand: TerminalQuickCommand = {
...command,
id: 'repo-command',
scope: { type: 'repo', repoId: 'repo-1' }
}
mocks.commands = [command, repoCommand]
await act(async () => {
renderer = create(
createElement(QuickCommandsSheet, {
visible: true,
onClose: vi.fn(),
client: {} as RpcClient,
repoId: null,
repoName: 'Folder workspace',
agentPromptMaxLength: null,
onLaunch: () => true
})
)
})
const list = renderer!.root.findByType(quickCommandsList)
expect(list.props.globalCommands).toEqual([command])
expect(list.props.repoCommands).toEqual([])
act(() => list.props.onAdd())
expect(renderer!.root.findByType(quickCommandEditorForm).props.draft.scope).toEqual({
type: 'global'
})
})
it('does not delete a shared command until the destructive action is confirmed', async () => {
await act(async () => {
renderer = create(
createElement(QuickCommandsSheet, {
visible: true,
onClose: vi.fn(),
client: {} as RpcClient,
repoId: 'repo-1',
repoName: 'Repo',
agentPromptMaxLength: null,
onLaunch: () => true
})
)
})
act(() => renderer!.root.findByType(quickCommandsList).props.onDelete(command))
expect(mocks.persist).not.toHaveBeenCalled()
const actions = mocks.alert.mock.calls[0]?.[2] as
| Array<{ style?: string; onPress?: () => void }>
| undefined
act(() => actions?.find((action) => action.style === 'destructive')?.onPress?.())
expect(mocks.persist).toHaveBeenCalledTimes(1)
expect(mocks.persist).toHaveBeenCalledWith({ type: 'delete', id: command.id })
})
})