Files
orca/config/scripts/check-layout-writer-ratchets.mjs
T
OrcaWinandOrcaWin 7d6603aa17 [comment audit] Complete repository-wide comment cleanup (#33249)
* [comment audit] Align legacy failure-read counts with cached display

* [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci]

* [comment audit] Condense shared generation, path and preview comments [skip ci]

* [comment audit] Condense host, file and Git contract rationale [skip ci]

* [comment audit] Tighten Git lifecycle and provider contract comments [skip ci]

* [comment audit] Clarify shared host authority and launch isolation [skip ci]

* [comment audit] simplify local access mobile and native chat contracts [skip ci]

* [comment audit] simplify native chat presentation and state contracts [skip ci]

* [comment audit] simplify native runtime and provider contracts [skip ci]

* [comment audit] simplify migration and orchestration contracts [skip ci]

* [comment audit] simplify plugin trust and process capture rationale [skip ci]

* [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci]

* [comment audit] clarify remote recovery and launch wire rationale [skip ci]

* [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci]

* [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci]

* [comment audit] clarify sidebar, skill and SSH invariants [skip ci]

* [comment audit] condense structured chat delivery and timing rationale [skip ci]

* [comment audit] condense terminal replay and telemetry invariants [skip ci]

* [comment audit] clarify launch permission and terminal delivery rationale [skip ci]

* [comment audit] clarify workspace ownership and layout contracts [skip ci]

* [comment audit] wait for fitted and painted SSH terminal links

* [comment audit] clarify layout persistence and session ownership [skip ci]

* [comment audit] clarify host routing and workspace lifecycle contracts [skip ci]

* [comment audit] clarify startup persistence and app lifetime comments [skip ci]

* [comment audit] clarify recovery and activity boundaries [skip ci]

* [comment audit] condense activity and artifact invariants [skip ci]

* [comment audit] condense automation authority contracts [skip ci]

* [comment audit] simplify automation scheduling and history contracts [skip ci]

* [comment audit] clarify browser chrome and annotation lifecycles [skip ci]

* [comment audit] clarify browser routing and retained guest ownership [skip ci]

* [comment audit] clarify browser recovery and document ownership comments [skip ci]

* [comment audit] restore hosted runners required by native IME fixtures

* [comment audit] shorten preview, palette and dashboard invariants [skip ci]

* [comment audit] clarify terminal preview, dashboard and retention comments [skip ci]

* [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci]

* [comment audit] shorten rich-text and combined-diff ownership comments [skip ci]

* [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci]

* [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci]

* [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci]

* [comment audit] clarify rich Markdown source and selection safeguards [skip ci]

* [comment audit] clarify editor loading and emulator stream lifetimes [skip ci]

* [comment audit] trim emulator and feature tour narration [skip ci]

* [comment audit] clarify floating workspace and GitHub cache ownership [skip ci]

* [comment audit] trim provider controls and Linear filter explanations [skip ci]

* [comment audit] clarify pairing and chat resume lifetimes [skip ci]

* [comment audit] clarify chat delivery and transcript lifetimes [skip ci]

* [comment audit] clarify session options and host-owned status [skip ci]

* [comment audit] clarify draft durability and live-status precedence [skip ci]

* [comment audit] Trim chat send and model ownership explanations [skip ci]

* [comment audit] Shorten transcript ownership and send recovery comments [skip ci]

* [comment audit] Simplify native chat composer and transcript hook comments [skip ci]

* [comment audit] Shorten native chat scroll and structured session explanations [skip ci]

* [comment audit] Trim workspace picker and onboarding commentary [skip ci]

* [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci]

* [comment audit] Trim sidebar and session history explanations [skip ci]

* [comment audit] Condense session resume and review checks comments [skip ci]

* [comment audit] Shorten checks state and file explorer refresh comments [skip ci]

* [comment audit] Trim plugin bridge and source-control action rationale [skip ci]

* [comment audit] Trim source-control listing and review rationale [skip ci]

* [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci]

* [comment audit] Condense Settings account and appearance rationale [skip ci]

* [comment audit] Trim pairing and repository Settings explanations [skip ci]

* [comment audit] Condense Settings search SSH and terminal safeguards [skip ci]

* [comment audit] Shorten Settings voice and provider ownership comments [skip ci]

* [comment audit] Condense Settings draft persistence and host-state rationale [skip ci]

* [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci]

* [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci]

* [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci]

* [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci]

* [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci]

* [comment audit] Prune focus-read baseline after comment cleanup

* [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci]

* [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci]

* [comment audit] Clarify viewport geometry and skill update safeguards [skip ci]

* [comment audit] Tighten skill inventory, usage and host status comments [skip ci]

* [comment audit] Clarify usage ownership and resource kill safeguards [skip ci]

* [comment audit] Tighten tab selection, rename and search contracts [skip ci]

* [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci]

* [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci]

* [comment audit] Tighten provider loading and terminal recovery comments [skip ci]

* [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci]

* [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci]

* [comment audit] Tighten PTY startup and replay explanations [skip ci]

* [comment audit] Clarify PTY identity and delivery ownership [skip ci]

* [comment audit] Shorten remote reconnect and input replay rationale [skip ci]

* [comment audit] Condense terminal parking clipboard and file link comments [skip ci]

* [comment audit] Clarify IME ownership and trim trace history [skip ci]

* [comment audit] Shorten pane recovery and parked watcher explanations [skip ci]

* [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci]

* [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci]

* [comment audit] Trim renderer lifecycle and menu rationale [skip ci]

* [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci]

* [comment audit] Clarify renderer hook evidence and source ownership [skip ci]

* [comment audit] Tighten IPC ownership and reconnect explanations [skip ci]

* [comment audit] Trim renderer focus, paste and attention comments [skip ci]

* [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci]

* [comment audit] Trim agent launch, resume and ownership commentary [skip ci]

* [comment audit] Shorten account, browser and editor comments [skip ci]

* [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci]

* [comment audit] Condense launch recovery and editor tokenization comments [skip ci]

* [comment audit] Condense workspace selection and terminal pane rationale [skip ci]

* [comment audit] Condense terminal fitting and rendering recovery comments [skip ci]

* [comment audit] Condense terminal input and host routing explanations [skip ci]

* [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci]

* [comment audit] Condense structured launch and terminal link explanations [skip ci]

* [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci]

* [comment audit] Condense session persistence and workspace activation rationale [skip ci]

* [comment audit] Condense workspace routing and browser ownership rationale [skip ci]

* [comment audit] Condense mirror recovery and layout authority rationale [skip ci]

* [comment audit] Condense runtime transport and file safety rationale [skip ci]

* [comment audit] Condense runtime graph and structured session rationale [skip ci]

* [comment audit] Condense browser creation and remote tab recovery rationale [skip ci]

* [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci]

* [comment audit] Condense frame, startup and provider cache rationale [skip ci]

* [comment audit] Condense host twin and agent lifecycle rationale [skip ci]

* [comment audit] Condense browser authority and editor cleanup rationale [skip ci]

* [comment audit] Condense editor buffer identity and review cache rationale [skip ci]

* [comment audit] Condense provider lifetime and repository ownership rationale [skip ci]

* [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci]

* [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci]

* [comment audit] Condense cleanup ownership and listing admission rationale [skip ci]

* [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci]

* [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci]

* [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci]

* [comment audit] Condense cloud rollout and assignment safety rationale [skip ci]

* [comment audit] Condense relay session and database recovery rationale [skip ci]

* [comment audit] Condense relay placement and protocol compatibility rationale [skip ci]

* [comment audit] Condense build and packaging constraints [skip ci]

* [comment audit] Condense CI gates and validation isolation rationale [skip ci]

* [comment audit] Condense catalog identity and browser validation rationale [skip ci]

* [comment audit] Condense mobile browser and frame-budget rationale [skip ci]

* [comment audit] Shorten mobile route and browser test explanations [skip ci]

* [comment audit] Condense editor and session seam test rationale [skip ci]

* [comment audit] Trim session and terminal closure history [skip ci]

* [comment audit] Shorten terminal browser and census explanations [skip ci]

* [comment audit] Preserve root-only E2E diagnostic baseline

* [comment audit] Condense mobile seam and HTML preview test rationale [skip ci]

* [comment audit] Condense preview instrumentation and render harness rationale [skip ci]

* [comment audit] Condense bundle contracts and native-build constraints [skip ci]

* [comment audit] Shorten native packaging and CI routing rationale [skip ci]

* [comment audit] Condense release tooling and benchmark constraints [skip ci]

* [comment audit] Condense packaging and platform gate rationale [skip ci]

* [comment audit] Shorten mobile route and history rationale [skip ci]

* [comment audit] Condense mobile browser and component rationale [skip ci]

* [comment audit] Shorten drawer and workspace-form rationale [skip ci]

* [comment audit] Trim mobile review and editor-document explanations [skip ci]

* [comment audit] Condense editor lifecycle and Markdown explanations [skip ci]

* [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci]

* [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci]

* [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci]

* [comment audit] Condense bridge stream, native request and audio rationale [skip ci]

* [comment audit] Reduce bridge schema and page-client commentary [skip ci]

* [comment audit] Tighten mobile page bridge contracts [skip ci]

* [comment audit] Clarify mobile cache and session constraints [skip ci]

* [comment audit] Condense mobile route and lifecycle rationale [skip ci]

* [comment audit] Tighten mobile shell hook timing rationale [skip ci]

* [comment audit] Clarify route handoff and notification compatibility [skip ci]

* [comment audit] Clarify push registration and dictation cleanup constraints [skip ci]

* [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci]

* [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci]

* [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci]

* [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci]

* [comment audit] Tighten stream replay and queued session ownership rationale [skip ci]

* [comment audit] Condense mobile composer and reply-schema constraints [skip ci]

* [comment audit] Clarify mobile transcript recovery and session ownership [skip ci]

* [comment audit] Clarify mobile queue and source-control compatibility [skip ci]

* [comment audit] Condense storage and task launch constraints [skip ci]

* [comment audit] Clarify task schemas and terminal document ownership [skip ci]

* [comment audit] Tighten terminal input and viewport rationale [skip ci]

* [comment audit] Shorten terminal and RPC recorder contracts [skip ci]

* [comment audit] Condense recorder engine and connection contracts [skip ci]

* [comment audit] Shorten host credential and relay recovery comments [skip ci]

* [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci]

* [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci]

* [comment audit] Condense catalog and relay entry contracts [skip ci]

* [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci]

* [comment audit] Condense WSL relay and E2E regression rationale [skip ci]

* [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci]

* [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci]

* [comment audit] Shorten layout oracle and regression explanations [skip ci]

* [comment audit] Condense paired recovery and ownership regression contracts [skip ci]

* [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci]

* [comment audit] Condense terminal rendering and IME regression rationale [skip ci]

* [comment audit] Shorten terminal recovery and benchmark contracts [skip ci]

* [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci]

* [comment audit] Condense workflow routing and release rationale [skip ci]

* [comment audit] Condense mobile security and installer contracts [skip ci]

* [comment audit] Shorten native rationale and stylesheet workarounds [skip ci]

* [comment audit] Shorten Windows visibility probe rationale [skip ci]

* [comment audit] Condense embedded release and signing rationale [skip ci]

* [comment audit] Retain current main test behavior in final reconciliation [skip ci]

* [comment audit] Complete final comment review across current source inventory

* [comment audit] Handle consolidated audit reports before final CI

* [comment audit] Preserve credential storage census detail [skip ci]

* [comment audit] Scale broad changed E2E selections with verified timing shards

* [comment audit] Align E2E assertions with browser close and settled session metadata

* [comment audit] Match existing E2Es to current resource and windowing contracts

* [comment audit] Observe the shared server outage notice in reconnect coverage

* [comment audit] Make existing renderer probes measure settled tab and PTY work

* [comment audit] Align palette E2E selector with task search

* [comment audit] Refresh remaining palette search selectors

* [comment audit] Keep selector correction within selected audit specs

* [comment audit] Await emoji fixture settings inside renderer evaluation

* [comment audit] Cancel fixture fit retries between terminal tests

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-25 04:05:46 -07:00

478 lines
16 KiB
JavaScript

import fs from 'node:fs'
import path from 'node:path'
import process from 'node:process'
import { pathToFileURL } from 'node:url'
import ts from 'typescript-api'
import {
diffCounts,
formatCountBaseline,
listTrackedFiles,
parseCountBaseline,
pruneCountBaseline,
totalCount
} from './ratchet-baseline.mjs'
// Ratchet layout writers downward: main Store/session-partition writes and renderer layout/selection keys/spreads.
// Exclude existing-entry content updates; shorthand counts only in store writes, and deleted symbols stay compiler-owned.
// Partition fields of the saved workspace session (census class 1).
const SESSION_PARTITION_FIELDS = [
'tabsByWorktree',
'terminalLayoutsByTabId',
'unifiedTabs',
'tabGroups',
'tabGroupLayouts',
'activeGroupIdByWorktree',
'activeTabIdByWorktree',
'activeWorktreeId',
'openFilesByWorktree',
'browserTabsByWorktree',
'activeBrowserTabIdByWorktree',
'activeFileIdByWorktree',
'activeTabTypeByWorktree',
'tabBarOrderByWorktree',
'sleepingAgentSessionsByPaneKey',
'terminalPtyIncarnationsByPaneKey',
'defaultTerminalTabsAppliedByWorktreeId',
'lastVisitedAtByWorktreeId',
'browserUrlHistory'
]
const SESSION_FIELDS = ['workspaceSession', 'workspaceSessionsByHostId']
// Tab and pane-layout fields edited in place inside a partition (census class 1, third search).
const SESSION_TAB_FIELDS = [
'ptyId',
'ptyIdsByLeafId',
'customTitle',
'titlesByLeafId',
'buffersByLeafId',
'activeLeafId'
]
// Window layout fields of acceptance 1 and the per-view selection fields (census class 2).
const RENDERER_LAYOUT_FIELDS = new Set([
'tabsByWorktree',
'terminalLayoutsByTabId',
'tabBarOrderByWorktree',
'unifiedTabsByWorktree',
'groupsByWorktree',
'layoutByWorktree',
'openFiles',
'browserTabsByWorktree',
'activeGroupIdByWorktree',
'activeTabIdByWorktree',
'activeTabId',
'activeFileIdByWorktree',
'activeFileId',
'activeBrowserTabIdByWorktree',
'activeBrowserTabId',
'activeTabTypeByWorktree',
'activeTabType',
'ptyIdsByTabId'
])
export const RATCHETS = [
{
id: 'main',
label: 'main-process layout writer(s)',
scanRoot: 'src/main',
baselinePath: 'config/main-layout-writer-baseline.txt',
// Count Store layout setter calls and method values, including internal partition writers.
writerNames: new Set([
'setWorkspaceSession',
'patchWorkspaceSession',
'stageWorkspaceSessionBeforeUnload',
'setWorkspaceSessionForWorktree',
'setForWorktree',
'persistPtyBinding',
'retirePtyBinding',
'moveTerminalLeafToNewTab',
'admitTerminalPane',
'withdrawTerminalPane',
'removeWorkspaceSessionHost',
'removeWorkspaceSessionStateForWorktree',
'setHostWorkspaceSession',
'setLocalWorkspaceSession',
'applyPtyBinding',
'removeWorkspaceSessionOwner',
'removeWorkspaceSessionOwners',
'removeWorkspaceSessionOwnerEverywhere',
'removeWorkspaceSessionOwnersEverywhere',
'removeWorkspaceSessionOwnerInPartition',
'deleteScannedSessionFieldsForOwners',
'removeRepoFromWorkspaceSession',
'removeRepoFromHostWorkspaceSessions',
'applyPreparedOrcadMigrationWorkspaceSession',
'applyPayloadToTarget',
'removeSourceRepo',
'clearSshRemotePtyBindingsForTarget',
'clearSshRemotePtyBindingsForLeases'
]),
assignedFields: new Set([
...SESSION_FIELDS,
...SESSION_PARTITION_FIELDS,
...SESSION_TAB_FIELDS,
'mobileClientTabSelectionsByDeviceId'
]),
// These names also key unrelated main objects, so only the session itself counts as a key.
keyedFields: new Set(SESSION_FIELDS),
entryContentFields: new Set(),
allowed: () => false,
header: [
'# Main-process writers of saved workspace layout, per file: calls of the Store layout',
'# setters, plus assignments, deletes and object keys that edit session partitions directly.',
'# This is a RATCHET: counts may only go DOWN. Layout moves to one runtime owner; do not add',
'# writers. Prune after removing writers: pnpm check:layout-writer-ratchets --prune'
]
},
{
id: 'renderer',
label: 'renderer layout write(s)',
scanRoot: 'src/renderer/src',
baselinePath: 'config/renderer-layout-writer-baseline.txt',
writerNames: new Set(),
assignedFields: RENDERER_LAYOUT_FIELDS,
keyedFields: RENDERER_LAYOUT_FIELDS,
// Mapping existing entries preserves membership/order; treat draft/status/URL edits as content only.
entryContentFields: new Set(['openFiles', 'browserTabsByWorktree']),
// The three writers the plan allows: applyFromRuntime, the frozen mirror's store patch and
// the frozen setters for remote-server workspaces.
allowed: (rel) =>
rel === 'src/renderer/src/store/workspace-layout-cache.ts' ||
rel === 'src/renderer/src/runtime/web-session-tabs-sync/store-patch.ts' ||
rel.startsWith('src/renderer/src/runtime/remote-workspace-frozen/'),
header: [
'# Renderer writes of the window layout and per-view selection fields, per file: assignments,',
'# deletes, object keys and string keys (computed-key writes). Same-name copies are reads.',
'# This is a RATCHET: counts may only GO DOWN. Layout comes from the runtime; send a command',
'# instead. Prune after removing writes: pnpm check:layout-writer-ratchets --prune'
]
}
]
// Census test filter: test, fixture and harness files are not product writers.
export function isScannedPath(rel) {
return (
/\.(ts|tsx)$/.test(rel) &&
!/\.(test|spec)\.|\/tests?\/|__tests__|test-support|fixture|harness|e2e\//.test(rel)
)
}
const ASSIGNMENT_OPERATORS = new Set([
ts.SyntaxKind.EqualsToken,
ts.SyntaxKind.QuestionQuestionEqualsToken,
ts.SyntaxKind.BarBarEqualsToken,
ts.SyntaxKind.AmpersandAmpersandEqualsToken
])
/** A string-literal key; a variable key (`exitCodes[ptyId]`) names no field. */
function literalKey(node) {
return ts.isStringLiteral(node) || ts.isNoSubstitutionTemplateLiteral(node) ? node.text : null
}
function staticName(node) {
if (ts.isIdentifier(node) || ts.isPrivateIdentifier(node)) {
return node.text
}
if (ts.isStringLiteral(node) || ts.isNoSubstitutionTemplateLiteral(node)) {
return node.text
}
if (ts.isComputedPropertyName(node)) {
return literalKey(node.expression)
}
return null
}
/** The field a write target (`a.b[c]!.d`) goes through, if any; root identifiers are locals. */
function targetedField(node, fields) {
let current = node
while (current) {
if (
ts.isParenthesizedExpression(current) ||
ts.isNonNullExpression(current) ||
ts.isAsExpression(current) ||
ts.isSatisfiesExpression(current)
) {
current = current.expression
} else if (ts.isPropertyAccessExpression(current)) {
if (fields.has(current.name.text)) {
return current.name.text
}
current = current.expression
} else if (ts.isElementAccessExpression(current)) {
const key = literalKey(current.argumentExpression)
if (key !== null && fields.has(key)) {
return key
}
current = current.expression
} else {
return null
}
}
return null
}
function unwrap(node) {
let current = node
while (
ts.isParenthesizedExpression(current) ||
ts.isNonNullExpression(current) ||
ts.isAsExpression(current) ||
ts.isSatisfiesExpression(current)
) {
current = current.expression
}
return current
}
/** An existing value read as-is: `s.openFiles`, `s.tabs[id] ?? []`. */
function isPlainRead(node) {
const current = unwrap(node)
if (ts.isIdentifier(current) || current.kind === ts.SyntaxKind.ThisKeyword) {
return true
}
if (ts.isPropertyAccessExpression(current) || ts.isElementAccessExpression(current)) {
return isPlainRead(current.expression)
}
if (
ts.isBinaryExpression(current) &&
(current.operatorToken.kind === ts.SyntaxKind.QuestionQuestionToken ||
current.operatorToken.kind === ts.SyntaxKind.BarBarToken)
) {
const right = unwrap(current.right)
const emptyLiteral =
(ts.isArrayLiteralExpression(right) && right.elements.length === 0) ||
(ts.isObjectLiteralExpression(right) && right.properties.length === 0)
return isPlainRead(current.left) && (emptyLiteral || isPlainRead(right))
}
return false
}
/** `list.map(…)`, or `{ ...map, [key]: list.map(…) }`: same entries in the same order. */
function keepsMembership(node) {
const value = unwrap(node)
if (ts.isCallExpression(value)) {
const callee = unwrap(value.expression)
return (
ts.isPropertyAccessExpression(callee) &&
callee.name.text === 'map' &&
isPlainRead(callee.expression)
)
}
if (ts.isObjectLiteralExpression(value)) {
return value.properties.every(
(property) =>
(ts.isSpreadAssignment(property) && isPlainRead(property.expression)) ||
(ts.isPropertyAssignment(property) && keepsMembership(property.initializer))
)
}
return false
}
const STORE_SET_CALLS = new Set(['set', 'setState'])
/** Whether an object literal is a store write: `set({ … })`, `set((s) => ({ … }))` or a writer call. */
function isPassedToWriter(objectLiteral, writerNames) {
let node = objectLiteral
for (;;) {
const parent = node.parent
if (
ts.isParenthesizedExpression(parent) ||
ts.isAsExpression(parent) ||
ts.isSatisfiesExpression(parent) ||
ts.isConditionalExpression(parent)
) {
node = parent
} else if (ts.isArrowFunction(parent) && parent.body === node) {
node = parent
} else if (ts.isReturnStatement(parent)) {
let fn = parent.parent
while (fn && !ts.isFunctionLike(fn)) {
fn = fn.parent
}
if (!fn) {
return false
}
node = fn
} else {
break
}
}
const call = node.parent
if (!ts.isCallExpression(call) || !call.arguments.includes(node)) {
return false
}
const callee = unwrap(call.expression)
const name = ts.isIdentifier(callee)
? callee.text
: ts.isPropertyAccessExpression(callee)
? callee.name.text
: null
return name !== null && (STORE_SET_CALLS.has(name) || writerNames.has(name))
}
/** `{ tabsByWorktree: s.tabsByWorktree }` copies a value under its own name: a selector read. */
function isSameNameCopy(property, name) {
let value = property.initializer
while (ts.isParenthesizedExpression(value) || ts.isNonNullExpression(value)) {
value = value.expression
}
return ts.isPropertyAccessExpression(value) && value.name.text === name
}
/** Layout writes in one file under one ratchet's rules. */
export function countLayoutWrites(sourceText, ratchet, fileName = 'file.tsx') {
const names = [...ratchet.writerNames, ...ratchet.assignedFields]
if (!names.some((name) => sourceText.includes(name))) {
return 0
}
const sourceFile = ts.createSourceFile(
fileName,
sourceText,
ts.ScriptTarget.Latest,
true,
fileName.endsWith('.tsx') ? ts.ScriptKind.TSX : ts.ScriptKind.TS
)
let count = 0
const visit = (node) => {
if (
(ts.isPropertyAccessExpression(node) && ratchet.writerNames.has(node.name.text)) ||
(ts.isCallExpression(node) &&
ts.isIdentifier(node.expression) &&
ratchet.writerNames.has(node.expression.text))
) {
count += 1
} else if (
ts.isBinaryExpression(node) &&
ASSIGNMENT_OPERATORS.has(node.operatorToken.kind) &&
targetedField(node.left, ratchet.assignedFields) !== null
) {
const field = targetedField(node.left, ratchet.assignedFields)
if (!(ratchet.entryContentFields.has(field) && keepsMembership(node.right))) {
count += 1
}
} else if (
ts.isDeleteExpression(node) &&
targetedField(node.expression, ratchet.assignedFields) !== null
) {
count += 1
} else if (
ts.isShorthandPropertyAssignment(node) &&
ratchet.keyedFields.has(node.name.text) &&
// A shorthand elsewhere passes a value on (`return { activeTabId, tabsByWorktree }`).
isPassedToWriter(node.parent, ratchet.writerNames)
) {
count += 1
} else if (ts.isPropertyAssignment(node)) {
const name = staticName(node.name)
if (
name !== null &&
ratchet.keyedFields.has(name) &&
!isSameNameCopy(node, name) &&
!(ratchet.entryContentFields.has(name) && keepsMembership(node.initializer))
) {
count += 1
}
} else if (
(ts.isStringLiteral(node) || ts.isNoSubstitutionTemplateLiteral(node)) &&
ratchet.keyedFields.has(node.text) &&
// Object keys and element reads are judged above; `'tabsByWorktree'` elsewhere feeds a
// computed-key write (`patch[key] = …`), which cannot be resolved statically.
!(ts.isPropertyAssignment(node.parent) && node.parent.name === node) &&
!ts.isComputedPropertyName(node.parent) &&
!(ts.isElementAccessExpression(node.parent) && node.parent.argumentExpression === node) &&
!ts.isLiteralTypeNode(node.parent)
) {
count += 1
}
ts.forEachChild(node, visit)
}
visit(sourceFile)
return count
}
export function collectCurrentCounts(ratchet, root = process.cwd()) {
const counts = new Map()
for (const rel of listTrackedFiles(root, [ratchet.scanRoot]).filter(isScannedPath)) {
if (ratchet.allowed(rel)) {
continue
}
let text
try {
text = fs.readFileSync(path.join(root, rel), 'utf8')
} catch {
// Deleted in the working tree but still tracked.
continue
}
const found = countLayoutWrites(text, ratchet, rel)
if (found > 0) {
counts.set(rel, found)
}
}
return counts
}
const ADVICE =
'Workspace layout is moving to one runtime owner; send a layout command instead of writing it here.'
export function main(root = process.cwd()) {
let failed = false
for (const ratchet of RATCHETS) {
const baselineFile = path.join(root, ratchet.baselinePath)
if (!fs.existsSync(baselineFile)) {
console.error(`::error::Missing ${ratchet.baselinePath}.`)
failed = true
continue
}
const current = collectCurrentCounts(ratchet, root)
const { grown, shrunk } = diffCounts(
current,
parseCountBaseline(fs.readFileSync(baselineFile, 'utf8'))
)
for (const { file, now, allowed } of grown) {
console.error(
`::error file=${file}::${now} ${ratchet.label}, baseline allows ${allowed}. ${ADVICE}`
)
}
// Why: a removal must not fail PRs that branched before it; only growth fails.
for (const { file, now, allowed } of shrunk) {
console.warn(
`::warning file=${file}::${now} ${ratchet.label}, baseline still allows ${allowed}. Run: pnpm check:layout-writer-ratchets --prune`
)
}
if (grown.length > 0) {
failed = true
} else {
console.log(
`Layout-writer ratchet (${ratchet.id}) OK — ${totalCount(current)} ${ratchet.label}.`
)
}
}
return failed ? 1 : 0
}
export function prune(root = process.cwd()) {
for (const ratchet of RATCHETS) {
const current = collectCurrentCounts(ratchet, root)
const kept = pruneCountBaseline(root, ratchet.baselinePath, ratchet.header, current)
console.log(`Pruned ${ratchet.baselinePath} to ${kept} ${ratchet.label}.`)
}
}
if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {
const root = process.cwd()
if (process.argv[2] === '--init') {
// One-time bootstrap of the baselines from today's tree.
for (const ratchet of RATCHETS) {
const counts = collectCurrentCounts(ratchet, root)
fs.writeFileSync(
path.join(root, ratchet.baselinePath),
formatCountBaseline(counts, ratchet.header)
)
}
} else if (process.argv[2] === '--prune') {
prune(root)
}
process.exit(main(root))
}