mirror of
https://github.com/stablyai/orca.git
synced 2026-11-02 10:08:13 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
263 lines
9.6 KiB
TypeScript
263 lines
9.6 KiB
TypeScript
import { afterEach, beforeAll, describe, expect, it } from 'vitest'
|
||
import { comparePublishedFieldOccurrences, publishedFieldNames } from './published-field-shape'
|
||
import { resolveBaselineReleaseRef, selectLatestStableReleaseTag } from './release-checkout'
|
||
import {
|
||
CrossVersionJourneyStall,
|
||
JOURNEY_INPUTS,
|
||
JOURNEY_STEPS,
|
||
runTerminalSkewJourney,
|
||
type JourneyRecord
|
||
} from './terminal-skew-journey'
|
||
import {
|
||
loadTerminalWireBuild,
|
||
withoutOpcodeSupport,
|
||
WORKING_TREE,
|
||
type TerminalWireBuild
|
||
} from './versioned-terminal-wire'
|
||
|
||
// Why: a cold CI run extracts the baseline checkout before the first journey.
|
||
const SUITE_TIMEOUT_MS = 180_000
|
||
// Last stable release before SnapshotStart began publishing terminal mode metadata.
|
||
const TERMINAL_MODE_METADATA_LEGACY_REF = 'v1.4.190'
|
||
|
||
// Name each journey’s expected frames; changed publication/acceptance needs review against remote-wire-compatibility.md.
|
||
const EXPECTED_JOURNEY_FRAMES = [
|
||
'C>H Subscribe',
|
||
'H>C SnapshotStart',
|
||
'H>C SnapshotChunk',
|
||
'H>C SnapshotEnd',
|
||
'C>H Input',
|
||
'H>C Output',
|
||
'C>H SnapshotRequest',
|
||
'H>C SnapshotStart',
|
||
'H>C SnapshotChunk',
|
||
'H>C SnapshotEnd',
|
||
'C>H Subscribe',
|
||
'H>C SnapshotStart',
|
||
'H>C SnapshotChunk',
|
||
'H>C SnapshotEnd',
|
||
'C>H Input',
|
||
'C>H Unsubscribe'
|
||
]
|
||
const SNAPSHOT_START_OCCURRENCES = ['initial', 'reveal', 'reconnect'] as const
|
||
|
||
let baselineRef: string
|
||
let current: TerminalWireBuild
|
||
let baseline: TerminalWireBuild
|
||
/** What a current host publishes to a client of its own version. */
|
||
let currentReference: JourneyRecord
|
||
/** What the baseline host publishes to a client of its own version. */
|
||
let baselineReference: JourneyRecord
|
||
let legacyTerminalModeMetadata: TerminalWireBuild
|
||
|
||
beforeAll(async () => {
|
||
baselineRef = resolveBaselineReleaseRef()
|
||
const [workingTree, baselineRelease, legacyRelease] = await Promise.all([
|
||
loadTerminalWireBuild(WORKING_TREE),
|
||
loadTerminalWireBuild(baselineRef),
|
||
loadTerminalWireBuild(TERMINAL_MODE_METADATA_LEGACY_REF)
|
||
])
|
||
current = workingTree
|
||
baseline = baselineRelease
|
||
legacyTerminalModeMetadata = legacyRelease
|
||
currentReference = await runTerminalSkewJourney({ hostBuild: current, clientBuild: current })
|
||
baselineReference = await runTerminalSkewJourney({ hostBuild: baseline, clientBuild: baseline })
|
||
}, SUITE_TIMEOUT_MS)
|
||
|
||
afterEach(() => {
|
||
// Each journey installs and removes its own window stub; fail loudly if one leaked.
|
||
expect(typeof globalThis.window).toBe('undefined')
|
||
})
|
||
|
||
function expectJourneyActuallyRan(record: JourneyRecord): void {
|
||
// Require an observable journey so an inert harness cannot make every pairing pass.
|
||
expect(record.completed).toEqual([...JOURNEY_STEPS])
|
||
expect(record.frameSequence).toEqual(EXPECTED_JOURNEY_FRAMES)
|
||
expect(record.subscribedEvents).toHaveLength(2)
|
||
expect(record.snapshotStarts).toHaveLength(3)
|
||
expect(record.missingRuntimeMethods).toEqual([])
|
||
}
|
||
|
||
function expectSnapshotStartFieldsRemainPublished(args: {
|
||
older: readonly Record<string, unknown>[]
|
||
newer: readonly Record<string, unknown>[]
|
||
olderLabel: string
|
||
newerLabel: string
|
||
}): void {
|
||
const skewByOccurrence = comparePublishedFieldOccurrences(args)
|
||
for (const [index, skew] of skewByOccurrence.entries()) {
|
||
const occurrence = SNAPSHOT_START_OCCURRENCES[index] ?? `occurrence ${index + 1}`
|
||
expect(
|
||
skew.removed,
|
||
`${args.newerLabel} stopped publishing ${occurrence} SnapshotStart fields ` +
|
||
`${args.olderLabel} publishes (it added: ${skew.added.join(', ') || 'nothing'})`
|
||
).toEqual([])
|
||
}
|
||
}
|
||
|
||
function expectWireCompatible(record: JourneyRecord): void {
|
||
// Refused opcodes drop silently, so assert the receiving decoder accepts every frame.
|
||
expect(record.rejected).toEqual([])
|
||
expect(record.clientErrors).toEqual([])
|
||
|
||
// Negotiate output-pause before opcode 16; drop notices require both peers to know the pause extension.
|
||
for (const event of record.subscribedEvents) {
|
||
expect(event.capabilities).toMatchObject({ outputPause: 1 })
|
||
}
|
||
|
||
// Input reached the process, before and after the reconnect.
|
||
expect(record.inputAtProcess).toEqual([JOURNEY_INPUTS.first, JOURNEY_INPUTS.second])
|
||
|
||
// Rule 3 — what the host publishes, as the client actually rendered it.
|
||
expect(record.snapshotsRendered[0]).toBe(JOURNEY_INPUTS.initialBuffer)
|
||
expect(record.dataRendered.join('')).toBe(JOURNEY_INPUTS.output)
|
||
expect(record.revealSnapshot?.data).toBe(
|
||
`${JOURNEY_INPUTS.initialBuffer}${JOURNEY_INPUTS.output}`
|
||
)
|
||
expect(record.revealSnapshot).toMatchObject({ cols: 120, rows: 40 })
|
||
for (const start of record.snapshotStarts) {
|
||
expect(start).toMatchObject({ kind: 'scrollback', cols: 120, rows: 40, source: 'headless' })
|
||
}
|
||
}
|
||
|
||
describe('cross-version remote terminal wire', () => {
|
||
it('ignores legacy, mobile, and prerelease tags when selecting the baseline', () => {
|
||
expect(
|
||
selectLatestStableReleaseTag([
|
||
'v799',
|
||
'mobile-v9.0.0',
|
||
'v1.4.177-rc.3',
|
||
'v1.4.175',
|
||
'v1.4.176'
|
||
])
|
||
).toBe('v1.4.176')
|
||
})
|
||
|
||
it(
|
||
'skews current code against a real published release',
|
||
() => {
|
||
expect(baselineRef).toMatch(/^v?\d/)
|
||
expect(baseline.revision).toMatch(/^[0-9a-f]{40}$/)
|
||
expect(baseline.revision).not.toBe(current.revision)
|
||
},
|
||
SUITE_TIMEOUT_MS
|
||
)
|
||
|
||
it('current client against current server completes the journey, and is the reference for a current host', () => {
|
||
expectJourneyActuallyRan(currentReference)
|
||
expectWireCompatible(currentReference)
|
||
for (const event of currentReference.subscribedEvents) {
|
||
expect(event.capabilities).toEqual({ outputPause: 1, outputPauseDropNotice: 1 })
|
||
}
|
||
expect(currentReference.snapshotStarts).toEqual([
|
||
expect.objectContaining({ alternateScreen: false, terminalOwner: 'shell' }),
|
||
expect.objectContaining({ alternateScreen: false, terminalOwner: 'shell' }),
|
||
expect.objectContaining({ alternateScreen: false, terminalOwner: 'shell' })
|
||
])
|
||
})
|
||
|
||
it('old client against old server completes the journey, and is the reference for an old host', () => {
|
||
expect(baselineReference.hostRevision).toBe(baseline.revision)
|
||
expect(baselineReference.clientRevision).toBe(baseline.revision)
|
||
expectJourneyActuallyRan(baselineReference)
|
||
expectWireCompatible(baselineReference)
|
||
for (const start of baselineReference.snapshotStarts) {
|
||
expect(publishedFieldNames(start).length).toBeGreaterThan(4)
|
||
}
|
||
})
|
||
|
||
it(
|
||
'old client against new server completes the journey',
|
||
async () => {
|
||
const record = await runTerminalSkewJourney({ hostBuild: current, clientBuild: baseline })
|
||
expect(record.clientRevision).toBe(baseline.revision)
|
||
expectJourneyActuallyRan(record)
|
||
expectWireCompatible(record)
|
||
expect(record.snapshotStarts).toEqual(currentReference.snapshotStarts)
|
||
},
|
||
SUITE_TIMEOUT_MS
|
||
)
|
||
|
||
it(
|
||
'new client against old server completes the journey',
|
||
async () => {
|
||
const record = await runTerminalSkewJourney({ hostBuild: baseline, clientBuild: current })
|
||
expect(record.hostRevision).toBe(baseline.revision)
|
||
expectJourneyActuallyRan(record)
|
||
expectWireCompatible(record)
|
||
expect(record.snapshotStarts).toEqual(baselineReference.snapshotStarts)
|
||
},
|
||
SUITE_TIMEOUT_MS
|
||
)
|
||
|
||
it('adds SnapshotStart fields rather than dropping ones the old host still publishes', () => {
|
||
expectSnapshotStartFieldsRemainPublished({
|
||
older: baselineReference.snapshotStarts,
|
||
newer: currentReference.snapshotStarts,
|
||
olderLabel: baselineRef,
|
||
newerLabel: 'current code'
|
||
})
|
||
})
|
||
|
||
it('detects a field removed from only the reveal SnapshotStart occurrence', () => {
|
||
const mutated = currentReference.snapshotStarts.map((start) => ({ ...start }))
|
||
const revealIndex = SNAPSHOT_START_OCCURRENCES.indexOf('reveal')
|
||
const reveal = mutated[revealIndex]
|
||
if (!reveal) {
|
||
throw new Error('The terminal journey did not publish a reveal SnapshotStart')
|
||
}
|
||
expect(reveal).toHaveProperty('seq')
|
||
delete reveal.seq
|
||
expect(() =>
|
||
expectSnapshotStartFieldsRemainPublished({
|
||
older: currentReference.snapshotStarts,
|
||
newer: mutated,
|
||
olderLabel: 'current reference',
|
||
newerLabel: 'current mutation'
|
||
})
|
||
).toThrow(/reveal SnapshotStart fields.*seq/)
|
||
})
|
||
|
||
it(
|
||
'still fails a pairing whose peer cannot decode an opcode the other side sends',
|
||
async () => {
|
||
const inputOpcode = Number(current.codec.TerminalStreamOpcode.Input)
|
||
const stall = await runTerminalSkewJourney({
|
||
hostBuild: withoutOpcodeSupport(current, 'Input'),
|
||
clientBuild: current,
|
||
barrierTimeoutMs: 2_000
|
||
}).then(
|
||
() => null,
|
||
(error: unknown) => error
|
||
)
|
||
expect(stall).toBeInstanceOf(CrossVersionJourneyStall)
|
||
const stalled = stall as CrossVersionJourneyStall
|
||
expect(stalled.step).toBe('input-reaches-process')
|
||
expect(stalled.record.completed).not.toContain('input-reaches-process')
|
||
expect(stalled.record.inputAtProcess).toEqual([])
|
||
expect(stalled.record.rejected).toContainEqual(
|
||
expect.objectContaining({ direction: 'client-to-host', rawOpcode: inputOpcode })
|
||
)
|
||
},
|
||
SUITE_TIMEOUT_MS
|
||
)
|
||
|
||
it(
|
||
'new client handles a release without terminal mode metadata',
|
||
async () => {
|
||
const record = await runTerminalSkewJourney({
|
||
hostBuild: legacyTerminalModeMetadata,
|
||
clientBuild: current
|
||
})
|
||
expect(record.hostLabel).toBe(TERMINAL_MODE_METADATA_LEGACY_REF)
|
||
expectJourneyActuallyRan(record)
|
||
expectWireCompatible(record)
|
||
for (const start of record.snapshotStarts) {
|
||
expect(start).not.toHaveProperty('terminalOwner')
|
||
expect(start).not.toHaveProperty('alternateScreen')
|
||
}
|
||
},
|
||
SUITE_TIMEOUT_MS
|
||
)
|
||
})
|