mirror of
https://github.com/stablyai/orca.git
synced 2026-11-01 01:27:35 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
511 lines
20 KiB
TypeScript
511 lines
20 KiB
TypeScript
// #8013: build isolated large repos and measure real git scan → line stats → IPC → store → rendered rows.
|
||
// Record scan/render time, payload size, lag, DOM count and repeated-poll heap growth; ORCA_LARGE_FILE_COUNT selects scale.
|
||
import type { ElectronApplication, Page } from '@stablyai/playwright-test'
|
||
import { test, expect } from './helpers/orca-app'
|
||
import { waitForSessionReady } from './helpers/store'
|
||
import {
|
||
hasCapturedGitStatusRetry,
|
||
installGitStatusRetryBarrier,
|
||
restoreGitStatusRetryHandler
|
||
} from './helpers/git-status-retry-barrier'
|
||
import {
|
||
createLargeFileCountRepo,
|
||
removeLargeFileCountRepo,
|
||
removeLargeFileCountUntrackedTree
|
||
} from './large-file-count-fixtures'
|
||
import { DEFAULT_GIT_STATUS_LIMIT } from '../../src/shared/git-status-limit'
|
||
import { RIGHT_SIDEBAR_MIN_WIDTH } from '../../src/renderer/src/components/right-sidebar/right-sidebar-width'
|
||
|
||
// A blocking stall over 1s matches the reported unresponsive UI.
|
||
const MAX_EVENT_LOOP_LAG_MS = 1_000
|
||
// Repeat identical status cycles to catch unbounded growth, allowing GC timing headroom.
|
||
const MAX_HEAP_GROWTH_PER_CYCLE_MB = 75
|
||
|
||
// Virtualization must bound mounts to viewport plus overscan, independent of change count.
|
||
const MAX_MOUNTED_ROWS = 200
|
||
const MAX_CAPPED_STATUS_PAYLOAD_BYTES = 200_000
|
||
|
||
type LoadMeasurement = {
|
||
entryCount: number
|
||
didHitLimit: boolean
|
||
scanMs: number
|
||
rescanMs: number
|
||
payloadBytes: number
|
||
renderMs: number
|
||
renderedRows: number
|
||
maxLagMs: number
|
||
p95LagMs: number
|
||
domNodeCount: number
|
||
heapUsedMbAfterRender: number
|
||
heapUsedMbPerCycle: number[]
|
||
cycleMaxLagMs: number[]
|
||
}
|
||
|
||
async function addAndActivateRepo(orcaPage: Page, repoPath: string): Promise<string> {
|
||
const repoId = await orcaPage.evaluate(async (pathToRepo: string) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is not available')
|
||
}
|
||
const addedRepo = await store.getState().addRepoPath(pathToRepo)
|
||
if (!addedRepo) {
|
||
throw new Error(`isolated repo not found: ${pathToRepo}`)
|
||
}
|
||
return addedRepo.id
|
||
}, repoPath)
|
||
|
||
// Poll async worktree scan state even after fetchWorktrees resolves.
|
||
await expect
|
||
.poll(
|
||
() =>
|
||
orcaPage.evaluate(async (targetRepoId: string) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
return 0
|
||
}
|
||
await store.getState().fetchWorktrees(targetRepoId)
|
||
return store.getState().worktreesByRepo[targetRepoId]?.length ?? 0
|
||
}, repoId),
|
||
{ timeout: 30_000, message: 'isolated large-file-count worktree did not load' }
|
||
)
|
||
.toBeGreaterThan(0)
|
||
|
||
const worktreeId = await orcaPage.evaluate(
|
||
({ targetRepoId, pathToRepo }) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is not available')
|
||
}
|
||
const state = store.getState()
|
||
const worktrees = state.worktreesByRepo[targetRepoId] ?? []
|
||
const worktree = worktrees.find((entry) => entry.path === pathToRepo) ?? worktrees[0]
|
||
if (!worktree) {
|
||
throw new Error(`isolated worktree not found: ${pathToRepo}`)
|
||
}
|
||
state.setActiveRepo(targetRepoId)
|
||
state.setActiveWorktree(worktree.id)
|
||
state.setRightSidebarOpen(true)
|
||
state.setRightSidebarTab('source-control')
|
||
return worktree.id
|
||
},
|
||
{ targetRepoId: repoId, pathToRepo: repoPath }
|
||
)
|
||
|
||
// Wait for the visible panel after async repo routing; clicking an already-active button measures Playwright stability instead.
|
||
const sourceControlButton = orcaPage.getByRole('button', { name: /^Source Control/ })
|
||
await expect(sourceControlButton).toBeVisible()
|
||
await expect
|
||
.poll(() => orcaPage.evaluate(() => window.__store?.getState().rightSidebarTab))
|
||
.toBe('source-control')
|
||
await expect(orcaPage.getByRole('button', { name: 'Filter files by name' })).toBeVisible()
|
||
|
||
return worktreeId
|
||
}
|
||
|
||
async function unregisterLargeFileCountRepos(
|
||
orcaPage: Page,
|
||
repoPaths: readonly string[]
|
||
): Promise<void> {
|
||
// Remove projects through product actions so PTYs/watchers start shutting down before Electron.
|
||
for (const repoPath of repoPaths) {
|
||
await orcaPage.evaluate(async (pathToRepo) => {
|
||
const store = window.__store
|
||
const repo = store?.getState().repos.find((entry) => entry.path === pathToRepo)
|
||
if (repo) {
|
||
await store?.getState().removeProject(repo.id, { hostId: 'local' })
|
||
}
|
||
}, repoPath)
|
||
}
|
||
}
|
||
|
||
// Run the poll’s exact status→store path; concurrent built-in polls produce identical entries that dedupe.
|
||
async function measureSourceControlLoad(
|
||
orcaPage: Page,
|
||
args: { worktreeId: string; repoPath: string; expectedRows: number; pollCycles: number }
|
||
): Promise<LoadMeasurement> {
|
||
return await orcaPage.evaluate(async ({ worktreeId, repoPath, expectedRows, pollCycles }) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is not available')
|
||
}
|
||
|
||
const lagSamples: number[] = []
|
||
const probeIntervalMs = 50
|
||
let lastTick = performance.now()
|
||
const probe = window.setInterval(() => {
|
||
const now = performance.now()
|
||
lagSamples.push(Math.max(0, now - lastTick - probeIntervalMs))
|
||
lastTick = now
|
||
}, probeIntervalMs)
|
||
|
||
const readHeapMb = (): number => {
|
||
const memory = (performance as unknown as { memory?: { usedJSHeapSize: number } }).memory
|
||
return memory ? memory.usedJSHeapSize / (1024 * 1024) : -1
|
||
}
|
||
|
||
try {
|
||
const scanStart = performance.now()
|
||
const status = await window.api.git.status({ worktreePath: repoPath })
|
||
const scanMs = performance.now() - scanStart
|
||
const payloadBytes = JSON.stringify(status).length
|
||
|
||
// Time first rows, not all rows: virtualization intentionally leaves most unmounted.
|
||
const firstRowsTarget = Math.min(expectedRows, 30)
|
||
const renderStart = performance.now()
|
||
store.getState().setGitStatus(worktreeId, status)
|
||
let renderedRows = 0
|
||
while (performance.now() - renderStart < 60_000) {
|
||
renderedRows = document.querySelectorAll('[data-testid="source-control-entry"]').length
|
||
if (renderedRows >= firstRowsTarget) {
|
||
break
|
||
}
|
||
await new Promise((resolve) => window.setTimeout(resolve, 50))
|
||
}
|
||
const renderMs = performance.now() - renderStart
|
||
// Settle so the lag probe captures post-render layout/paint stalls too.
|
||
await new Promise((resolve) => window.setTimeout(resolve, 1_000))
|
||
renderedRows = document.querySelectorAll('[data-testid="source-control-entry"]').length
|
||
const heapUsedMbAfterRender = readHeapMb()
|
||
|
||
// Repeat real scans/store arrays to expose ongoing memory growth, not just first-load allocation.
|
||
const heapUsedMbPerCycle: number[] = []
|
||
const cycleMaxLagMs: number[] = []
|
||
let rescanMs = 0
|
||
for (let cycle = 0; cycle < pollCycles; cycle += 1) {
|
||
const cycleLagStart = lagSamples.length
|
||
const cycleScanStart = performance.now()
|
||
const cycleStatus = await window.api.git.status({ worktreePath: repoPath })
|
||
if (cycle === 0) {
|
||
// The first rescan isolates warm mtime-cache cost.
|
||
rescanMs = performance.now() - cycleScanStart
|
||
}
|
||
store.getState().setGitStatus(worktreeId, cycleStatus)
|
||
await new Promise((resolve) => window.setTimeout(resolve, 500))
|
||
heapUsedMbPerCycle.push(readHeapMb())
|
||
cycleMaxLagMs.push(Math.max(0, ...lagSamples.slice(cycleLagStart)))
|
||
}
|
||
|
||
const sorted = [...lagSamples].sort((a, b) => a - b)
|
||
return {
|
||
entryCount: status.entries.length,
|
||
didHitLimit: status.didHitLimit === true,
|
||
scanMs,
|
||
rescanMs,
|
||
payloadBytes,
|
||
renderMs,
|
||
renderedRows,
|
||
maxLagMs: sorted.length ? (sorted.at(-1) ?? 0) : 0,
|
||
p95LagMs: sorted.length ? sorted[Math.floor(sorted.length * 0.95)] : 0,
|
||
domNodeCount: document.getElementsByTagName('*').length,
|
||
heapUsedMbAfterRender,
|
||
heapUsedMbPerCycle,
|
||
cycleMaxLagMs
|
||
}
|
||
} finally {
|
||
window.clearInterval(probe)
|
||
}
|
||
}, args)
|
||
}
|
||
|
||
function logMeasurement(
|
||
label: string,
|
||
measurement: LoadMeasurement & { rendererWorkingSetMb?: { before: number; after: number } }
|
||
): void {
|
||
console.log(`[large-file-count] ${label} ${JSON.stringify(measurement)}`)
|
||
}
|
||
|
||
// Measure all renderers’ OS working set too; JS heap misses native/DOM memory from excessive mounts.
|
||
async function readRendererWorkingSetMb(electronApp: ElectronApplication): Promise<number> {
|
||
return await electronApp.evaluate(({ app }) => {
|
||
let totalKb = 0
|
||
for (const metric of app.getAppMetrics()) {
|
||
if (metric.type === 'Tab') {
|
||
totalKb += metric.memory.workingSetSize
|
||
}
|
||
}
|
||
return totalKb / 1024
|
||
})
|
||
}
|
||
|
||
test.describe('Source Control large file count (#8013)', () => {
|
||
// Keep scales independent because every isolated app/repo failure is a useful data point.
|
||
test.use({ seedTestRepo: false })
|
||
|
||
test('a large untracked set under the status cap stays responsive', async ({
|
||
orcaPage,
|
||
electronApp,
|
||
registerPostElectronShutdownCleanup
|
||
}) => {
|
||
test.setTimeout(600_000)
|
||
const untrackedFiles = Number(process.env.ORCA_LARGE_FILE_COUNT ?? '950')
|
||
// ORCA_LARGE_FILE_BYTES exposes uncached line-stat I/O beyond the 2048-entry cache with realistic file sizes.
|
||
const untrackedFileBytes = Number(process.env.ORCA_LARGE_FILE_BYTES ?? '0')
|
||
const fixture = createLargeFileCountRepo({
|
||
trackedFiles: 100,
|
||
untrackedFiles,
|
||
untrackedFileBytes
|
||
})
|
||
registerPostElectronShutdownCleanup(() => removeLargeFileCountRepo(fixture.repoPath))
|
||
try {
|
||
await waitForSessionReady(orcaPage)
|
||
const worktreeId = await addAndActivateRepo(orcaPage, fixture.repoPath)
|
||
const workingSetBeforeMb = await readRendererWorkingSetMb(electronApp)
|
||
const measurement = await measureSourceControlLoad(orcaPage, {
|
||
worktreeId,
|
||
repoPath: fixture.repoPath,
|
||
expectedRows: untrackedFiles,
|
||
pollCycles: 3
|
||
})
|
||
const workingSetAfterMb = await readRendererWorkingSetMb(electronApp)
|
||
logMeasurement(`untracked=${untrackedFiles}`, {
|
||
...measurement,
|
||
rendererWorkingSetMb: { before: workingSetBeforeMb, after: workingSetAfterMb }
|
||
})
|
||
|
||
expect(measurement.didHitLimit).toBe(false)
|
||
expect(measurement.entryCount).toBeGreaterThanOrEqual(untrackedFiles)
|
||
expect(measurement.renderedRows).toBeGreaterThan(0)
|
||
// Reject mounts proportional to change count; keep only viewport plus overscan.
|
||
expect(measurement.renderedRows).toBeLessThan(MAX_MOUNTED_ROWS)
|
||
expect(measurement.maxLagMs).toBeLessThan(MAX_EVENT_LOOP_LAG_MS)
|
||
if (measurement.heapUsedMbPerCycle.length > 1) {
|
||
const first = measurement.heapUsedMbPerCycle[0]
|
||
const last = measurement.heapUsedMbPerCycle.at(-1) ?? first
|
||
expect(last - first).toBeLessThan(
|
||
MAX_HEAP_GROWTH_PER_CYCLE_MB * (measurement.heapUsedMbPerCycle.length - 1)
|
||
)
|
||
}
|
||
} finally {
|
||
await unregisterLargeFileCountRepos(orcaPage, [fixture.repoPath])
|
||
}
|
||
})
|
||
|
||
test('a large modified set under the status cap stays responsive', async ({
|
||
orcaPage,
|
||
electronApp,
|
||
registerPostElectronShutdownCleanup
|
||
}) => {
|
||
test.setTimeout(600_000)
|
||
const modifiedFiles = Number(process.env.ORCA_LARGE_FILE_COUNT ?? '750')
|
||
const fixture = createLargeFileCountRepo({ trackedFiles: modifiedFiles, modifiedFiles })
|
||
registerPostElectronShutdownCleanup(() => removeLargeFileCountRepo(fixture.repoPath))
|
||
try {
|
||
await waitForSessionReady(orcaPage)
|
||
const worktreeId = await addAndActivateRepo(orcaPage, fixture.repoPath)
|
||
const workingSetBeforeMb = await readRendererWorkingSetMb(electronApp)
|
||
const measurement = await measureSourceControlLoad(orcaPage, {
|
||
worktreeId,
|
||
repoPath: fixture.repoPath,
|
||
expectedRows: modifiedFiles,
|
||
pollCycles: 3
|
||
})
|
||
const workingSetAfterMb = await readRendererWorkingSetMb(electronApp)
|
||
logMeasurement(`modified=${modifiedFiles}`, {
|
||
...measurement,
|
||
rendererWorkingSetMb: { before: workingSetBeforeMb, after: workingSetAfterMb }
|
||
})
|
||
|
||
expect(measurement.didHitLimit).toBe(false)
|
||
expect(measurement.entryCount).toBeGreaterThanOrEqual(modifiedFiles)
|
||
expect(measurement.renderedRows).toBeGreaterThan(0)
|
||
expect(measurement.renderedRows).toBeLessThan(MAX_MOUNTED_ROWS)
|
||
expect(measurement.maxLagMs).toBeLessThan(MAX_EVENT_LOOP_LAG_MS)
|
||
} finally {
|
||
await unregisterLargeFileCountRepos(orcaPage, [fixture.repoPath])
|
||
}
|
||
})
|
||
|
||
test('a change set over the status cap degrades to the too-many-changes state', async ({
|
||
orcaPage,
|
||
electronApp,
|
||
registerPostElectronShutdownCleanup
|
||
}) => {
|
||
test.setTimeout(600_000)
|
||
const untrackedFiles = 12_000
|
||
const fixture = createLargeFileCountRepo({ untrackedFiles })
|
||
registerPostElectronShutdownCleanup(() => removeLargeFileCountRepo(fixture.repoPath))
|
||
try {
|
||
await waitForSessionReady(orcaPage)
|
||
await orcaPage.evaluate(() => {
|
||
const probe = { lastTick: performance.now(), maxLagMs: 0, timer: 0 }
|
||
probe.timer = window.setInterval(() => {
|
||
const now = performance.now()
|
||
probe.maxLagMs = Math.max(probe.maxLagMs, now - probe.lastTick - 50)
|
||
probe.lastTick = now
|
||
}, 50)
|
||
;(
|
||
window as unknown as {
|
||
__sourceControlActivationLagProbe?: typeof probe
|
||
}
|
||
).__sourceControlActivationLagProbe = probe
|
||
})
|
||
const activationStart = performance.now()
|
||
const worktreeId = await addAndActivateRepo(orcaPage, fixture.repoPath)
|
||
const activationMs = performance.now() - activationStart
|
||
const activationMaxLagMs = await orcaPage.evaluate(() => {
|
||
const target = window as unknown as {
|
||
__sourceControlActivationLagProbe?: {
|
||
maxLagMs: number
|
||
timer: number
|
||
}
|
||
}
|
||
const probe = target.__sourceControlActivationLagProbe
|
||
if (!probe) {
|
||
return -1
|
||
}
|
||
window.clearInterval(probe.timer)
|
||
delete target.__sourceControlActivationLagProbe
|
||
return probe.maxLagMs
|
||
})
|
||
console.log(
|
||
`[large-file-count] initial-activation ${JSON.stringify({ activationMs, activationMaxLagMs })}`
|
||
)
|
||
const workingSetBeforeMb = await readRendererWorkingSetMb(electronApp)
|
||
const measurement = await measureSourceControlLoad(orcaPage, {
|
||
worktreeId,
|
||
repoPath: fixture.repoPath,
|
||
// The capped payload still carries DEFAULT_GIT_STATUS_LIMIT entries;
|
||
// the panel may render them, but must stay responsive while doing so.
|
||
expectedRows: 0,
|
||
pollCycles: 1
|
||
})
|
||
const workingSetAfterMb = await readRendererWorkingSetMb(electronApp)
|
||
logMeasurement(`over-cap untracked=${untrackedFiles}`, {
|
||
...measurement,
|
||
rendererWorkingSetMb: { before: workingSetBeforeMb, after: workingSetAfterMb }
|
||
})
|
||
|
||
const tooManyChangesBanner = orcaPage.getByTestId('too-many-changes-banner')
|
||
await expect(tooManyChangesBanner).toBeVisible()
|
||
if (process.env.ORCA_LARGE_FILE_SCREENSHOT_PATH) {
|
||
// Narrowest supported sidebar is where the banner layout is worst.
|
||
await orcaPage.evaluate((minWidth) => {
|
||
window.__store?.getState().setRightSidebarWidth(minWidth)
|
||
document.documentElement.classList.add('dark')
|
||
}, RIGHT_SIDEBAR_MIN_WIDTH)
|
||
await tooManyChangesBanner.screenshot({
|
||
path: process.env.ORCA_LARGE_FILE_SCREENSHOT_PATH
|
||
})
|
||
}
|
||
|
||
expect(measurement.didHitLimit).toBe(true)
|
||
expect(measurement.entryCount).toBeLessThanOrEqual(DEFAULT_GIT_STATUS_LIMIT)
|
||
expect(measurement.payloadBytes).toBeLessThan(MAX_CAPPED_STATUS_PAYLOAD_BYTES)
|
||
expect(measurement.renderedRows).toBeLessThan(MAX_MOUNTED_ROWS)
|
||
expect(measurement.maxLagMs).toBeLessThan(MAX_EVENT_LOOP_LAG_MS)
|
||
expect(activationMaxLagMs).toBeLessThan(MAX_EVENT_LOOP_LAG_MS)
|
||
|
||
// didHitLimit must stop background polling from repeating huge scans.
|
||
const hugeState = await orcaPage.evaluate(
|
||
(wId) => window.__store?.getState().gitStatusHugeByWorktree?.[wId] ?? null,
|
||
worktreeId
|
||
)
|
||
expect(hugeState).not.toBeNull()
|
||
|
||
const retryButton = tooManyChangesBanner.getByRole('button', { name: 'Retry' })
|
||
await expect(retryButton).toBeVisible()
|
||
// Keep automatic refreshes from removing Retry before its real request starts.
|
||
await installGitStatusRetryBarrier(electronApp, fixture.repoPath)
|
||
try {
|
||
await retryButton.click()
|
||
await expect.poll(() => hasCapturedGitStatusRetry(electronApp)).toBe(true)
|
||
removeLargeFileCountUntrackedTree(fixture.repoPath)
|
||
} finally {
|
||
await restoreGitStatusRetryHandler(electronApp)
|
||
}
|
||
await expect(tooManyChangesBanner).not.toBeVisible()
|
||
await expect
|
||
.poll(() =>
|
||
orcaPage.evaluate(
|
||
(wId) => window.__store?.getState().gitStatusHugeByWorktree?.[wId] ?? null,
|
||
worktreeId
|
||
)
|
||
)
|
||
.toBeNull()
|
||
} finally {
|
||
await unregisterLargeFileCountRepos(orcaPage, [fixture.repoPath])
|
||
}
|
||
})
|
||
|
||
test('untracked line-stat cache stays effective up to the status cap', async ({
|
||
orcaPage,
|
||
registerPostElectronShutdownCleanup
|
||
}) => {
|
||
test.setTimeout(600_000)
|
||
// Compare warm sub-cap scales on this machine; a too-small full-result cache makes their ratio grow.
|
||
const fileBytes = 65_536
|
||
const smallRepo = createLargeFileCountRepo({
|
||
trackedFiles: 10,
|
||
untrackedFiles: 400,
|
||
untrackedFileBytes: fileBytes
|
||
})
|
||
registerPostElectronShutdownCleanup(() => removeLargeFileCountRepo(smallRepo.repoPath))
|
||
let largeRepo: ReturnType<typeof createLargeFileCountRepo> | null = null
|
||
try {
|
||
largeRepo = createLargeFileCountRepo({
|
||
trackedFiles: 10,
|
||
untrackedFiles: 800,
|
||
untrackedFileBytes: fileBytes
|
||
})
|
||
const largeRepoPath = largeRepo.repoPath
|
||
registerPostElectronShutdownCleanup(() => removeLargeFileCountRepo(largeRepoPath))
|
||
await waitForSessionReady(orcaPage)
|
||
|
||
const warmRescanPerFileMs = async (repoPath: string, files: number): Promise<number> => {
|
||
const worktreeId = await addAndActivateRepo(orcaPage, repoPath)
|
||
const measurement = await measureSourceControlLoad(orcaPage, {
|
||
worktreeId,
|
||
repoPath,
|
||
expectedRows: files,
|
||
pollCycles: 1
|
||
})
|
||
return measurement.rescanMs / files
|
||
}
|
||
|
||
const smallPerFileMs = await warmRescanPerFileMs(smallRepo.repoPath, 400)
|
||
const largePerFileMs = await warmRescanPerFileMs(largeRepo.repoPath, 800)
|
||
console.log(
|
||
`[large-file-count] line-stat-cache smallPerFileMs=${smallPerFileMs.toFixed(4)} largePerFileMs=${largePerFileMs.toFixed(4)} ratio=${(largePerFileMs / smallPerFileMs).toFixed(2)}`
|
||
)
|
||
expect(largePerFileMs).toBeLessThan(smallPerFileMs * 2)
|
||
} finally {
|
||
await unregisterLargeFileCountRepos(orcaPage, [
|
||
smallRepo.repoPath,
|
||
...(largeRepo ? [largeRepo.repoPath] : [])
|
||
])
|
||
}
|
||
})
|
||
|
||
test('a large clean repo (tracked files only) loads instantly', async ({
|
||
orcaPage,
|
||
electronApp,
|
||
registerPostElectronShutdownCleanup
|
||
}) => {
|
||
test.setTimeout(600_000)
|
||
const trackedFiles = Number(process.env.ORCA_LARGE_FILE_COUNT ?? '15000')
|
||
const fixture = createLargeFileCountRepo({ trackedFiles })
|
||
registerPostElectronShutdownCleanup(() => removeLargeFileCountRepo(fixture.repoPath))
|
||
try {
|
||
await waitForSessionReady(orcaPage)
|
||
const worktreeId = await addAndActivateRepo(orcaPage, fixture.repoPath)
|
||
const workingSetBeforeMb = await readRendererWorkingSetMb(electronApp)
|
||
const measurement = await measureSourceControlLoad(orcaPage, {
|
||
worktreeId,
|
||
repoPath: fixture.repoPath,
|
||
expectedRows: 0,
|
||
pollCycles: 2
|
||
})
|
||
const workingSetAfterMb = await readRendererWorkingSetMb(electronApp)
|
||
logMeasurement(`clean tracked=${trackedFiles}`, {
|
||
...measurement,
|
||
rendererWorkingSetMb: { before: workingSetBeforeMb, after: workingSetAfterMb }
|
||
})
|
||
|
||
expect(measurement.entryCount).toBe(0)
|
||
expect(measurement.maxLagMs).toBeLessThan(MAX_EVENT_LOOP_LAG_MS)
|
||
} finally {
|
||
await unregisterLargeFileCountRepos(orcaPage, [fixture.repoPath])
|
||
}
|
||
})
|
||
})
|