mirror of
https://github.com/stablyai/orca.git
synced 2026-11-04 11:07:42 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
373 lines
15 KiB
TypeScript
373 lines
15 KiB
TypeScript
import { cpSync, rmSync } from 'node:fs'
|
|
import path from 'node:path'
|
|
import type { ElectronApplication, Page } from '@stablyai/playwright-test'
|
|
import { expect, test } from './helpers/orca-app'
|
|
import { createRestartSession } from './helpers/orca-restart'
|
|
import { waitForSessionReady, waitForStartupWorktreeRefresh } from './helpers/store'
|
|
import {
|
|
cleanupDockerSshHostTarget,
|
|
DOCKER_SSH_HOST_REMOTE_REPO_PATH,
|
|
startDockerSshHostTarget
|
|
} from './helpers/docker-ssh-host-target'
|
|
import { seedRelayEraProfile } from './helpers/orcad-upgrade-profile'
|
|
import {
|
|
startSshRemoteOnlyBrowserFixture,
|
|
readSshRemoteOnlyRequests,
|
|
SSH_REMOTE_ONLY_ORIGIN,
|
|
SSH_REMOTE_ONLY_COOKIE_NAME,
|
|
SSH_REMOTE_ONLY_COOKIE_VALUE
|
|
} from './helpers/ssh-remote-only-browser-fixture'
|
|
import { createRetentionFixtureDirectory } from './helpers/host-created-terminal-retention-oracle'
|
|
import { toSshExecutionHostId } from '../../src/shared/execution-host'
|
|
import { DEFAULT_LOCAL_ORCA_PROFILE_ID } from '../../src/shared/orca-profiles'
|
|
import { deriveBrowserRoutePartition } from '../../src/main/browser/browser-route-identity'
|
|
import { sshExecutionHostStorageIdentity } from '../../src/main/browser/browser-execution-host-storage-identity'
|
|
import { reconnect } from './helpers/orcad-convert-flow'
|
|
import { navigateGuest } from './helpers/browser-split-guest-probes'
|
|
import { ORCAD_TEMPLATE, skipUnlessManagedDockerHost } from './helpers/orcad-managed-workspace'
|
|
import { getOrcadSshDeployment } from '../../src/shared/runtime-environments'
|
|
|
|
skipUnlessManagedDockerHost()
|
|
|
|
/** The partition a relay-era build kept this host's browser storage in (local-ssh-browser-partitions). */
|
|
function relayEraPartition(targetId: string): string {
|
|
return deriveBrowserRoutePartition({
|
|
orcaProfileId: DEFAULT_LOCAL_ORCA_PROFILE_ID,
|
|
browserProfileId: 'default',
|
|
authorityConnectionIdentity: JSON.stringify([
|
|
'orca-local-ssh-browser',
|
|
1,
|
|
DEFAULT_LOCAL_ORCA_PROFILE_ID
|
|
]),
|
|
executionHostIdentity: sshExecutionHostStorageIdentity(targetId)
|
|
}).partition
|
|
}
|
|
|
|
async function guestMarker(page: Page, tabId: string): Promise<unknown> {
|
|
return page.evaluate(async (id) => {
|
|
const guest = document.querySelector<Electron.WebviewTag>(
|
|
`[data-browser-overlay-tab-id="${id}"] webview`
|
|
)
|
|
try {
|
|
return await guest?.executeJavaScript('document.querySelector("#marker")?.textContent')
|
|
} catch {
|
|
return null
|
|
}
|
|
}, tabId)
|
|
}
|
|
|
|
test('retained and new browser tabs keep SSH routing and login cookies after managed conversion', async (// oxlint-disable-next-line no-empty-pattern -- Owns app launch.
|
|
{}, testInfo) => {
|
|
test.setTimeout(5 * 60_000)
|
|
const target = startDockerSshHostTarget(testInfo)
|
|
const scratch = createRetentionFixtureDirectory()
|
|
const template = path.join(scratch, 'template')
|
|
const session = createRestartSession(testInfo, { ORCA_ORCAD_TEMPLATE_PATH: template })
|
|
let app: ElectronApplication | null = null
|
|
try {
|
|
startSshRemoteOnlyBrowserFixture(target)
|
|
// The first launch only creates the profile the relay-era host is saved into.
|
|
const first = await session.launch()
|
|
app = first.app
|
|
await waitForSessionReady(first.page)
|
|
await session.close(first.app)
|
|
app = null
|
|
const remote = seedRelayEraProfile(
|
|
session.userDataDir,
|
|
{
|
|
label: `orcad browser routing E2E ${Date.now()}`,
|
|
host: target.host,
|
|
port: target.port,
|
|
username: 'root',
|
|
identityFile: target.identityFile,
|
|
identitiesOnly: true,
|
|
relayGracePeriodSeconds: 1
|
|
},
|
|
{ repoPath: DOCKER_SSH_HOST_REMOTE_REPO_PATH, folderPath: '/tmp' }
|
|
)
|
|
const launched = await session.launch()
|
|
app = launched.app
|
|
const page = launched.page
|
|
await waitForSessionReady(page)
|
|
// The browser tab a relay-era build left open on the saved host, never connected this launch.
|
|
const tabId = await page.evaluate(
|
|
({ worktreeId, url }) => {
|
|
const state = window.__store?.getState()
|
|
if (!state) {
|
|
throw new Error('Missing store')
|
|
}
|
|
// Not shown yet: it mounts once the user opens it after upgrading.
|
|
return state.createBrowserTab(worktreeId, url, {
|
|
title: 'Retained browser',
|
|
activate: false
|
|
}).id
|
|
},
|
|
{ worktreeId: remote.worktreeId, url: `${SSH_REMOTE_ONLY_ORIGIN}/login` }
|
|
)
|
|
await expect
|
|
.poll(
|
|
() =>
|
|
page.evaluate(
|
|
async ({ hostId, tabId }) =>
|
|
JSON.stringify(await window.api.session.get(hostId)).includes(tabId),
|
|
{ hostId: toSshExecutionHostId(remote.targetId), tabId }
|
|
),
|
|
{ timeout: 30_000, message: 'the retained browser tab never reached the host session' }
|
|
)
|
|
.toBe(true)
|
|
const cookieMarker = `cookie:${SSH_REMOTE_ONLY_COOKIE_NAME}=${SSH_REMOTE_ONLY_COOKIE_VALUE}`
|
|
// The login cookie a relay-era session left in that host's browser storage.
|
|
const partitionBefore = relayEraPartition(remote.targetId)
|
|
// Bind legacy storage before seeding cookies; unbound data is refused as browser_route_partition_binding_store_invalid.
|
|
const bound = await page.evaluate(
|
|
(targetId) =>
|
|
window.api.browser.prepareSshWorkspacePartition({
|
|
targetId,
|
|
browserProfileId: 'default',
|
|
skipProbe: true
|
|
}),
|
|
remote.targetId
|
|
)
|
|
expect(bound.partition).toBe(partitionBefore)
|
|
await app.evaluate(
|
|
async ({ session }, cookie) => {
|
|
const jar = session.fromPartition(cookie.partition).cookies
|
|
await jar.set({
|
|
url: cookie.url,
|
|
name: cookie.name,
|
|
value: cookie.value,
|
|
expirationDate: Math.floor(Date.now() / 1000) + 3600
|
|
})
|
|
await jar.flushStore()
|
|
},
|
|
{
|
|
partition: partitionBefore,
|
|
url: `${SSH_REMOTE_ONLY_ORIGIN}/`,
|
|
name: SSH_REMOTE_ONLY_COOKIE_NAME,
|
|
value: SSH_REMOTE_ONLY_COOKIE_VALUE
|
|
}
|
|
)
|
|
cpSync(ORCAD_TEMPLATE!, template, { recursive: true })
|
|
const server = await reconnect(page, remote.targetId)
|
|
console.log('[browser-conversion-connect]', server)
|
|
expect(JSON.parse(server)).toMatchObject({ kind: 'managed' })
|
|
const environments = await page.evaluate(() => window.api.runtimeEnvironments.list())
|
|
const environment = environments.find(
|
|
(entry) => getOrcadSshDeployment(entry)?.sshTargetId === remote.targetId
|
|
)
|
|
if (!environment) {
|
|
throw new Error('Missing managed environment')
|
|
}
|
|
await expect
|
|
.poll(
|
|
() =>
|
|
page.evaluate((worktreeId) => {
|
|
const state = window.__store?.getState()
|
|
return (
|
|
state?.repos.find((repo) =>
|
|
(state.worktreesByRepo[repo.id] ?? []).some(
|
|
(worktree) => worktree.id === worktreeId
|
|
)
|
|
)?.executionHostId ?? null
|
|
)
|
|
}, remote.worktreeId),
|
|
{ timeout: 60_000 }
|
|
)
|
|
.toMatch(/^runtime:/)
|
|
const retained = await page.evaluate((worktreeId) => {
|
|
const state = window.__store?.getState()
|
|
const tab = state?.browserTabsByWorktree[worktreeId]?.[0]
|
|
const repo = state?.repos.find((repo) =>
|
|
(state.worktreesByRepo[repo.id] ?? []).some((worktree) => worktree.id === worktreeId)
|
|
)
|
|
if (repo?.executionHostId) {
|
|
state?.setActiveWorktree(worktreeId, repo.executionHostId)
|
|
}
|
|
if (tab?.activePageId) {
|
|
state?.focusBrowserTabInWorktree(worktreeId, tab.activePageId, { surfacePane: true })
|
|
}
|
|
return tab?.id ?? null
|
|
}, remote.worktreeId)
|
|
expect(retained).toBe(tabId)
|
|
// The retained tab reaches the host and still sends the relay-era cookie, with no new login.
|
|
await expect(async () => {
|
|
// A page that mounted before the host connected offers Retry, as it would to the user.
|
|
const retry = page.getByRole('button', { name: 'Retry', exact: true })
|
|
if (await retry.isVisible()) {
|
|
await retry.click()
|
|
}
|
|
await navigateGuest(page, tabId, `${SSH_REMOTE_ONLY_ORIGIN}/echo/retained`)
|
|
expect(await guestMarker(page, tabId)).toBe(cookieMarker)
|
|
}).toPass({ timeout: 60_000 })
|
|
expect(
|
|
await page
|
|
.locator(`[data-browser-overlay-tab-id="${tabId}"] webview`)
|
|
.getAttribute('partition')
|
|
).toBe(partitionBefore)
|
|
await expect.poll(() => guestMarker(page, tabId), { timeout: 30_000 }).toBe(cookieMarker)
|
|
expect(readSshRemoteOnlyRequests(target)).toContainEqual({
|
|
path: '/echo/retained',
|
|
cookie: `${SSH_REMOTE_ONLY_COOKIE_NAME}=${SSH_REMOTE_ONLY_COOKIE_VALUE}`
|
|
})
|
|
expect(
|
|
await page
|
|
.locator(`[data-browser-overlay-tab-id="${tabId}"] webview`)
|
|
.getAttribute('partition')
|
|
).toBe(partitionBefore)
|
|
await page.keyboard.press('Escape')
|
|
await page.evaluate(() => {
|
|
if (document.activeElement instanceof HTMLElement) {
|
|
document.activeElement.blur()
|
|
}
|
|
})
|
|
await expect(page.locator('[data-slot="popover-content"]')).toHaveCount(0)
|
|
await page.screenshot({ path: testInfo.outputPath('browser-retained-after-conversion.png') })
|
|
await page.evaluate(
|
|
async ({ worktreeId, url }) => {
|
|
const state = window.__store?.getState()
|
|
const groupId = state?.activeGroupIdByWorktree[worktreeId]
|
|
if (!state || !groupId) {
|
|
throw new Error('No active browser group')
|
|
}
|
|
state.setBrowserDefaultUrl(url)
|
|
await state.openNewBrowserTabInActiveWorkspace(groupId)
|
|
},
|
|
{ worktreeId: remote.worktreeId, url: `${SSH_REMOTE_ONLY_ORIGIN}/echo/control` }
|
|
)
|
|
await expect
|
|
.poll(
|
|
() => readSshRemoteOnlyRequests(target).some((request) => request.path === '/echo/control'),
|
|
{ timeout: 60_000 }
|
|
)
|
|
.toBe(true)
|
|
await page.screenshot({ path: testInfo.outputPath('browser-new-tab-control.png') })
|
|
const createdId = await page.evaluate(
|
|
({ worktreeId, retainedId }) => {
|
|
const created = window.__store
|
|
?.getState()
|
|
.browserTabsByWorktree[worktreeId]?.find((tab) => tab.id !== retainedId)
|
|
if (!created) {
|
|
throw new Error('Missing new browser tab')
|
|
}
|
|
return created.id
|
|
},
|
|
{ worktreeId: remote.worktreeId, retainedId: tabId }
|
|
)
|
|
await expect.poll(() => guestMarker(page, createdId), { timeout: 30_000 }).toBe(cookieMarker)
|
|
const partitionAfter = await page
|
|
.locator(`[data-browser-overlay-tab-id="${createdId}"] webview`)
|
|
.getAttribute('partition')
|
|
expect(partitionAfter).toBe(partitionBefore)
|
|
expect(readSshRemoteOnlyRequests(target)).toContainEqual({
|
|
path: '/echo/control',
|
|
cookie: `${SSH_REMOTE_ONLY_COOKIE_NAME}=${SSH_REMOTE_ONLY_COOKIE_VALUE}`
|
|
})
|
|
const generation = getOrcadSshDeployment(environment)?.sshTargetGeneration
|
|
if (generation === undefined) {
|
|
throw new Error('Missing deployment registration')
|
|
}
|
|
const stale = await page.evaluate(
|
|
async (args) => {
|
|
try {
|
|
await window.api.browser.prepareSshWorkspacePartition(args)
|
|
return 'accepted'
|
|
} catch (error) {
|
|
return String(error)
|
|
}
|
|
},
|
|
{ targetId: remote.targetId, expectedSshTargetGeneration: generation + 1 }
|
|
)
|
|
expect(stale).toContain('browser_local_route_target_stale')
|
|
await reconnect(page, remote.targetId)
|
|
await navigateGuest(page, createdId, `${SSH_REMOTE_ONLY_ORIGIN}/echo/reconnect`)
|
|
await expect.poll(() => guestMarker(page, createdId), { timeout: 30_000 }).toBe(cookieMarker)
|
|
expect(readSshRemoteOnlyRequests(target)).toContainEqual({
|
|
path: '/echo/reconnect',
|
|
cookie: `${SSH_REMOTE_ONLY_COOKIE_NAME}=${SSH_REMOTE_ONLY_COOKIE_VALUE}`
|
|
})
|
|
await page.evaluate(
|
|
({ worktreeId, tabId }) => {
|
|
const state = window.__store?.getState()
|
|
const pageId = state?.browserTabsByWorktree[worktreeId]?.find(
|
|
(tab) => tab.id === tabId
|
|
)?.activePageId
|
|
if (pageId) {
|
|
state?.focusBrowserTabInWorktree(worktreeId, pageId, { surfacePane: true })
|
|
}
|
|
},
|
|
{ worktreeId: remote.worktreeId, tabId }
|
|
)
|
|
await navigateGuest(page, tabId, `${SSH_REMOTE_ONLY_ORIGIN}/echo/retained-reconnect`)
|
|
await expect.poll(() => guestMarker(page, tabId), { timeout: 30_000 }).toBe(cookieMarker)
|
|
expect(readSshRemoteOnlyRequests(target)).toContainEqual({
|
|
path: '/echo/retained-reconnect',
|
|
cookie: `${SSH_REMOTE_ONLY_COOKIE_NAME}=${SSH_REMOTE_ONLY_COOKIE_VALUE}`
|
|
})
|
|
console.log(
|
|
'[managed-browser-route]',
|
|
JSON.stringify({
|
|
partitionBefore,
|
|
partitionAfter,
|
|
requests: readSshRemoteOnlyRequests(target)
|
|
})
|
|
)
|
|
await page.keyboard.press('Escape')
|
|
await page.evaluate(() => {
|
|
if (document.activeElement instanceof HTMLElement) {
|
|
document.activeElement.blur()
|
|
}
|
|
})
|
|
await expect(page.locator('[data-slot="popover-content"]')).toHaveCount(0)
|
|
await page.screenshot({ path: testInfo.outputPath('browser-retained-after-reconnect.png') })
|
|
await session.close(app)
|
|
app = null
|
|
const restarted = await session.launch()
|
|
app = restarted.app
|
|
await waitForSessionReady(restarted.page)
|
|
await waitForStartupWorktreeRefresh(restarted.page)
|
|
console.log(
|
|
'[retained-browser-restored]',
|
|
JSON.stringify(
|
|
await restarted.page.evaluate(() => {
|
|
const state = window.__store?.getState()
|
|
return {
|
|
tabs: state?.browserTabsByWorktree,
|
|
pages: state?.browserPagesByWorkspace,
|
|
active: state?.activeWorktreeId,
|
|
host: state?.activeWorkspaceExecutionHostId
|
|
}
|
|
})
|
|
)
|
|
)
|
|
await restarted.page.evaluate(
|
|
({ worktreeId, environmentId, tabId }) => {
|
|
const state = window.__store?.getState()
|
|
state?.setActiveWorktree(worktreeId, `runtime:${environmentId}`)
|
|
const pageId = state?.browserTabsByWorktree[worktreeId]?.find(
|
|
(tab) => tab.id === tabId
|
|
)?.activePageId
|
|
if (pageId) {
|
|
state?.focusBrowserTabInWorktree(worktreeId, pageId, { surfacePane: true })
|
|
}
|
|
},
|
|
{ worktreeId: remote.worktreeId, environmentId: environment.id, tabId }
|
|
)
|
|
await expect
|
|
.poll(() => guestMarker(restarted.page, tabId), { timeout: 60_000 })
|
|
.toBe(cookieMarker)
|
|
await navigateGuest(restarted.page, tabId, `${SSH_REMOTE_ONLY_ORIGIN}/echo/retained-restart`)
|
|
expect(readSshRemoteOnlyRequests(target)).toContainEqual({
|
|
path: '/echo/retained-restart',
|
|
cookie: `${SSH_REMOTE_ONLY_COOKIE_NAME}=${SSH_REMOTE_ONLY_COOKIE_VALUE}`
|
|
})
|
|
console.log('[retained-browser-restart]', JSON.stringify(readSshRemoteOnlyRequests(target)))
|
|
} finally {
|
|
if (app) {
|
|
await session.close(app)
|
|
}
|
|
await session.dispose()
|
|
cleanupDockerSshHostTarget(target)
|
|
rmSync(scratch, { recursive: true, force: true })
|
|
}
|
|
})
|