mirror of
https://github.com/stablyai/orca.git
synced 2026-11-01 01:27:35 +00:00
* chore(lint): remove disable directives that suppress nothing
Each was reported unused by the oxlint config that owns its rule (root,
casting, react-doctor, anti-slop, native-plugins), including 17 file-level
react-doctor blanket disables whose rule no longer fires. An unused
react-hooks disable was masking a react/purity finding in
useAgentBucketCounts (compiler rules skip functions with hook
suppressions); suppress that one explicitly where the code explains it.
* test(tab-bar): use typed tab/file fixtures instead of @ts-expect-error partials
* chore(lint): fix misc suppressed lint violations instead of disabling
- consistent-type-imports: the "vi.importActual requires inline import()"
rationale was wrong; use typed vi.mock(import(...), importOriginal) or a
type-only namespace import.
- no-control-regex: source-control commit/push failure summaries, shell PATH
hydration, and ipynb ANSI parsing reuse the shared ansi-escape-sequences
stripper and control-character pattern instead of private copies.
- no-explicit-any / no-useless-spread / no-this-alias: typed `this` in
bridge test mocks, drop blanket file-level disables, drop a this-alias.
* refactor(main): replace avoidable type assertions with checked narrowing
17 production cast suppressions in main/wsl-guest removed: untrusted IPC
and RPC payloads (Jira issue update, WSL guest plugin install, handshake
type) now narrow through isRecord/type guards and build typed results;
redundant casts dropped; hand-rolled object checks and errno casts use the
existing isRecord / hasErrorCode helpers.
* refactor(renderer,mobile): replace avoidable type assertions with checked types
13 production cast suppressions removed: RPC failures read through the
`ok` discriminant instead of casting to RpcFailure; react-native-web host
refs narrowed with instanceof HTMLElement; redundant reply/diff casts
become checked annotations; the TUI agent param uses z.custom(isTuiAgent)
like its sibling schemas; the agent-status slice cast that hid missing
actions is gone so the creator's return type checks the whole slice.
* chore(lint): drop dead tiptap wrapper; scope anti-slop mocking rule to test support
- safe-react-node-view-renderer patched handleSelectionUpdate, which
@tiptap/react 3.31.3 no longer has, so it always returned early. Use the
stock ReactNodeViewRenderer.
- The anti-slop test override only matched *.test.{ts,tsx}, forcing
file-level no-module-mocking disables in test harnesses and fixtures.
Match *-test-harness, *-test-fixture(s), .test-fixture and *.test.mjs,
then drop those disables and the now-redundant per-file exemptions.
* test: replace repeated cast suppressions with typed fixtures (main/shared/e2e)
Net -119 cast directives. Typed fixtures replace recurring casts:
unusedSshConnection/unusedOrcadHostTransport placeholders, a typed
readPersistedState harness read (exposed a test treating optional
httpProxyUrl as always set), real Response objects in fetch spies, an
updater main-window fixture, a CDP webContents adapter, one shared
releaseModuleExport for cross-version tests, and requireOverlayDir in
place of `as string` on possibly-undefined overlay paths.
* fix(runtime): validate loaded device rows and host scope instead of casting
Two cast suppressions claimed checks that did not happen:
- device-registry-file-read: "normalizeLoadedDeviceRow re-validates every
field" was false; deviceId, token, name and timestamps were never
checked. Rows without an identity are now dropped and the file is set
aside through the existing corrupt-file path (registry reads as
doubtful, so no revocation verdicts); a non-string token is stripped
so the row stays listed but cannot authenticate.
- client-ui: "only optionality differs" was false; any string reached
persisted workspaceHostScope. Narrow it with isWorkspaceHostScope and
ignore unknown scopes (wire schema unchanged for mixed versions). The
remaining cast now states what it actually covers.
* test(runtime,ipc): drop redundant cast suppressions; typed runtime store fixture
-98 cast directives across runtime/ipc tests: 61 casts that typecheck
without the assertion; a typed vi.fn for scoped invalidation; a
partialRuntimeStore fixture in place of `store as never` for
OrcaRuntimeService; typed worker terminal/authority builders in the
incarnation-fallback suite (the old stub lacked runtimeId, ptyId,
worktreeId and launchTokenHash) plus removal of stacked duplicate
directives there.
* chore(lint): typed vi.mock imports and explicit listener snapshot in shared-bucket tests
Remaining files from the misc-rule pass that overlapped other buckets:
codex-accounts mocks use the typed vi.mock(import(...)) form instead of
a consistent-type-imports disable; the daemon late-exit fixture copies
its listener set with Array.from instead of a no-useless-spread disable.
* refactor(github,mobile): narrow routing settings type; drop remaining avoidable casts
- work-item-routing cast a one-field object to AppState['settings'] under
a claim that readers only consume activeRuntimeEnvironmentId. Return the
existing RuntimeFocusSettings pick instead and narrow the cache-key
chain's parameters, so the compiler enforces that claim.
- mobile file preview reads refusals through the RpcResponse `ok`
discriminant rather than a cast.
- terminal document host-notify accepts `unknown` errors, removing the
message-bridge cast.
- native chat readability drops a redundant repo-list cast.
* test(renderer): replace repeated cast suppressions with typed fixtures
-140 cast directives (and ~150 unsuppressed casts of the same shapes):
- mockPanePtyArgs owns the connectPanePty fixture casts, so a wrong
argument order or fixture is now a type error; drop binding casts for
members PanePtyBinding already declares.
- Seed AppState tab rows with the typed makeTerminalTab; this exposed a
split direction 'row' that is not a TerminalPaneSplitDirection.
- Partial GlobalSettings use getDefaultSettings overrides; Jira-only
stores use createTestStore; runtime environment rows/statuses come from
a typed paired-runtime-environment fixture.
* chore(lint): drop no-module-mocking disable now covered by the test-fixture glob
* test(e2e): fix all 221 grandfathered e2e type errors; baseline to zero
The e2e typecheck baseline grandfathered 221 errors in 119 files. About a
third were tests drifted from the current API, several of which would
fail or mislead at runtime:
- terminal-shortcuts called a nonexistent xterm buffer method;
- the daemon-lifecycle fake lacked terminateOwnedTree, hidden by importing
its type from a module that does not export it;
- arguments in the wrong position (listProcesses(hostId, opts), a dropped
pty.write inputKind, an extra toWebTerminalSurfaceTabId argument);
- removed enum values ('drawer', 'idle', 'editor',
'session-insecure-origin') and a launch_source the telemetry schema
rejects;
- missing required fields (turnScope, childWorkOpen, providerIdentity,
reviewLookupOutcome, runtimeServiceAccount behind an `as RelayConfig`);
- dead reads (tab.customTitle, bucket.targets, changedPixels).
Also lifts variables that narrowed to `never` after poll-callback
assignment, and adds a typed xterm render-dimensions accessor. Includes
the cross-version suites' shared releaseModuleExport adoption.
* chore(typecheck): gate the now-clean e2e typecheck in local lint
The e2e baseline is empty, so the ratchet now rejects any tests/ type
error. CI already runs it via run-ratchets; add it to pnpm lint's
explicit ratchet list and replace the stale 'not yet clean' note.
* test(mobile): typecheck every mobile test; baseline 105 files -> 0
mobile/tests-typecheck-baseline.txt grandfathered 105 test files (531
errors) whose types CI never checked. Contract changes had landed without
these tests following, and type pins in them silently checked nothing.
- Root cause: salvagedOptional (src/shared/zod-salvage.ts) cast away
zod's optional marker, so every reply type built on it claimed
salvaged fields were always present. Return a real ZodOptional;
runtime is unchanged (the outer optional short-circuits undefined).
- Production now takes the port it uses: RpcOperationSender instead of
RpcClient for send-only callers, a narrow fetch signature, and only the
request fields push-receive reads.
- findAllByHostType/findByHostType replace `'Text' as never` lookups;
stubRpcClient gives tests a typed RpcClient.
- Real test bugs: settings-host-client-lifecycle "relay" hosts were
direct hosts (relayHostId no longer exists); two toEqualTypeOf pins
could never hold; a recovery hook ran with an undefined scope key;
a create-PR test cast to a never-imported type; "no URL" assertions
passed on null; plus stale required props, args and enum values.
* test(e2e): parse workerStart result instead of casting it
* test(runtime): typed partial runtime stores with production-shaped fixture data
Route every partial store passed to OrcaRuntimeService through
partialRuntimeStore with typed row builders, removing 60 cast directives
that hid fixture data production never produces:
- paired-client-navigation-test-harness keyed setWorktreeMeta writes by
`[object Object]` (it took an id where the store takes a target), so
reads never saw them;
- invalid worktree lineage origin/capture and incomplete workspace lineage;
- getWorkspaceSession returning null where the store returns the default
session; getGitHubCache returning undefined;
- orcad migration states missing migrationId/manifest/receipt, with a
toEqual pinned to that incomplete shape;
- partial repos, metadata, folders, project groups and notification rows.
* refactor(renderer): resolve suppressed React hook lint instead of disabling it
109 of 187 react-hooks/react-doctor suppressions fixed:
- ~95 exhaustive-deps disables only hid stable refs and setters passed
through controller objects; list them (identity never changes, so
nothing re-runs), plus a few real stale closures (tabId/worktreeId).
- Effects keyed on one value that read the latest props now use
useEffectEvent (WebConnect, skill freshness, Bitbucket dialog seeding,
Landing preflight, automation catalog, structured-session recovery,
file explorer).
- The conditional layout-owner hook is selected once at module load from
the build constant instead of a rules-of-hooks disable that also hid
the whole controller from compiler and react-doctor rules.
- A hook disable was masking a react/purity Date.now() in the palette's
recent-tabs memo; sample it when the snapshot is captured.
- Three identical debounced-search effects share
useTaskSearchDebouncedApply; layout snapshot merge helpers move out to
stay under max-lines.
Remaining suppressions are mount-once resources, invalidation epochs,
deliberately keyed fields, and test harnesses that mock the dispatcher.
* chore(ratchet): exempt test harnesses and fixtures from the focus-read ratchet
The ratchet skipped *.test-fixture.ts but scanned *-test-harness,
*-test-fixture(s) and *.test-support files. Those seed settings with
getDefaultSettings (which the ratchet discovers as a focus reader) and
never route host work, so 17 baseline entries were false positives, and
replacing a test's `settings: {...} as never` with typed defaults tripped
it. Match the repo's test-support names and prune (which also drops one
stale entry), and rename the frame-ordering harness to *-test-harness like
its siblings. A blanket "-harness" match would also exempt
e2e-terminal-pty-harness, which production imports, so the names stay
explicit.
* test: merge duplicate shared/constants imports
* revert(file-explorer): restore original tree load effects pending SSH e2e investigation
* test(runtime): drop RuntimeStore cast now that the fixture is typed
---------
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
349 lines
13 KiB
TypeScript
349 lines
13 KiB
TypeScript
import type { XtermWithRenderDimensions } from './helpers/xterm-render-dimensions'
|
|
import { randomUUID } from 'node:crypto'
|
|
import { rmSync, writeFileSync } from 'node:fs'
|
|
import path from 'node:path'
|
|
import type { Page } from '@stablyai/playwright-test'
|
|
import { test, expect } from './helpers/orca-app'
|
|
import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'
|
|
import {
|
|
sendToTerminal,
|
|
waitForActivePanePtyId,
|
|
waitForActiveTerminalManager,
|
|
waitForTerminalOutput
|
|
} from './helpers/terminal'
|
|
import { waitForPtyShellEcho } from './terminal-pty-readiness'
|
|
import {
|
|
analyzeRasterCursorCells,
|
|
type TerminalRasterProbeTarget
|
|
} from './terminal-cursor-raster-probe'
|
|
import { nodeTerminalCommand } from './terminal-node-command'
|
|
|
|
type TerminalRenderState = {
|
|
coreCursorHidden: boolean | null
|
|
cursorElementCount: number
|
|
cursorVisibleElementCount: number
|
|
cursorBlink: boolean | null
|
|
blinkIntervalDuration: number | null
|
|
cursorClassName: string
|
|
cursorAnimationName: string
|
|
cursorAnimationDuration: string
|
|
rowContainerClassName: string
|
|
xtermClassName: string
|
|
hasWebglCanvas: boolean
|
|
hasComplexScriptOutput: boolean
|
|
renderer: 'dom' | 'webgl'
|
|
}
|
|
|
|
type CursorBlinkSample = {
|
|
elapsedMs: number
|
|
paintedCursorCellCount: number
|
|
}
|
|
|
|
const EMOJI_TABLE_MARKER = 'ORCA_EMOJI_TABLE_RENDER_DONE'
|
|
|
|
function emojiTableScript(marker: string): string {
|
|
const table = [
|
|
'| Emoji | Name | Age | Occupation | City | Favorite Color | Pet | Hobby |',
|
|
'| --- | --- | ---: | --- | --- | --- | --- | --- |',
|
|
'| 😀 | Alice Johnson | 28 | Engineer | New York | Blue | 🐕 Dog | 🎸 Guitar |',
|
|
'| 😂 | Bob Smith | 34 | Designer | London | Green | 🐱 Cat | 📚 Reading |',
|
|
'| 🥰 | Carol Davis | 22 | Student | Paris | Pink | 🐰 Rabbit | 🎨 Painting |',
|
|
'| 😎 | Dave Wilson | 45 | Architect | Tokyo | Black | 🐢 Turtle | 🏃 Running |',
|
|
'| 🤩 | Eve Martinez | 31 | Writer | Berlin | Purple | 🐦 Bird | ✈️ Traveling |',
|
|
'| 😜 | Frank Brown | 27 | Developer | Sydney | Red | 🐹 Hamster | 🎮 Gaming |',
|
|
'| 🥳 | Grace Lee | 39 | Teacher | Seoul | Yellow | 🐟 Fish | 🌱 Gardening |',
|
|
'| 🤔 | Henry Taylor | 41 | Doctor | Toronto | White | 🐕 Dog | 🍳 Cooking |',
|
|
'| 😴 | Ivy Anderson | 26 | Nurse | Chicago | Orange | 🐱 Cat | 🧘 Yoga |',
|
|
'| 🤗 | Jack Thomas | 33 | Lawyer | Boston | Navy | 🐢 Turtle | 📸 Photography |',
|
|
'| 😈 | Karen White | 29 | Artist | Miami | Teal | 🐹 Hamster | 🧶 Knitting |',
|
|
'| 😮 | Leo Harris | 37 | Pilot | Dubai | Gold | 🐦 Bird | 🚁 Drones |',
|
|
'| 🤠 | Mia Clark | 24 | Barista | Seattle | Coral | 🐰 Rabbit | 🎤 Singing |',
|
|
'| 😍 | Olivia Hall | 30 | Marketer | Austin | Pink | 🐱 Cat | 🏄 Surfing |'
|
|
].join('\r\n')
|
|
|
|
return `
|
|
async function writeStdout(chunk) {
|
|
await new Promise((resolve) => {
|
|
process.stdout.write(chunk, resolve)
|
|
})
|
|
if (process.platform === 'win32') {
|
|
await new Promise((resolve) => setTimeout(resolve, 8))
|
|
}
|
|
}
|
|
await writeStdout('\\x1b[?2026h\\x1b[?25l\\x1b[2J\\x1b[H')
|
|
for (const line of ${JSON.stringify(table.split('\r\n'))}) {
|
|
await writeStdout(line + '\\r\\n')
|
|
}
|
|
await writeStdout('\\x1b[?25h\\x1b[?2026l')
|
|
await writeStdout('${marker}\\r\\n')
|
|
setTimeout(() => process.exit(0), 50)
|
|
`
|
|
}
|
|
|
|
async function readActiveTerminalRenderState(page: Page): Promise<TerminalRenderState> {
|
|
return page.evaluate(() => {
|
|
const state = window.__store?.getState()
|
|
const worktreeId = state?.activeWorktreeId
|
|
const tabId =
|
|
state?.activeTabType === 'terminal'
|
|
? state.activeTabId
|
|
: worktreeId
|
|
? (state?.activeTabIdByWorktree?.[worktreeId] ?? null)
|
|
: null
|
|
const manager = tabId ? window.__paneManagers?.get(tabId) : null
|
|
const pane = manager?.getActivePane?.() ?? manager?.getPanes?.()[0] ?? null
|
|
if (!pane) {
|
|
throw new Error('No active terminal pane')
|
|
}
|
|
const renderingDiagnostics = manager
|
|
?.getRenderingDiagnostics()
|
|
.find((diagnostic) => diagnostic.paneId === pane.id)
|
|
|
|
const cursorElements = Array.from(
|
|
pane.container.querySelectorAll<HTMLElement>('.xterm-cursor, .xterm-cursor-layer *')
|
|
)
|
|
const cursorVisibleElementCount = cursorElements.filter((element) => {
|
|
const style = window.getComputedStyle(element)
|
|
const rect = element.getBoundingClientRect()
|
|
return (
|
|
style.display !== 'none' &&
|
|
style.visibility !== 'hidden' &&
|
|
Number(style.opacity || '1') > 0 &&
|
|
rect.width > 0 &&
|
|
rect.height > 0
|
|
)
|
|
}).length
|
|
|
|
const terminal = pane.terminal as {
|
|
_core?: {
|
|
coreService?: { isCursorHidden?: boolean }
|
|
}
|
|
}
|
|
const cursorElement = pane.container.querySelector<HTMLElement>('.xterm-cursor')
|
|
const cursorStyle = cursorElement ? window.getComputedStyle(cursorElement) : null
|
|
const rowContainer = pane.container.querySelector<HTMLElement>('.xterm-rows')
|
|
const xterm = pane.container.querySelector<HTMLElement>('.xterm')
|
|
|
|
return {
|
|
coreCursorHidden:
|
|
typeof terminal._core?.coreService?.isCursorHidden === 'boolean'
|
|
? terminal._core.coreService.isCursorHidden
|
|
: null,
|
|
cursorElementCount: cursorElements.length,
|
|
cursorVisibleElementCount,
|
|
cursorBlink:
|
|
typeof pane.terminal.options.cursorBlink === 'boolean'
|
|
? pane.terminal.options.cursorBlink
|
|
: null,
|
|
blinkIntervalDuration:
|
|
typeof pane.terminal.options.blinkIntervalDuration === 'number'
|
|
? pane.terminal.options.blinkIntervalDuration
|
|
: null,
|
|
cursorClassName: cursorElement?.className ?? '',
|
|
cursorAnimationName: cursorStyle?.animationName ?? '',
|
|
cursorAnimationDuration: cursorStyle?.animationDuration ?? '',
|
|
rowContainerClassName: rowContainer?.className ?? '',
|
|
xtermClassName: xterm?.className ?? '',
|
|
hasWebglCanvas: renderingDiagnostics?.hasWebgl ?? false,
|
|
hasComplexScriptOutput: renderingDiagnostics?.hasComplexScriptOutput ?? false,
|
|
renderer: renderingDiagnostics?.hasWebgl ? 'webgl' : 'dom'
|
|
}
|
|
})
|
|
}
|
|
|
|
async function forceCursorProbeTheme(page: Page): Promise<void> {
|
|
await page.evaluate(() => {
|
|
const state = window.__store?.getState()
|
|
const worktreeId = state?.activeWorktreeId
|
|
const tabId =
|
|
state?.activeTabType === 'terminal'
|
|
? state.activeTabId
|
|
: worktreeId
|
|
? (state?.activeTabIdByWorktree?.[worktreeId] ?? null)
|
|
: null
|
|
const manager = tabId ? window.__paneManagers?.get(tabId) : null
|
|
const pane = manager?.getActivePane?.() ?? manager?.getPanes?.()[0] ?? null
|
|
if (!pane) {
|
|
throw new Error('No active terminal pane')
|
|
}
|
|
pane.terminal.options.theme = {
|
|
...pane.terminal.options.theme,
|
|
cursor: '#23ff45',
|
|
cursorAccent: '#001000'
|
|
}
|
|
pane.terminal.options.cursorStyle = 'block'
|
|
pane.terminal.options.cursorBlink = true
|
|
pane.terminal.focus()
|
|
pane.terminal.refresh(0, pane.terminal.rows - 1)
|
|
})
|
|
}
|
|
|
|
async function readActiveTerminalRasterTarget(page: Page): Promise<TerminalRasterProbeTarget> {
|
|
return page.evaluate(() => {
|
|
const state = window.__store?.getState()
|
|
const worktreeId = state?.activeWorktreeId
|
|
const tabId =
|
|
state?.activeTabType === 'terminal'
|
|
? state.activeTabId
|
|
: worktreeId
|
|
? (state?.activeTabIdByWorktree?.[worktreeId] ?? null)
|
|
: null
|
|
const manager = tabId ? window.__paneManagers?.get(tabId) : null
|
|
const pane = manager?.getActivePane?.() ?? manager?.getPanes?.()[0] ?? null
|
|
if (!pane) {
|
|
throw new Error('No active terminal pane')
|
|
}
|
|
const screen = pane.container.querySelector<HTMLElement>('.xterm-screen')
|
|
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: xterm has no public cell-size API; the private render service is read through all-optional fields.
|
|
const dimensions = (pane.terminal as XtermWithRenderDimensions)._core?._renderService
|
|
?.dimensions?.css?.cell
|
|
if (!screen || !dimensions) {
|
|
throw new Error('Active terminal has no measurable xterm screen')
|
|
}
|
|
const rect = screen.getBoundingClientRect()
|
|
return {
|
|
clip: { x: rect.x, y: rect.y, width: rect.width, height: rect.height },
|
|
cellWidth: dimensions.width,
|
|
cellHeight: dimensions.height,
|
|
rows: pane.terminal.rows,
|
|
cols: pane.terminal.cols
|
|
}
|
|
})
|
|
}
|
|
|
|
async function sampleCursorBlink(page: Page): Promise<CursorBlinkSample[]> {
|
|
const samples: CursorBlinkSample[] = []
|
|
const target = await readActiveTerminalRasterTarget(page)
|
|
const viewport = page.viewportSize() ?? undefined
|
|
const start = performance.now()
|
|
for (let index = 0; index < 9; index += 1) {
|
|
if (index > 0) {
|
|
await page.waitForTimeout(200)
|
|
}
|
|
const screenshot = await page.screenshot()
|
|
const cells = analyzeRasterCursorCells(Buffer.from(screenshot), target, viewport)
|
|
samples.push({
|
|
elapsedMs: performance.now() - start,
|
|
paintedCursorCellCount: cells.length
|
|
})
|
|
}
|
|
return samples
|
|
}
|
|
|
|
async function enableRiskyTerminalRendererPath(page: Page): Promise<void> {
|
|
await page.evaluate(() => {
|
|
const store = window.__store
|
|
if (!store) {
|
|
throw new Error('window.__store unavailable')
|
|
}
|
|
const state = store.getState()
|
|
store.setState({
|
|
settings: {
|
|
...state.settings!,
|
|
terminalGpuAcceleration: 'auto',
|
|
theme: 'dark'
|
|
}
|
|
})
|
|
const worktreeId = state.activeWorktreeId
|
|
const tabId =
|
|
state.activeTabType === 'terminal'
|
|
? state.activeTabId
|
|
: worktreeId
|
|
? (state.activeTabIdByWorktree?.[worktreeId] ?? null)
|
|
: null
|
|
const manager = tabId ? window.__paneManagers?.get(tabId) : null
|
|
manager?.setTerminalGpuAcceleration('auto')
|
|
})
|
|
}
|
|
|
|
test.describe('OpenCode emoji table terminal rendering', () => {
|
|
test('keeps emoji table output visually sane and restores the cursor', async ({
|
|
orcaPage,
|
|
testRepoPath
|
|
}, testInfo) => {
|
|
await waitForSessionReady(orcaPage)
|
|
await waitForActiveWorktree(orcaPage)
|
|
await ensureTerminalVisible(orcaPage)
|
|
await waitForActiveTerminalManager(orcaPage, 30_000)
|
|
await enableRiskyTerminalRendererPath(orcaPage)
|
|
|
|
const ptyId = await waitForActivePanePtyId(orcaPage)
|
|
await waitForPtyShellEcho(orcaPage, ptyId, 20_000)
|
|
const runId = randomUUID()
|
|
const marker = `${EMOJI_TABLE_MARKER}_${runId}`
|
|
const scriptPath = path.join(testRepoPath, `.orca-opencode-emoji-table-${runId}.mjs`)
|
|
writeFileSync(scriptPath, emojiTableScript(marker))
|
|
try {
|
|
await sendToTerminal(orcaPage, ptyId, `${nodeTerminalCommand([scriptPath])}\r`)
|
|
await waitForTerminalOutput(orcaPage, marker, 10_000)
|
|
await orcaPage.waitForTimeout(250)
|
|
await forceCursorProbeTheme(orcaPage)
|
|
await orcaPage.waitForTimeout(50)
|
|
|
|
const renderState = await readActiveTerminalRenderState(orcaPage)
|
|
const blinkSamples = await sampleCursorBlink(orcaPage)
|
|
|
|
testInfo.annotations.push({
|
|
type: 'opencode-emoji-table-rendering',
|
|
description: JSON.stringify({ renderState, blinkSamples })
|
|
})
|
|
|
|
expect(renderState.hasComplexScriptOutput).toBe(false)
|
|
expect(renderState.renderer).toBe(renderState.hasWebglCanvas ? 'webgl' : 'dom')
|
|
expect(renderState.coreCursorHidden).toBe(false)
|
|
if (!renderState.hasWebglCanvas) {
|
|
expect(renderState.cursorVisibleElementCount).toBeGreaterThan(0)
|
|
expect(renderState.cursorBlink).toBe(true)
|
|
expect(renderState.cursorAnimationName).not.toBe('none')
|
|
}
|
|
expect(blinkSamples.some((sample) => sample.paintedCursorCellCount > 0)).toBe(true)
|
|
expect(blinkSamples.some((sample) => sample.paintedCursorCellCount === 0)).toBe(true)
|
|
} finally {
|
|
rmSync(scriptPath, { force: true })
|
|
}
|
|
})
|
|
|
|
test('local real OpenCode demo keeps table rendering and cursor visible', async ({
|
|
orcaPage
|
|
}, testInfo) => {
|
|
test.skip(
|
|
process.env.ORCA_E2E_REAL_OPENCODE !== '1',
|
|
'Set ORCA_E2E_REAL_OPENCODE=1 to exercise the locally installed OpenCode TUI'
|
|
)
|
|
|
|
await waitForSessionReady(orcaPage)
|
|
await waitForActiveWorktree(orcaPage)
|
|
await ensureTerminalVisible(orcaPage)
|
|
await waitForActiveTerminalManager(orcaPage, 30_000)
|
|
await enableRiskyTerminalRendererPath(orcaPage)
|
|
|
|
const ptyId = await waitForActivePanePtyId(orcaPage)
|
|
await sendToTerminal(
|
|
orcaPage,
|
|
ptyId,
|
|
'opencode run --demo --interactive "Give me markdown table dummy data a long table with emojis in it"\r'
|
|
)
|
|
try {
|
|
await waitForTerminalOutput(orcaPage, 'Give me markdown table', 15_000)
|
|
await waitForTerminalOutput(orcaPage, 'Emoji', 60_000)
|
|
await waitForTerminalOutput(orcaPage, 'Alice', 60_000)
|
|
await orcaPage.waitForTimeout(1_500)
|
|
|
|
await testInfo.attach('real-opencode-demo-table', {
|
|
body: await orcaPage.screenshot({ fullPage: true }),
|
|
contentType: 'image/png'
|
|
})
|
|
|
|
const renderState = await readActiveTerminalRenderState(orcaPage)
|
|
testInfo.annotations.push({
|
|
type: 'real-opencode-demo-rendering',
|
|
description: JSON.stringify(renderState)
|
|
})
|
|
expect(renderState.coreCursorHidden).toBe(false)
|
|
expect(renderState.cursorVisibleElementCount).toBeGreaterThan(0)
|
|
} finally {
|
|
await sendToTerminal(orcaPage, ptyId, '\x03').catch(() => undefined)
|
|
}
|
|
})
|
|
})
|