mirror of
https://github.com/stablyai/orca.git
synced 2026-11-01 17:47:40 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
649 lines
22 KiB
JavaScript
649 lines
22 KiB
JavaScript
#!/usr/bin/env node
|
||
/**
|
||
* A/B benchmark for worktree deletion against real Orca dev instances.
|
||
*
|
||
* Usage:
|
||
* pnpm bench:worktree-deletion -- --instance baseline=/path/to/main \
|
||
* --instance candidate=. --iterations 3 --history-files 10000
|
||
*/
|
||
import { spawn, spawnSync } from 'node:child_process'
|
||
import { createHash } from 'node:crypto'
|
||
import { existsSync, mkdirSync, mkdtempSync, writeFileSync } from 'node:fs'
|
||
import { rm } from 'node:fs/promises'
|
||
import net from 'node:net'
|
||
import os from 'node:os'
|
||
import path from 'node:path'
|
||
// Use declared @playwright/test’s re-export instead of relying on a hoisted transitive playwright install.
|
||
import { chromium } from '@playwright/test'
|
||
import * as branchFixture from './worktree-deletion-branch-fixture.mjs'
|
||
|
||
const DEFAULT_ITERATIONS = 3
|
||
const DEFAULT_HISTORY_FILES = 10_000
|
||
const DEFAULT_FETCH_DELAY_MS = 1_500
|
||
const CDP_START_PORT = 9_700
|
||
const START_TIMEOUT_MS = 180_000
|
||
const IPC_TIMEOUT_MS = 90_000
|
||
const resultsRoot = path.resolve(import.meta.dirname, 'results')
|
||
|
||
function parseArgs(argv) {
|
||
const options = {
|
||
instances: [],
|
||
iterations: DEFAULT_ITERATIONS,
|
||
historyFiles: DEFAULT_HISTORY_FILES,
|
||
fetchDelayMs: DEFAULT_FETCH_DELAY_MS,
|
||
keepFixture: false
|
||
}
|
||
for (let index = 2; index < argv.length; index += 1) {
|
||
const value = argv[index]
|
||
if (value === '--') {
|
||
continue
|
||
}
|
||
if (value === '--help' || value === '-h') {
|
||
printHelp()
|
||
process.exit(0)
|
||
}
|
||
if (value === '--keep-fixture') {
|
||
options.keepFixture = true
|
||
continue
|
||
}
|
||
const next = () => {
|
||
const result = argv[++index]
|
||
if (!result) {
|
||
throw new Error(`${value} needs a value`)
|
||
}
|
||
return result
|
||
}
|
||
if (value === '--instance') {
|
||
const entry = next()
|
||
const separator = entry.indexOf('=')
|
||
if (separator <= 0) {
|
||
throw new Error('--instance must use label=/absolute/or/relative/path')
|
||
}
|
||
options.instances.push({
|
||
label: entry.slice(0, separator),
|
||
repoRoot: path.resolve(entry.slice(separator + 1))
|
||
})
|
||
} else if (value === '--iterations') {
|
||
options.iterations = readPositiveInteger(value, next())
|
||
} else if (value === '--history-files') {
|
||
options.historyFiles = readPositiveInteger(value, next())
|
||
} else if (value === '--fetch-delay-ms') {
|
||
options.fetchDelayMs = readPositiveInteger(value, next())
|
||
} else {
|
||
throw new Error(`Unknown argument: ${value}`)
|
||
}
|
||
}
|
||
if (options.instances.length === 0) {
|
||
options.instances.push({ label: 'candidate', repoRoot: process.cwd() })
|
||
}
|
||
return options
|
||
}
|
||
|
||
function readPositiveInteger(flag, value) {
|
||
const number = Number(value)
|
||
if (!Number.isInteger(number) || number < 1) {
|
||
throw new Error(`${flag} must be a positive integer`)
|
||
}
|
||
return number
|
||
}
|
||
|
||
function printHelp() {
|
||
console.log(`Usage:
|
||
pnpm bench:worktree-deletion -- [options]
|
||
|
||
Options:
|
||
--instance <label=path> Dev checkout to launch; repeat for A/B comparison
|
||
--iterations <count> Deletions per instance (default: ${DEFAULT_ITERATIONS})
|
||
--history-files <count> Files seeded in each worktree history (default: ${DEFAULT_HISTORY_FILES})
|
||
--fetch-delay-ms <ms> Slow-remote delay for branch cleanup (default: ${DEFAULT_FETCH_DELAY_MS})
|
||
--keep-fixture Keep disposable profiles and repos for inspection`)
|
||
}
|
||
|
||
function run(command, args, cwd) {
|
||
const result = spawnSync(command, args, { cwd, encoding: 'utf8' })
|
||
if (result.status !== 0) {
|
||
throw new Error(
|
||
`${command} ${args.join(' ')} failed (${result.status})\n${result.stderr || result.stdout}`
|
||
)
|
||
}
|
||
}
|
||
|
||
function createFixture(instanceLabel) {
|
||
const root = mkdtempSync(path.join(os.tmpdir(), `orca-delete-bench-${instanceLabel}-`))
|
||
const repoPath = path.join(root, 'repo')
|
||
const userDataPath = path.join(root, 'user-data')
|
||
mkdirSync(repoPath)
|
||
mkdirSync(userDataPath)
|
||
// Git 2.25 lacks `git init --initial-branch`; rename after the first commit below.
|
||
run('git', ['init'], repoPath)
|
||
run('git', ['config', 'user.email', 'worktree-delete-bench@orca.invalid'], repoPath)
|
||
run('git', ['config', 'user.name', 'Orca Worktree Delete Bench'], repoPath)
|
||
writeFileSync(path.join(repoPath, 'README.md'), '# Orca worktree deletion benchmark\n')
|
||
run('git', ['add', 'README.md'], repoPath)
|
||
run('git', ['commit', '-m', 'Initialize benchmark fixture', '--no-gpg-sign'], repoPath)
|
||
run('git', ['branch', '-m', 'main'], repoPath)
|
||
branchFixture.initializeBranchCleanupRemote(root, repoPath)
|
||
return { root, repoPath, userDataPath }
|
||
}
|
||
|
||
function launchDevInstance({ label, repoRoot }, fixture, port) {
|
||
if (!existsSync(path.join(repoRoot, 'package.json'))) {
|
||
throw new Error(`${label}: package.json not found under ${repoRoot}`)
|
||
}
|
||
const env = {
|
||
...process.env,
|
||
ORCA_DEV_USER_DATA_PATH: fixture.userDataPath,
|
||
REMOTE_DEBUGGING_PORT: String(port)
|
||
}
|
||
delete env.ELECTRON_RUN_AS_NODE
|
||
const child = spawn(process.execPath, ['config/scripts/run-electron-vite-dev.mjs'], {
|
||
cwd: repoRoot,
|
||
env,
|
||
stdio: ['ignore', 'pipe', 'pipe'],
|
||
// Why: own process group so teardown can signal the Electron/Vite grandchildren, not just the launcher.
|
||
detached: process.platform !== 'win32',
|
||
windowsHide: true
|
||
})
|
||
const log = { stdout: '', stderr: '' }
|
||
child.stdout?.on('data', (chunk) => {
|
||
log.stdout = appendLog(log.stdout, chunk)
|
||
})
|
||
child.stderr?.on('data', (chunk) => {
|
||
log.stderr = appendLog(log.stderr, chunk)
|
||
})
|
||
return { child, endpoint: `http://127.0.0.1:${port}`, label, log }
|
||
}
|
||
|
||
function appendLog(current, chunk) {
|
||
return `${current}${String(chunk)}`.slice(-30_000)
|
||
}
|
||
|
||
async function connectToOrca(instance) {
|
||
const deadline = Date.now() + START_TIMEOUT_MS
|
||
let lastError = null
|
||
while (Date.now() < deadline) {
|
||
if (instance.child.exitCode !== null) {
|
||
throw new Error(
|
||
`${instance.label}: dev process exited (${instance.child.exitCode})\n${instance.log.stderr}`
|
||
)
|
||
}
|
||
try {
|
||
const browser = await chromium.connectOverCDP(instance.endpoint)
|
||
try {
|
||
// Wait for __store before accepting CDP; findOrcaPage retries otherwise leak browser handles.
|
||
const page = await findOrcaPage(browser)
|
||
return { browser, page }
|
||
} catch (error) {
|
||
await browser.close().catch(() => undefined)
|
||
throw error
|
||
}
|
||
} catch (error) {
|
||
lastError = error
|
||
await delay(500)
|
||
}
|
||
}
|
||
throw new Error(
|
||
`${instance.label}: CDP did not become ready: ${String(lastError)}\n${instance.log.stderr}`
|
||
)
|
||
}
|
||
|
||
async function findOrcaPage(browser) {
|
||
const deadline = Date.now() + 30_000
|
||
while (Date.now() < deadline) {
|
||
for (const context of browser.contexts()) {
|
||
for (const page of context.pages()) {
|
||
const ready = await page
|
||
.evaluate(() => Boolean(window.__store && window.api?.repos?.list))
|
||
.catch(() => false)
|
||
if (ready) {
|
||
return page
|
||
}
|
||
}
|
||
}
|
||
await delay(250)
|
||
}
|
||
throw new Error('Orca renderer with window.__store was not found')
|
||
}
|
||
|
||
async function addFixtureRepo(page, repoPath) {
|
||
const addedRepo = await page.evaluate(async (fixturePath) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is unavailable')
|
||
}
|
||
const repo = await store.getState().addRepoPath(fixturePath)
|
||
if (!repo) {
|
||
throw new Error(`Could not add fixture repo ${fixturePath}`)
|
||
}
|
||
return { id: repo.id, path: repo.path }
|
||
}, repoPath)
|
||
return page.evaluate(
|
||
async ({ fixtureRepoId, fixturePath }) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is unavailable')
|
||
}
|
||
let rootWorktree
|
||
for (let attempt = 0; attempt < 60 && !rootWorktree; attempt += 1) {
|
||
await store.getState().fetchWorktrees(fixtureRepoId)
|
||
await new Promise((resolve) => window.setTimeout(resolve, 250))
|
||
rootWorktree = store
|
||
.getState()
|
||
.worktreesByRepo[fixtureRepoId]?.find((worktree) => worktree.path === fixturePath)
|
||
}
|
||
if (!rootWorktree) {
|
||
throw new Error('Fixture root worktree did not load')
|
||
}
|
||
const state = store.getState()
|
||
state.setSidebarOpen(true)
|
||
state.setShowActiveOnly(false)
|
||
state.setShowSleepingWorkspaces(true)
|
||
state.setHideDefaultBranchWorkspace(false)
|
||
state.setFilterRepoIds([])
|
||
state.setActiveRepo(fixtureRepoId)
|
||
state.setActiveWorktree(rootWorktree.id)
|
||
return { repoId: fixtureRepoId, rootWorktreeId: rootWorktree.id }
|
||
},
|
||
{ fixtureRepoId: addedRepo.id, fixturePath: addedRepo.path }
|
||
)
|
||
}
|
||
|
||
async function createMeasuredWorktree(page, repoId, iteration) {
|
||
return page.evaluate(
|
||
async ({ fixtureRepoId, sequence }) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is unavailable')
|
||
}
|
||
const result = await store
|
||
.getState()
|
||
.createWorktree(fixtureRepoId, `delete-bench-${sequence}-${Date.now()}`)
|
||
await store.getState().fetchWorktrees(fixtureRepoId)
|
||
const state = store.getState()
|
||
const tab = state.createTab(result.worktree.id)
|
||
state.createBrowserTab(result.worktree.id, 'about:blank', {
|
||
title: 'worktree deletion regression probe',
|
||
activate: false
|
||
})
|
||
state.setActiveView('terminal')
|
||
state.setActiveWorktree(result.worktree.id)
|
||
state.setActiveTab(tab.id)
|
||
state.setRightSidebarTab('explorer')
|
||
state.setRightSidebarOpen(true)
|
||
state.revealWorktreeInSidebar(result.worktree.id, { behavior: 'auto' })
|
||
// Let the terminal and explorer install their real PTY/watcher resources before deletion.
|
||
await new Promise((resolve) => window.setTimeout(resolve, 500))
|
||
return { id: result.worktree.id, path: result.worktree.path }
|
||
},
|
||
{ fixtureRepoId: repoId, sequence: iteration }
|
||
)
|
||
}
|
||
|
||
function seedTerminalHistory(userDataPath, worktreeId, fileCount) {
|
||
const hash = createHash('sha256').update(worktreeId).digest('hex').slice(0, 16)
|
||
const historyPath = path.join(userDataPath, 'terminal-history', hash)
|
||
const payload = 'worktree deletion benchmark history\n'.repeat(4)
|
||
for (let index = 0; index < fileCount; index += 1) {
|
||
const bucket = path.join(historyPath, String(Math.floor(index / 250)))
|
||
if (index % 250 === 0) {
|
||
mkdirSync(bucket, { recursive: true })
|
||
}
|
||
writeFileSync(path.join(bucket, `${index}.history`), payload)
|
||
}
|
||
return historyPath
|
||
}
|
||
|
||
async function assertWorktreeRowVisible(page, worktreeId) {
|
||
await page.waitForFunction(
|
||
(id) =>
|
||
[...document.querySelectorAll('[data-worktree-id]')].some(
|
||
(element) => element.getAttribute('data-worktree-id') === id
|
||
),
|
||
worktreeId
|
||
)
|
||
}
|
||
|
||
async function measureDeletion(page, worktreeId, rootWorktreeId) {
|
||
return page.evaluate(
|
||
async ({ targetId, fallbackId, ipcTimeoutMs }) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is unavailable')
|
||
}
|
||
store.getState().setActiveWorktree(fallbackId)
|
||
let settled = false
|
||
let failure = null
|
||
const startedAt = performance.now()
|
||
const deletion = store
|
||
.getState()
|
||
.removeWorktree(targetId, true)
|
||
.then((result) => {
|
||
settled = true
|
||
return result
|
||
})
|
||
.catch((error) => {
|
||
// Surface rejected delete before polling so the regression cannot become an infinite wait.
|
||
settled = true
|
||
failure = error
|
||
return null
|
||
})
|
||
const ipcSamplesMs = []
|
||
let maxRendererTimerDriftMs = 0
|
||
let expectedTimerAt = performance.now() + 10
|
||
while (!settled) {
|
||
await new Promise((resolve) => window.setTimeout(resolve, 10))
|
||
const now = performance.now()
|
||
maxRendererTimerDriftMs = Math.max(maxRendererTimerDriftMs, now - expectedTimerAt)
|
||
const ipcStartedAt = performance.now()
|
||
await Promise.race([
|
||
window.api.repos.list(),
|
||
new Promise((_, reject) =>
|
||
window.setTimeout(() => reject(new Error('repos:list IPC timed out')), ipcTimeoutMs)
|
||
)
|
||
])
|
||
ipcSamplesMs.push(performance.now() - ipcStartedAt)
|
||
// Re-read clock after IPC so its separately recorded round-trip does not inflate the next drift sample.
|
||
expectedTimerAt = performance.now() + 10
|
||
}
|
||
const result = await deletion
|
||
if (failure) {
|
||
throw new Error(`removeWorktree rejected: ${String(failure)}`)
|
||
}
|
||
const postDeleteIpcStartedAt = performance.now()
|
||
await window.api.repos.list()
|
||
const finalState = store.getState()
|
||
return {
|
||
result,
|
||
totalMs: performance.now() - startedAt,
|
||
ipcSamplesMs,
|
||
postDeleteIpcMs: performance.now() - postDeleteIpcStartedAt,
|
||
maxRendererTimerDriftMs,
|
||
worktreeStillInStore: Object.values(finalState.worktreesByRepo)
|
||
.flat()
|
||
.some((worktree) => worktree.id === targetId),
|
||
residualTabCount: finalState.tabsByWorktree[targetId]?.length ?? 0,
|
||
residualBrowserTabCount: finalState.browserTabsByWorktree[targetId]?.length ?? 0,
|
||
residualOpenFileCount: finalState.openFiles.filter((file) => file.worktreeId === targetId)
|
||
.length
|
||
}
|
||
},
|
||
{ targetId: worktreeId, fallbackId: rootWorktreeId, ipcTimeoutMs: IPC_TIMEOUT_MS }
|
||
)
|
||
}
|
||
|
||
async function verifyDeletion(page, worktree, historyPath, measurement) {
|
||
if (!measurement.result?.ok) {
|
||
throw new Error(`removeWorktree failed: ${measurement.result?.error ?? 'unknown error'}`)
|
||
}
|
||
if (measurement.worktreeStillInStore) {
|
||
throw new Error('Deleted worktree remains in the renderer store')
|
||
}
|
||
if (
|
||
measurement.residualTabCount ||
|
||
measurement.residualBrowserTabCount ||
|
||
measurement.residualOpenFileCount
|
||
) {
|
||
throw new Error(
|
||
`Deleted worktree retained UI state: ${JSON.stringify({
|
||
tabs: measurement.residualTabCount,
|
||
browserTabs: measurement.residualBrowserTabCount,
|
||
openFiles: measurement.residualOpenFileCount
|
||
})}`
|
||
)
|
||
}
|
||
if (existsSync(worktree.path)) {
|
||
throw new Error(`Deleted worktree directory remains at ${worktree.path}`)
|
||
}
|
||
if (existsSync(historyPath)) {
|
||
throw new Error(`Live terminal history remains at ${historyPath}`)
|
||
}
|
||
await page.waitForFunction(
|
||
(id) =>
|
||
![...document.querySelectorAll('[data-worktree-id]')].some(
|
||
(element) => element.getAttribute('data-worktree-id') === id
|
||
),
|
||
worktree.id
|
||
)
|
||
}
|
||
|
||
async function runIteration(page, fixture, repoState, iteration, historyFiles) {
|
||
const worktree = await createMeasuredWorktree(page, repoState.repoId, iteration)
|
||
await assertWorktreeRowVisible(page, worktree.id)
|
||
branchFixture.seedBranchCleanupRepro(fixture.repoPath, worktree.path)
|
||
const historyPath = seedTerminalHistory(fixture.userDataPath, worktree.id, historyFiles)
|
||
const measurement = await measureDeletion(page, worktree.id, repoState.rootWorktreeId)
|
||
await verifyDeletion(page, worktree, historyPath, measurement)
|
||
return {
|
||
iteration,
|
||
totalMs: round(measurement.totalMs),
|
||
ipcLatencyMs: summarize(measurement.ipcSamplesMs),
|
||
postDeleteIpcMs: round(measurement.postDeleteIpcMs),
|
||
maxRendererTimerDriftMs: round(measurement.maxRendererTimerDriftMs)
|
||
}
|
||
}
|
||
|
||
async function verifyRestart(instanceConfig, fixture, port, repoId) {
|
||
const relaunched = launchDevInstance(instanceConfig, fixture, port)
|
||
let browser = null
|
||
try {
|
||
const connection = await connectToOrca(relaunched)
|
||
browser = connection.browser
|
||
const { page } = connection
|
||
const state = await page.evaluate(async (fixtureRepoId) => {
|
||
const store = window.__store
|
||
if (!store) {
|
||
throw new Error('window.__store is unavailable after restart')
|
||
}
|
||
await window.api.repos.list()
|
||
let recovery = { repoPresent: false, worktreeCount: 0 }
|
||
for (let attempt = 0; attempt < 60; attempt += 1) {
|
||
const owner = store.getState().settings?.activeRuntimeEnvironmentId ?? null
|
||
await store.getState().fetchRepos({ runtimeEnvironmentId: owner })
|
||
if (store.getState().repos.some((repo) => repo.id === fixtureRepoId)) {
|
||
await store.getState().fetchWorktrees(fixtureRepoId)
|
||
}
|
||
await new Promise((resolve) => window.setTimeout(resolve, 250))
|
||
recovery = {
|
||
repoPresent: store.getState().repos.some((repo) => repo.id === fixtureRepoId),
|
||
worktreeCount: store.getState().worktreesByRepo[fixtureRepoId]?.length ?? 0
|
||
}
|
||
if (recovery.repoPresent && recovery.worktreeCount > 0) {
|
||
break
|
||
}
|
||
}
|
||
return recovery
|
||
}, repoId)
|
||
if (!state.repoPresent || state.worktreeCount < 1) {
|
||
throw new Error(`Fixture repo did not recover after restart: ${JSON.stringify(state)}`)
|
||
}
|
||
await page.evaluate(async (fixtureRepoId) => {
|
||
await window.__store?.getState().removeProject(fixtureRepoId)
|
||
}, repoId)
|
||
} finally {
|
||
await browser?.close().catch(() => undefined)
|
||
await stopDevInstance(relaunched)
|
||
}
|
||
}
|
||
|
||
async function benchmarkInstance(instanceConfig, index, options) {
|
||
run(
|
||
process.platform === 'win32' ? 'pnpm.cmd' : 'pnpm',
|
||
['run', 'ensure:electron-runtime'],
|
||
instanceConfig.repoRoot
|
||
)
|
||
const fixture = createFixture(instanceConfig.label)
|
||
let delayedFetchServer, instance, browser
|
||
try {
|
||
delayedFetchServer = await branchFixture.startDelayedFetchServer(options.fetchDelayMs)
|
||
run('git', ['remote', 'set-url', 'origin', delayedFetchServer.url], fixture.repoPath)
|
||
const port = await findAvailablePort(CDP_START_PORT + index)
|
||
instance = launchDevInstance(instanceConfig, fixture, port)
|
||
const { browser: connectedBrowser, page } = await connectToOrca(instance)
|
||
browser = connectedBrowser
|
||
const repoState = await addFixtureRepo(page, fixture.repoPath)
|
||
const iterations = []
|
||
for (let iteration = 1; iteration <= options.iterations; iteration += 1) {
|
||
const result = await runIteration(page, fixture, repoState, iteration, options.historyFiles)
|
||
iterations.push(result)
|
||
console.log(
|
||
`[${instanceConfig.label}] ${iteration}/${options.iterations}: ${result.totalMs}ms total, ` +
|
||
`${result.ipcLatencyMs.max}ms max main IPC`
|
||
)
|
||
}
|
||
await browser.close()
|
||
browser = null
|
||
await stopDevInstance(instance)
|
||
// Use fresh CDP ports so teardown cannot leave retries attaching to a dying endpoint.
|
||
await verifyRestart(
|
||
instanceConfig,
|
||
fixture,
|
||
await findAvailablePort(port + 1),
|
||
repoState.repoId
|
||
)
|
||
return {
|
||
label: instanceConfig.label,
|
||
repoRoot: instanceConfig.repoRoot,
|
||
historyFiles: options.historyFiles,
|
||
fetchDelayMs: options.fetchDelayMs,
|
||
iterations,
|
||
summary: summarize(iterations.map((entry) => entry.totalMs)),
|
||
ipcSummary: summarize(iterations.flatMap((entry) => entry.ipcLatencyMs.samples)),
|
||
restartPassed: true,
|
||
fixtureRoot: options.keepFixture ? fixture.root : undefined
|
||
}
|
||
} finally {
|
||
await browser?.close().catch(() => undefined)
|
||
if (instance) {
|
||
await stopDevInstance(instance)
|
||
}
|
||
await delayedFetchServer?.close()
|
||
if (!options.keepFixture) {
|
||
await rm(fixture.root, {
|
||
recursive: true,
|
||
force: true,
|
||
maxRetries: 10,
|
||
retryDelay: 250
|
||
})
|
||
}
|
||
}
|
||
}
|
||
|
||
async function findAvailablePort(startPort) {
|
||
for (let port = startPort; port < startPort + 100; port += 1) {
|
||
if (await isPortAvailable(port)) {
|
||
return port
|
||
}
|
||
}
|
||
throw new Error(`No free CDP port found in ${startPort}-${startPort + 99}`)
|
||
}
|
||
|
||
function isPortAvailable(port) {
|
||
return new Promise((resolve) => {
|
||
const server = net.createServer()
|
||
server.once('error', () => resolve(false))
|
||
server.once('listening', () => server.close(() => resolve(true)))
|
||
server.listen(port, '127.0.0.1')
|
||
})
|
||
}
|
||
|
||
async function stopDevInstance(instance) {
|
||
// Check signalCode too: signal-exited children retain null exitCode and otherwise burn another 8s kill race.
|
||
if (instance.child.exitCode !== null || instance.child.signalCode !== null) {
|
||
return
|
||
}
|
||
if (process.platform === 'win32') {
|
||
spawnSync('taskkill.exe', ['/PID', String(instance.child.pid), '/T', '/F'], { stdio: 'ignore' })
|
||
return
|
||
}
|
||
killDevInstanceTree(instance.child, 'SIGINT')
|
||
const exited = await Promise.race([
|
||
new Promise((resolve) => instance.child.once('exit', () => resolve(true))),
|
||
delay(8_000).then(() => false)
|
||
])
|
||
if (!exited) {
|
||
killDevInstanceTree(instance.child, 'SIGKILL')
|
||
}
|
||
}
|
||
|
||
/** POSIX: signal the whole group, or the launcher's Electron/Vite grandchildren survive and keep the
|
||
* CDP port and fixture directory busy. */
|
||
function killDevInstanceTree(child, signal) {
|
||
try {
|
||
process.kill(-child.pid, signal)
|
||
} catch {
|
||
child.kill(signal)
|
||
}
|
||
}
|
||
|
||
function summarize(values) {
|
||
const samples = values.map((value) => round(value)).sort((a, b) => a - b)
|
||
if (samples.length === 0) {
|
||
return { count: 0, median: 0, p95: 0, max: 0, samples }
|
||
}
|
||
return {
|
||
count: samples.length,
|
||
median: percentile(samples, 0.5),
|
||
p95: percentile(samples, 0.95),
|
||
max: samples.at(-1),
|
||
samples
|
||
}
|
||
}
|
||
|
||
function percentile(sorted, fraction) {
|
||
return sorted[Math.min(sorted.length - 1, Math.ceil(sorted.length * fraction) - 1)]
|
||
}
|
||
|
||
function round(value) {
|
||
return Math.round(value * 100) / 100
|
||
}
|
||
|
||
function delay(ms) {
|
||
return new Promise((resolve) => setTimeout(resolve, ms))
|
||
}
|
||
|
||
function printComparison(results) {
|
||
console.log('\nWorktree deletion results')
|
||
console.table(
|
||
results.map((result) => ({
|
||
instance: result.label,
|
||
'delete median ms': result.summary.median,
|
||
'delete p95 ms': result.summary.p95,
|
||
'main IPC p95 ms': result.ipcSummary.p95,
|
||
'main IPC max ms': result.ipcSummary.max,
|
||
restart: result.restartPassed ? 'pass' : 'fail'
|
||
}))
|
||
)
|
||
if (results.length === 2) {
|
||
const [baseline, candidate] = results
|
||
const percent = round(
|
||
((baseline.summary.median - candidate.summary.median) / baseline.summary.median) * 100
|
||
)
|
||
console.log(
|
||
`${candidate.label} median deletion is ${Math.abs(percent)}% ${
|
||
percent >= 0 ? 'faster' : 'slower'
|
||
} than ${baseline.label}.`
|
||
)
|
||
}
|
||
}
|
||
|
||
const options = parseArgs(process.argv)
|
||
mkdirSync(resultsRoot, { recursive: true })
|
||
const results = []
|
||
for (const [index, instance] of options.instances.entries()) {
|
||
results.push(await benchmarkInstance(instance, index, options))
|
||
}
|
||
const artifact = {
|
||
benchmark: 'worktree-deletion-dev',
|
||
createdAt: new Date().toISOString(),
|
||
platform: process.platform,
|
||
arch: process.arch,
|
||
results
|
||
}
|
||
const artifactPath = path.join(
|
||
resultsRoot,
|
||
`worktree-deletion-${new Date().toISOString().replaceAll(/[:.]/g, '-')}.json`
|
||
)
|
||
writeFileSync(artifactPath, `${JSON.stringify(artifact, null, 2)}\n`)
|
||
printComparison(results)
|
||
console.log(`Artifact: ${artifactPath}`)
|