Files
orca/src/main/azure-devops/pull-request-mappers.ts
T
Neil 77f23b013f refactor(shared): drop the shared/types barrel and import from the real modules (#14447)
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as
a re-export barrel so the import sites did not have to change. This removes
the barrel: every consumer now imports from the module that actually declares
the type, and `src/shared/types.ts` is deleted.

Barrels hide where a type lives, make every consumer look like it depends on
the whole domain, and let an unrelated edit invalidate a module that ~2,000
files transitively import.

2,323 import declarations across 2,321 files. Rewritten mechanically: each
specifier was resolved to an absolute path via the TypeScript AST and
recomputed, rather than string-substituted, so alias forms (`@/../../shared/
types`) and per-specifier `type` modifiers survive.

Four cases the mechanical pass had to handle, each found by a gate rather than
by reading the diff:

- Modules inside `src/shared` import the barrel as `./types`, not
  `shared/types`. A pre-filter on the latter string skipped 176 of them and
  left imports dangling at a deleted file, which surfaced as confusing
  `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>`
  errors rather than "module not found".
- The barrel RENAMED one type on the way through
  (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name
  in the owning module has to be re-aliased at each consumer.
- Three test files put `;(globalThis as ...)` on the line after the import.
  TypeScript parses that `;` as the import statement's terminator, so
  replacing through `statement.getEnd()` deletes it and breaks ASI. The
  rewrite now stops at the module specifier.
- A file that already imported directly from a module got a SECOND import
  from it, because the barrel re-exported those same names — which trips
  `import/no-duplicates` under `--deny-warnings`. A post-pass merges
  declarations sharing a specifier and type-only-ness; the `import type` plus
  `import` pair from one module is left alone, since that form is allowed.

Splitting one barrel import into several genuinely adds lines, which pushed
`terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character
import must wrap, and neither local type collapses onto one line (101 and 116
characters). Rather than contort a type declaration to fit a line budget,
`collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` —
they are pure structural operations on the layout tree and independent of PTY
ownership. `visible-worktrees.ts` similarly loses its own mini-barrel
re-export of `isDefaultBranchWorkspace`, with the four real consumers
repointed at the declaring module. No `max-lines` bypass added.

Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted
first — these projects are `composite: true` and reuse stale caches); the full
`pnpm lint` green, not just bare oxlint — the narrower local check is what let
the duplicate imports reach CI; max-lines ratchet OK at 344.
2026-08-13 22:48:24 -07:00

128 lines
3.2 KiB
TypeScript

import type { CheckStatus, PRMergeableState } from '../../shared/github/pull-request-types'
export type RawAzureDevOpsStatus = {
state?: string | null
}
export type RawAzureDevOpsPullRequest = {
pullRequestId?: number
codeReviewId?: number
title?: string | null
status?: string | null
isDraft?: boolean | null
creationDate?: string | null
closedDate?: string | null
mergeStatus?: string | null
sourceRefName?: string | null
lastMergeSourceCommit?: {
commitId?: string | null
} | null
statuses?: RawAzureDevOpsStatus[] | null
_links?: {
web?: {
href?: string | null
} | null
} | null
}
export type AzureDevOpsPullRequestInfo = {
number: number
title: string
state: 'open' | 'closed' | 'merged' | 'draft'
url: string
status: CheckStatus
updatedAt: string
mergeable: PRMergeableState
headSha?: string
}
export function mapAzureDevOpsPullRequestState(
raw: Pick<RawAzureDevOpsPullRequest, 'isDraft' | 'status'>
): AzureDevOpsPullRequestInfo['state'] {
const status = raw.status?.trim().toLowerCase()
if (status === 'completed') {
return 'merged'
}
if (status === 'abandoned') {
return 'closed'
}
if (raw.isDraft) {
return 'draft'
}
return 'open'
}
export function mapAzureDevOpsMergeable(mergeStatus: string | null | undefined): PRMergeableState {
switch (mergeStatus?.trim().toLowerCase()) {
case 'succeeded':
return 'MERGEABLE'
case 'conflicts':
return 'CONFLICTING'
case undefined:
default:
return 'UNKNOWN'
}
}
function classifyAzureDevOpsStatus(state: string | null | undefined): CheckStatus {
switch (state?.trim().toLowerCase()) {
case 'succeeded':
case 'success':
return 'success'
case 'failed':
case 'error':
case 'rejected':
case 'canceled':
case 'cancelled':
return 'failure'
case 'pending':
case 'inprogress':
case 'in_progress':
case 'queued':
case 'running':
return 'pending'
case undefined:
default:
return 'neutral'
}
}
export function deriveAzureDevOpsStatus(statuses: readonly RawAzureDevOpsStatus[]): CheckStatus {
if (statuses.length === 0) {
return 'neutral'
}
const classified = statuses.map((status) => classifyAzureDevOpsStatus(status.state))
if (classified.includes('failure')) {
return 'failure'
}
if (classified.includes('pending')) {
return 'pending'
}
if (classified.every((status) => status === 'success')) {
return 'success'
}
return 'neutral'
}
export function mapAzureDevOpsPullRequest(
raw: RawAzureDevOpsPullRequest,
status: CheckStatus,
webBaseUrl: string
): AzureDevOpsPullRequestInfo | null {
if (typeof raw.pullRequestId !== 'number' || !raw.title) {
return null
}
const headSha = raw.lastMergeSourceCommit?.commitId?.trim()
return {
number: raw.pullRequestId,
title: raw.title,
state: mapAzureDevOpsPullRequestState(raw),
url:
raw._links?.web?.href ?? `${webBaseUrl.replace(/\/+$/, '')}/pullrequest/${raw.pullRequestId}`,
status,
updatedAt: raw.closedDate ?? raw.creationDate ?? '',
mergeable: mapAzureDevOpsMergeable(raw.mergeStatus),
...(headSha ? { headSha } : {})
}
}