mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 00:57:45 +00:00
Brennan Benson
418c601d20
* Start worktree.create's agent through the launch executor The host's worktree.create handler now starts a requested agent (startupAgent, or a linked startupDraft) through executeAgentLaunch instead of calling the create directly. Nothing on the wire changes: the request, the reply and agentTerminalHandle are the same, the agent is still the workspace's startup terminal whatever the chat default says, and the create still delivers the text itself (folded into the command at any length, a follow-up for agents that read it after start, and the draft pasted unsent). Adds three host-internal executor inputs: terminalOnly, the legacy-host prompt policy, and a shared entry (createWorktreeWithStartupAgent) that host producers can call in place of createManagedWorktree. * Keep a linked-draft create recording only the agent it actually started Problem: after worktree.create moved onto the launch executor, a create from a linked issue (phone "create from issue", or a raw worktree.create with startupDraft) could differ from before in two narrow cases. When the draft's agent came from the settings default or from detection and its launch command could not be built (for example unbalanced quotes in the saved agent arguments), the workspace was recorded as created with that agent even though it never started, and a background create opened no terminal at all instead of its plain shell. When no agent was found, detection ran twice (an extra SSH round trip on remote repos). User-facing change: none intended; both cases now behave exactly as before the executor move. Mechanism: - The entry hands the draft's chosen agent to the create as a main-internal startupDraftAgent, which steers only the draft; createdWithAgent stays what the caller sent. A draft that resolves no agent is created without the draft, so the create does not detect again. - AgentLaunchExecution is a discriminated union: every normal launch must bring its surface factory, and a legacy-host launch must be terminal-only, bring a workspace factory, and cannot bring surfaces. The runtime guards the types replace are gone; the target kind is checked before any create. - Legacy-host receipts follow the delivery module's rule: a blank prompt is no prompt, a submit folded into the launch command is handed-to-terminal, a post-start send the create does not await is unconfirmed (host-internal), a draft is not-delivered. - The no-agent error lives with the legacy-host policy and is caught only by the shared entry. - Tests: a real-runtime parity test (stored agent, terminal spawns, detection count vs the create alone, including the unbuildable plan), exact-argument checks over every non-agent startup field, compile-time checks for the union, and direct tests of the draft agent resolver. * Say which creates still bypass the shared agent entry Two comments stated that headless automations and federation already go through createWorktreeWithStartupAgent; both still call createManagedWorktree directly. Reword them as the plan. Comment-only. * Start orchestration workers and remote workers through the launch executor A fresh worker (new worktree or existing, terminal or structured) and a federated worker on its receiving host now start their agent through executeAgentLaunch with the worker's own workspace and surface factories. The worker hands in the mode it decided before its dispatch record existed (decidedMode), so the host is asked once and the stored receipt is the one that ran. Effects, setup receipt, stage rows and their order are unchanged; a refused structured worker still fails rather than becoming a terminal. * Tighten the worker launch contract and discard a worker session a later launch step strands - decidedMode is now exclusive with terminalOnly and callerRendersStructured in the type, labelled temporary until one planner settles every launch. - connectionId's doc says what is true: the executor carries it and nothing reads it yet. - A worker launch that throws after its structured session exists discards that session itself, since the caller only tears down a returned placement. - A federated create refuses a launch with no startup agent and narrows repo/name before recording its first stage. - Tests: exact federated existing-path stages, a created-worktree host refusal that starts a worker terminal, and the stranded-session discard. * Say exactly which inputs a decided launch mode refuses, and pin the refusal at compile time