mirror of
https://github.com/stablyai/orca.git
synced 2026-10-21 00:03:46 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
93 lines
2.7 KiB
TypeScript
93 lines
2.7 KiB
TypeScript
import { execFile, execFileSync } from 'node:child_process'
|
|
|
|
const PWSH_SYNC_PROBE_TIMEOUT_MS = 5000
|
|
const PWSH_WARMUP_PROBE_TIMEOUT_MS = 30_000
|
|
const PWSH_NEGATIVE_CACHE_TTL_MS = 30_000
|
|
|
|
type PwshAvailabilityCache =
|
|
| { available: true }
|
|
| { available: false; cachedAt: number; retryable: boolean }
|
|
|
|
let pwshAvailableCache: PwshAvailabilityCache | null = null
|
|
let pwshWarmupInFlight: Promise<boolean> | null = null
|
|
|
|
function isCacheFresh(cache: PwshAvailabilityCache): boolean {
|
|
return (
|
|
cache.available || !cache.retryable || Date.now() - cache.cachedAt < PWSH_NEGATIVE_CACHE_TTL_MS
|
|
)
|
|
}
|
|
|
|
function isTimeoutError(error: unknown): boolean {
|
|
return (
|
|
typeof error === 'object' &&
|
|
error !== null &&
|
|
'code' in error &&
|
|
(error as NodeJS.ErrnoException).code === 'ETIMEDOUT'
|
|
)
|
|
}
|
|
|
|
function cachePwshProbeFailure(error: unknown): void {
|
|
// Why: pwsh.exe cold starts can exceed the sync timeout; do not let one slow
|
|
// .NET startup disable the user's PowerShell 7 preference for the daemon.
|
|
if (isTimeoutError(error)) {
|
|
pwshAvailableCache = null
|
|
return
|
|
}
|
|
pwshAvailableCache = { available: false, cachedAt: Date.now(), retryable: true }
|
|
}
|
|
|
|
/**
|
|
* Check whether pwsh.exe is available on this Windows machine.
|
|
* Positive results are cached for the process lifetime; negative results are
|
|
* retried so transient cold-start failures cannot outlive the daemon.
|
|
*/
|
|
export function isPwshAvailable(): boolean {
|
|
if (pwshAvailableCache && isCacheFresh(pwshAvailableCache)) {
|
|
return pwshAvailableCache.available
|
|
}
|
|
|
|
if (process.platform !== 'win32') {
|
|
pwshAvailableCache = { available: false, cachedAt: Date.now(), retryable: false }
|
|
return false
|
|
}
|
|
|
|
try {
|
|
execFileSync('pwsh.exe', ['-Version'], {
|
|
stdio: ['pipe', 'pipe', 'pipe'],
|
|
timeout: PWSH_SYNC_PROBE_TIMEOUT_MS
|
|
})
|
|
pwshAvailableCache = { available: true }
|
|
} catch (error) {
|
|
cachePwshProbeFailure(error)
|
|
}
|
|
|
|
return pwshAvailableCache?.available ?? false
|
|
}
|
|
|
|
export function warmPwshAvailabilityCache(): Promise<boolean> {
|
|
if (pwshAvailableCache?.available) {
|
|
return Promise.resolve(true)
|
|
}
|
|
if (process.platform !== 'win32') {
|
|
pwshAvailableCache = { available: false, cachedAt: Date.now(), retryable: false }
|
|
return Promise.resolve(false)
|
|
}
|
|
if (pwshWarmupInFlight) {
|
|
return pwshWarmupInFlight
|
|
}
|
|
|
|
pwshWarmupInFlight = new Promise((resolve) => {
|
|
execFile('pwsh.exe', ['-Version'], { timeout: PWSH_WARMUP_PROBE_TIMEOUT_MS }, (error) => {
|
|
pwshWarmupInFlight = null
|
|
if (!error) {
|
|
pwshAvailableCache = { available: true }
|
|
resolve(true)
|
|
return
|
|
}
|
|
cachePwshProbeFailure(error)
|
|
resolve(false)
|
|
})
|
|
})
|
|
return pwshWarmupInFlight
|
|
}
|