mirror of
https://github.com/stablyai/orca.git
synced 2026-10-21 08:03:33 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
114 lines
3.5 KiB
TypeScript
114 lines
3.5 KiB
TypeScript
import { join, resolve } from 'node:path'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const { handleMock } = vi.hoisted(() => ({
|
|
handleMock: vi.fn()
|
|
}))
|
|
|
|
vi.mock('electron', () => ({
|
|
ipcMain: {
|
|
handle: handleMock
|
|
}
|
|
}))
|
|
|
|
vi.mock('fs/promises', () => ({
|
|
stat: vi.fn()
|
|
}))
|
|
|
|
vi.mock('@parcel/watcher', () => ({
|
|
subscribe: vi.fn()
|
|
}))
|
|
|
|
vi.mock('./filesystem-watcher-wsl', () => ({
|
|
createWslWatcher: vi.fn()
|
|
}))
|
|
|
|
vi.mock('../providers/ssh-filesystem-dispatch', () => ({
|
|
getSshFilesystemProvider: vi.fn()
|
|
}))
|
|
|
|
import { closeAllWatchers, registerFilesystemWatcherHandlers } from './filesystem-watcher'
|
|
import { stat } from 'node:fs/promises'
|
|
import { subscribe as subscribeParcelWatcher } from '@parcel/watcher'
|
|
import type { Event as WatcherEvent } from '@parcel/watcher'
|
|
|
|
type HandlerMap = Record<string, (_event: unknown, args: unknown) => Promise<unknown> | unknown>
|
|
|
|
describe('local filesystem watcher large batches', () => {
|
|
const handlers: HandlerMap = {}
|
|
|
|
beforeEach(async () => {
|
|
vi.useRealTimers()
|
|
handleMock.mockReset()
|
|
vi.mocked(stat).mockReset()
|
|
vi.mocked(subscribeParcelWatcher).mockReset()
|
|
for (const key of Object.keys(handlers)) {
|
|
delete handlers[key]
|
|
}
|
|
handleMock.mockImplementation((channel, handler) => {
|
|
handlers[channel] = handler
|
|
})
|
|
registerFilesystemWatcherHandlers()
|
|
await closeAllWatchers()
|
|
})
|
|
|
|
it('accepts a large local watcher event batch without overflowing V8 arguments', async () => {
|
|
vi.useFakeTimers()
|
|
vi.mocked(stat).mockResolvedValue({ isDirectory: () => true } as never)
|
|
const worktreePath = resolve('/tmp/repo')
|
|
let watcherCallback: ((err: Error | null, events: WatcherEvent[]) => void) | undefined
|
|
vi.mocked(subscribeParcelWatcher).mockImplementation(async (_root, callback) => {
|
|
watcherCallback = callback as typeof watcherCallback
|
|
return { unsubscribe: vi.fn() } as never
|
|
})
|
|
|
|
await handlers['fs:watchWorktree'](
|
|
{ sender: { isDestroyed: () => false, send: vi.fn(), once: vi.fn(), id: 1 } },
|
|
{ worktreePath }
|
|
)
|
|
|
|
const events = Array.from(
|
|
{ length: 200_000 },
|
|
(_, index): WatcherEvent => ({ type: 'delete', path: join(worktreePath, `file-${index}`) })
|
|
)
|
|
|
|
expect(() => watcherCallback?.(null, events)).not.toThrow()
|
|
await closeAllWatchers()
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
it('emits one overflow event for oversized native watcher batches', async () => {
|
|
vi.useFakeTimers()
|
|
vi.mocked(stat).mockResolvedValue({ isDirectory: () => true } as never)
|
|
let watcherCallback: ((err: Error | null, events: WatcherEvent[]) => void) | undefined
|
|
vi.mocked(subscribeParcelWatcher).mockImplementation(async (_root, callback) => {
|
|
watcherCallback = callback as typeof watcherCallback
|
|
return { unsubscribe: vi.fn() } as never
|
|
})
|
|
const worktreePath = resolve('/tmp/repo')
|
|
const sender = { isDestroyed: () => false, send: vi.fn(), once: vi.fn(), id: 1 }
|
|
|
|
await handlers['fs:watchWorktree']({ sender }, { worktreePath })
|
|
watcherCallback?.(
|
|
null,
|
|
Array.from(
|
|
{ length: 5_001 },
|
|
(_, index): WatcherEvent => ({
|
|
type: 'update',
|
|
path: join(worktreePath, `file-${index}.txt`)
|
|
})
|
|
)
|
|
)
|
|
|
|
await vi.advanceTimersByTimeAsync(150)
|
|
|
|
expect(stat).toHaveBeenCalledTimes(1)
|
|
expect(sender.send).toHaveBeenCalledWith('fs:changed', {
|
|
worktreePath,
|
|
events: [{ kind: 'overflow', absolutePath: worktreePath }]
|
|
})
|
|
await closeAllWatchers()
|
|
vi.useRealTimers()
|
|
})
|
|
})
|