mirror of
https://github.com/stablyai/orca.git
synced 2026-09-23 16:02:24 +00:00
Neil
4882eeb8ac
* Revert "fix terminal attribution shim removal edge cases (#14187)"
This reverts 585dd6d3a9. Re-landed in the next commit without the host capability gate. Nothing shipped with it, so no migration constraint.
* rm git shim: neutralize stale wrappers without a host gate
Re-lands the cleanup half of #14187: pass-through tombstones for retained wrapper paths, env/PATH scrubbing at every spawn owner, and the retired setting drop.
Only writes tombstones when the legacy directory already exists, so a clean install no longer has it created. Leaves out the terminal.attribution-removed.v1 capability gate: the tombstone neutralizes each host locally, so refusing terminal create/split against older hosts denied service without adding cleanup.
* rm git shim: surface neutralization failures and fix rollback marker
Readiness review follow-ups: warn on each failed attempt and on give-up (was silent and undiagnosable); write a VERSION marker distinct from the retired shim's '7' so a rolled-back build rewrites its own wrappers; clear a captured ORCA_REAL_* path that no longer exists so the cmd wrapper's where.exe fallback can run; stop a locked temp file masking the real error. Adds retry-exhaustion coverage.
* rm git shim: pin the cmd fallback order and correct the give-up count
Round-2 review follow-ups: string-pin that a stale ORCA_REAL_* is cleared before the where.exe fallback, and count the initial attempt in the give-up warning so it agrees with the per-attempt line.
* rm git shim: keep the split-failure toast
The revert took a toast that #14187 added alongside the gate but which stands on its own: without it a failed remote split only reaches the console and the pane silently never appears. Also pins attempt ordinals in the retry-exhaustion test.
52 lines
1.6 KiB
TypeScript
52 lines
1.6 KiB
TypeScript
import { remoteRuntimeUnavailableError } from './remote-runtime-request-frames'
|
|
import { takeRemoteRuntimePreparedRequest } from './remote-runtime-prepared-request-admission'
|
|
import { finishSharedControlSubscription } from './remote-runtime-shared-control-state'
|
|
import type {
|
|
SharedControlLogicalSubscription,
|
|
SharedControlPendingRequest
|
|
} from './remote-runtime-shared-control-types'
|
|
|
|
export function sendSharedControlRequest(args: {
|
|
pendingRequests: Map<string, SharedControlPendingRequest<unknown>>
|
|
requestId: string
|
|
send: (serializedRequest: string) => boolean
|
|
reject: (requestId: string, error: Error) => void
|
|
}): void {
|
|
const pending = args.pendingRequests.get(args.requestId)
|
|
if (!pending) {
|
|
return
|
|
}
|
|
const serializedRequest = takeRemoteRuntimePreparedRequest(pending)
|
|
if (serializedRequest === null || !args.send(serializedRequest)) {
|
|
args.reject(args.requestId, remoteRuntimeUnavailableError())
|
|
}
|
|
}
|
|
|
|
export function sendSharedControlSubscription(args: {
|
|
subscriptions: Map<string, SharedControlLogicalSubscription<unknown>>
|
|
subscription: SharedControlLogicalSubscription<unknown>
|
|
deviceToken: string
|
|
send: (payload: unknown) => boolean
|
|
}): void {
|
|
if (args.subscription.closed || args.subscription.sent) {
|
|
return
|
|
}
|
|
if (
|
|
args.send({
|
|
id: args.subscription.requestId,
|
|
deviceToken: args.deviceToken,
|
|
method: args.subscription.method,
|
|
params: args.subscription.params
|
|
})
|
|
) {
|
|
args.subscription.sent = true
|
|
return
|
|
}
|
|
finishSharedControlSubscription(
|
|
args.subscriptions,
|
|
args.subscription,
|
|
true,
|
|
remoteRuntimeUnavailableError()
|
|
)
|
|
}
|