mirror of https://github.com/stablyai/orca.git synced 2026-10-31 00:57:45 +00:00

Files

T

hwantageandNeil 483573f0b9 fix(browser): focus newly opened image tabs (#34127 )

* fix(browser): focus newly opened image tabs

Focus the window before the webview so Command+W closes the new
image tab instead of the original tab after a plain image click.

Add tests for focus order, image loading, and close-shortcut forwarding.

Fixes #34114

* test(browser): verify image tab focus with native keyboard input

* refactor(ci): keep browser E2E routes within registry size limit

* fix(ci): enable background launch for native browser regression

* test(ci): include browser routes in isolated detector fixture

---------

Co-authored-by: Neil <neil@stably.ai>

2026-10-26 22:52:40 -07:00

1.3 KiB

Raw Blame History

Automated App Launches

Set ORCA_BACKGROUND_LAUNCH=1 for all tests and agent-launched apps. Use orca-app.ts / orca-restart.ts; raw electron.launch() calls must pass the env explicitly.
Keep windows hidden and drive renderers through Playwright CDP. Never reveal windows, steal focus, or activate the app on the user's desktop. @headful is for tests requiring real pixels; it does not authorize foreground activation. Never set ORCA_E2E_FOREGROUND=1 on the desktop.
Run native-focus and visible-window tests only on an isolated display or CI.
Rebuild modified launch-policy code before launching; stale wrappers are unsafe.
Only the terminal perf and native IBus fixtures, and the guarded native browser image-focus test, may explicitly present windows on their isolated hosted-CI Xvfb displays. Preserve their guards and keep ORCA_BACKGROUND_LAUNCH=1; do not generalize these exceptions to other fixtures or production launch policy. Background terminal panes stay hidden.
The browser image-focus test also permits an isolated Docker Xvfb display, with ORCA_E2E_BROWSER_NATIVE_XVFB=1; desktop runs must skip it.

1.3 KiB Raw Blame History

Automated App Launches

1.3 KiB

Raw Blame History