921882619e
* fix: retire closed editor models from the app shell * test(editor): use checked Monaco attachment calls * Preserve bounded editor view caches when retiring closed models * docs(editor): describe batched model retirement * fix(editor): preserve cleanup work across registry replacement * fix(editor): build editor model URIs with the file scheme Monaco keys its model registry by `uri.toString()`, and both `@monaco-editor/react` (via the `path` prop) and the closed-tab disposal path built that key with `Uri.parse`. On Windows a raw path such as `C:\repo\a.ts` parses as scheme `c`, which fails the scheme gate in `modelService._schemaShouldMaintainUndoRedoElements`, so closed-file undo history was dropped for every file at any size — not only the large files the tradeoff note covers. Add `toEditorModelUri`, the one filesystem-path -> model-key function, built on `Uri.file` so the result always carries the `file:` scheme and re-parses to itself. Route model creation, disposal lookup and the still-open ownership comparison through it so all three agree; a divergence there would dispose a model an open editor is still editing. --------- Co-authored-by: m4air <m4air@Mac.localdomain> Co-authored-by: Neil <neil@stably.ai>
Closed editor model lifetime
Closing the final editor, or closing a file while every editor panel is hidden, can leave its Monaco text model registered for the renderer's remaining lifetime. The old cleanup hook lived in the conditionally mounted EditorPanel: it disappeared before observing the final close and missed closes while absent. MonacoEditor uses keepCurrentModel, so unmounting the widget does not provide the missing cleanup.
The fix subscribes from the app shell and lazily receives the model registry from the existing monaco-setup load. It retires only closed tab owners. It preserves live same-URI editors, replacement model objects, generated diff namespaces, attached models until detachment, and caches written by a reopened owner during a disposal callback. Existing scroll, selection, preview, and PDF caches retain their separate 20-entry LRU lifetime. No open tab, dirty draft, or live editor history is pruned. Closed-file undo follows Monaco's existing bounded policy; it is not unlimited (see below).
Measured result
| Actual source control | Before | Fixed |
|---|---|---|
| Eight distinct last-file closes | 8 registered closed models; 2,097,208 logical characters; 0 open files | 0 registered models; 0 open files |
| Close with another editor still mounted | Closed model disposed; sibling preserved | Same |
| Close while hidden, then open another editor | Old closed model remains; 2 models for 1 open file | Old model disposed; 1 model for 1 open file |
| Normal terminal/editor switch | Original open model preserved | Same |
All four controls pass with their stated before/fixed expectations on both graphs and both runtimes: 32 comparative cases, Node 24.20.0 and Electron 43.7.0 / Node 24.21.0. Reports are worktree-*-results.json and main-*-results.json. Contents use eight distinct fixture paths and 256 KiB of logical characters per model; this is a controlled amplification, not a field file-size measurement or heap-byte estimate.
This explains a concrete renderer retention mechanism relevant to #12845. The same conditional panel, hook placement, and keepCurrentModel chain exists in reported v1.4.170; source-versions.json records four historical source hashes and matching line numbers. That comparison is static, not an execution of the historical application. It does not establish which allocations caused #12845's reported heap, or the process and cause of #19831.
Ownership and regression coverage
The 27 permanent cases across five suites in closed-editor-model-{lifetime,reentrancy,registry,shell}.test.* and closed-editor-view-state-retention.test.ts use actual installed Monaco models and store close actions. They cover final/hidden panel closure, live siblings and shared URIs, replacement model identities, attachment/detachment, reopening, registry removal/replacement, reentrant registry changes, diff prefixes, bounded caches, and ordinary edit closes without a global registry scan. Together with the three existing disposal/cache suites, 47 tests pass. The fixture exercises Monaco's real attachment ports without creating a native editor widget.
The startup routing suite now also guards the production app-shell hook placement: deleting that call fails the test. All 75 selected tests across nine suites pass. Full Web typechecking currently reports one unrelated existing unused NativeChatMessage import in NativeChatMessageList.windowing.test.tsx; it reports no errors in the changed files.
Registry notifications cancel obsolete queued callbacks but preserve captured model identities and attached-model listeners. A temporary missing registry defers cleanup until registration returns; an interrupted disposal batch is retried. The identity fence prevents that retry from disposing a successor at the same URI. Controller teardown still cancels that controller's ownership and listeners; this audit does not claim to reconcile all preexisting models after an app-shell HMR remount.
Closed-file undo decision
Keep Monaco's bounded closed-file undo store rather than retaining every edited model indefinitely, following the same design used by VS Code's model service. Installed Monaco keeps about 20 MiB of closed-file undo data. Tests confirm ordinary POSIX paths and file:///C:/... paths restore undo when reopened with matching contents. Large files (over 10 MiB of text in the fixture) and raw Windows C:/... paths do not. Those cases lose undo after close/reopen, including final/hidden tabs whose models previously leaked. Existing view-state caches remain intact within their 20-entry budget. This is a deliberate bounded-memory tradeoff, not zero user-visible risk.
Source fences and independent main publication
source-versions.json fences 1,021 repository paths: the complete loaded repository graph of the comparative proof plus selected static wiring/caller files. Vite rejects any additional repository module under src/ or config/. Package code is not part of that repository-graph claim: twelve separate dependency hashes pin the installed package metadata and relevant Monaco model/registry/event and Zustand store implementations.
- Worktree baseline:
f142544a8653eedab2eec0237a9005001497b2f5. - Publication main:
291b4ddd6f1c1af480169885e0fda7f9c78ff053. fix.patchcontains only the eight product changes, including two new modules. The loader reverses it from the checked-out fixed sources to reconstruct baseline behavior.main-context.patchreconstructs 22 unrelated context differences, including two paths absent on main. It is proof scaffolding; do not apply it as a product patch.- Main retains its unrelated
registerShellMarkdownAliasesimport/call inmonaco-setup.ts. The standalone product patch preserves both lines. - The loader checks each before/fixed hash, refuses source/dependency drift, normalizes CRLF to LF, and supports both the working checkout and an independently published main checkout.
loader-results.jsonrecords synthetic CRLF and simulated-main-checkout controls for all four graph/variant combinations.
The comparative test executes the actual legacy surface, old/new cleanup hook, disposal functions, store close action and model registry. It supplies controlled Panel/Shell ports and a fixture store to the hook. Actual app-shell placement, first lazy registration, conditional panel callers and keepCurrentModel wiring are source-fenced static checks; it does not render the entire application or exercise HMR through Vite itself. It opens no Electron window, starts no native editor widget, and measures no RSS, heap bytes, or incident allocation rate.
Review follow-up
The registry-transition regression is covered by four new cases. The uninformative cold-registry fixture assertion was removed, and this audit's product patch, source hashes, loader controls, and all eight comparative reports were regenerated from the current sources. The audit directory is now explicitly allowed in .gitignore.
Reproduce
From the repository root with its installed dependencies:
ORCA_BACKGROUND_LAUNCH=1 pnpm exec vitest run --config docs/audits/closed-editor-model-lifetime/vitest.config.mjs
node docs/audits/closed-editor-model-lifetime/loader-controls.cjs
The default is ORCA_CLOSED_MODEL_GRAPH=worktree and ORCA_CLOSED_MODEL_VARIANT=fixed. Repeat with each graph (worktree, main) and variant (before, fixed). Set these environment variables using the syntax of your shell; the runner and path handling are platform-neutral. Set ORCA_CLOSED_MODEL_OUTPUT or ORCA_CLOSED_MODEL_LOADER_OUTPUT to an output path to avoid replacing checked-in reports.
For Electron, run the installed Electron binary with ELECTRON_RUN_AS_NODE=1, ORCA_BACKGROUND_LAUNCH=1, --no-experimental-webstorage --expose-gc, followed by node_modules/vitest/vitest.mjs run --config docs/audits/closed-editor-model-lifetime/vitest.config.mjs and the same graph/variant environment. This uses Electron's Node runtime without creating a window.