mirror of
https://github.com/stablyai/orca.git
synced 2026-10-20 08:03:28 +00:00
BingZandJinjing
be258e23ec
* docs: design Grok orchestration group * docs: plan Grok orchestration group implementation * fix: add Grok orchestration group * test(orchestration): accept Windows skill newlines * Fix @grok orchestration group matching and remove stale planning docs - Reuse the shared buildAgentNameRe matcher in groups.ts instead of a divergent local regex, so orchestration groups honor the same Windows launcher-suffix rule (grok.exe/.cmd/.bat/.ps1) as the rest of Orca's agent-title detection. - Add test coverage for real Grok OSC title shapes (spinner-collapsed, session titles) and Windows launcher-suffix titles. - Delete the now-completed design and implementation-plan docs for the Grok orchestration group work. --------- Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
70 lines
2.6 KiB
TypeScript
70 lines
2.6 KiB
TypeScript
/**
|
|
* Token-matching for agent names inside terminal titles.
|
|
*
|
|
* Why a dedicated module: agent names must be matched as whole tokens, never as
|
|
* substrings. Substring matching mis-fired on worktree/cwd titles like
|
|
* "opencode-blinker" (⊃ "opencode") or "openclaude" (⊃ "claude"), painting a
|
|
* Codex/OpenClaude tab as the wrong agent whenever the title fell back to the
|
|
* bare directory name. The boundary guard `(?<![\w./\\-])…(?![\w./\\-])` rejects
|
|
* path separators (POSIX and Windows) and hyphenated compounds on both sides.
|
|
*/
|
|
|
|
// Why: for OSC-title detection only. Intentionally narrower than the full set
|
|
// of launchable agents because short names like "amp" would classify ordinary
|
|
// shell titles like "timestamp ready" as agent activity. Product telemetry uses
|
|
// the explicit launch/session facts Orca owns, not this inference path.
|
|
export const AGENT_NAMES = [
|
|
'claude',
|
|
'openclaude',
|
|
'codex',
|
|
'copilot',
|
|
'cursor',
|
|
'gemini',
|
|
'antigravity',
|
|
'opencode',
|
|
'mimo',
|
|
'openclaw',
|
|
'aider',
|
|
'grok',
|
|
'devin'
|
|
]
|
|
|
|
// Why: Windows agent titles can surface launcher process names such as
|
|
// `openclaude.exe`; still reject arbitrary dotted path fragments.
|
|
const WINDOWS_EXECUTABLE_SUFFIX_RE = String.raw`(?:\.(?:exe|cmd|bat|ps1))`
|
|
|
|
export function buildAgentNameRe(name: string): RegExp {
|
|
return new RegExp(
|
|
`(?<![\\w./\\\\-])${name}(?:${WINDOWS_EXECUTABLE_SUFFIX_RE})?(?![\\w./\\\\-])`,
|
|
'i'
|
|
)
|
|
}
|
|
|
|
const AGENT_NAME_RE_BY_NAME = new Map(AGENT_NAMES.map((name) => [name, buildAgentNameRe(name)]))
|
|
|
|
const ANY_LEGACY_AGENT_NAME_RE = new RegExp(
|
|
AGENT_NAMES.map(
|
|
(name) => `(?<![\\w./\\\\-])${name}(?:${WINDOWS_EXECUTABLE_SUFFIX_RE})?(?![\\w./\\\\-])`
|
|
).join('|'),
|
|
'i'
|
|
)
|
|
|
|
/** True when `title` contains `name` (a member of AGENT_NAMES) as a whole token. */
|
|
export function titleHasAgentName(title: string, name: string): boolean {
|
|
return AGENT_NAME_RE_BY_NAME.get(name)?.test(title) ?? false
|
|
}
|
|
|
|
/** True when `title` contains any AGENT_NAMES entry as a whole token. */
|
|
export function titleHasAnyLegacyAgentName(title: string): boolean {
|
|
return ANY_LEGACY_AGENT_NAME_RE.test(title)
|
|
}
|
|
|
|
// Why: `android` contains `droid`; like the legacy names above, Droid must be
|
|
// token-matched so Android terminal titles do not become agent status.
|
|
export const DROID_AGENT_NAME_RE = /(?<![\w./\\-])droid(?![\w./\\-])/i
|
|
|
|
// Why: Hermes/agy are safe to token-match but unsafe as substrings because
|
|
// cwd/path titles like `~/hermes/working` would otherwise count as activity.
|
|
export const HERMES_AGENT_NAME_RE = /(?<![\w./\\-])hermes(?![\w./\\-])/i
|
|
export const AGY_AGENT_NAME_RE = /(?<![\w./\\-])agy(?![\w./\\-])/i
|