mirror of
https://github.com/stablyai/orca.git
synced 2026-11-02 18:17:36 +00:00
macOS ps formats lstart with the user's locale (%c) and vis-encodes non-ASCII argv when no UTF-8 locale is set. Under de_DE/en_NZ/ja_JP the process-table parsers dropped tty/startTime and folded them into command, breaking agent recognition, pane fingerprints, agent-session start times and daemon identity. Run those ps readers with LC_ALL=en_US.UTF-8 on macOS; other platforms keep the inherited env. Fixes #27004 Co-authored-by: outof-place <contact@outofplace.space>
339 lines
11 KiB
TypeScript
339 lines
11 KiB
TypeScript
import { execFile as execFileCb } from 'node:child_process'
|
||
import { readFile } from 'node:fs/promises'
|
||
import { promisify } from 'node:util'
|
||
import { psLocaleEnvironment } from './ps-locale-environment'
|
||
import {
|
||
captureDarwinProcessTable,
|
||
resetDarwinProcessTableCaptureForTests
|
||
} from './darwin-process-table-capture'
|
||
import {
|
||
PROCESS_TABLE_SNAPSHOT_MAX_STALENESS_MS,
|
||
PS_ARGS,
|
||
PS_MAX_BUFFER_BYTES,
|
||
ProcessTableCaptureError,
|
||
SHELL_FOREGROUND_PS_ARGS,
|
||
parseProcessTableRows,
|
||
parseShellForegroundRows,
|
||
parseStrictProcessTableRows,
|
||
type ProcessTableRow
|
||
} from './process-table-snapshot'
|
||
|
||
export { PROCESS_TABLE_SNAPSHOT_MAX_STALENESS_MS, PS_ARGS, PS_MAX_BUFFER_BYTES }
|
||
|
||
const execFile = promisify(execFileCb)
|
||
|
||
// command= costs 1.15s for 1,948 idle processes, 1.3–6s at load 27; 3s failed 6/20 captures.
|
||
// Allow 15s for identity reads on busy hosts while bounding wedged ps.
|
||
export const PS_TIMEOUT_MS = 15_000
|
||
|
||
type Snapshot<T> = { value: T; capturedAtMs: number; completedAtMs: number }
|
||
|
||
type ProcessTableSnapshotReaderDeps<T> = {
|
||
runPs: () => Promise<T>
|
||
now: () => number
|
||
ttlMs?: number
|
||
}
|
||
|
||
/** Build a process-table reader that coalesces concurrent and recent captures. */
|
||
export function createProcessTableSnapshotReader<T = string>(
|
||
deps: ProcessTableSnapshotReaderDeps<T>
|
||
): {
|
||
getSnapshot: () => Promise<T>
|
||
getSnapshotWithAge: () => Promise<{ value: T; capturedAgeMs: number }>
|
||
getFreshSnapshot: () => Promise<T>
|
||
reset: () => void
|
||
} {
|
||
const ttlMs = deps.ttlMs ?? PROCESS_TABLE_SNAPSHOT_MAX_STALENESS_MS
|
||
let cached: Snapshot<T> | null = null
|
||
let inFlight: Promise<T> | null = null
|
||
let sequence = 0
|
||
let freshQueued: { promise: Promise<T>; startSequence: number | null } | null = null
|
||
|
||
async function runSnapshot(): Promise<T> {
|
||
// Stamp evidence age at capture start, TTL at completion: slow captures must remain old yet still coalesce
|
||
// instead of spawning one whole-machine ps per caller on loaded hosts.
|
||
const capturedAtMs = deps.now()
|
||
const promise = deps.runPs()
|
||
inFlight = promise
|
||
try {
|
||
const value = await promise
|
||
cached = { value, capturedAtMs, completedAtMs: deps.now() }
|
||
return value
|
||
} finally {
|
||
if (inFlight === promise) {
|
||
inFlight = null
|
||
}
|
||
}
|
||
}
|
||
|
||
async function getSnapshot(): Promise<T> {
|
||
if (cached && deps.now() - cached.completedAtMs < ttlMs) {
|
||
return cached.value
|
||
}
|
||
if (inFlight) {
|
||
return inFlight
|
||
}
|
||
if (freshQueued) {
|
||
return freshQueued.promise
|
||
}
|
||
return runSnapshot()
|
||
}
|
||
|
||
async function getSnapshotWithAge(): Promise<{ value: T; capturedAgeMs: number }> {
|
||
const value = await getSnapshot()
|
||
const capturedAtMs = cached?.value === value ? cached.capturedAtMs : deps.now()
|
||
return { value, capturedAgeMs: Math.max(0, deps.now() - capturedAtMs) }
|
||
}
|
||
|
||
function getFreshSnapshot(): Promise<T> {
|
||
const requestSequence = ++sequence
|
||
if (freshQueued?.startSequence === null) {
|
||
return freshQueued.promise
|
||
}
|
||
const priorFresh = freshQueued?.promise ?? null
|
||
const priorScan = inFlight
|
||
const entry: { promise: Promise<T>; startSequence: number | null } = {
|
||
promise: Promise.resolve(undefined as never),
|
||
startSequence: null
|
||
}
|
||
entry.promise = Promise.resolve().then(async () => {
|
||
for (const prior of [priorFresh, priorScan]) {
|
||
if (!prior) {
|
||
continue
|
||
}
|
||
try {
|
||
await prior
|
||
} catch {
|
||
// The post-boundary scan below owns the confirmation result.
|
||
}
|
||
}
|
||
entry.startSequence = ++sequence
|
||
if (entry.startSequence <= requestSequence) {
|
||
throw new Error('fresh process snapshot did not start after request')
|
||
}
|
||
return runSnapshot()
|
||
})
|
||
freshQueued = entry
|
||
const clearQueued = (): void => {
|
||
if (freshQueued === entry) {
|
||
freshQueued = null
|
||
}
|
||
}
|
||
void entry.promise.then(clearQueued, clearQueued)
|
||
return entry.promise
|
||
}
|
||
|
||
return {
|
||
getSnapshot,
|
||
getSnapshotWithAge,
|
||
getFreshSnapshot,
|
||
reset: () => {
|
||
cached = null
|
||
inFlight = null
|
||
sequence = 0
|
||
freshQueued = null
|
||
}
|
||
}
|
||
}
|
||
|
||
type ProcessTableCapture = {
|
||
lenient: () => ProcessTableRow[]
|
||
strict: () => ProcessTableRow[]
|
||
}
|
||
|
||
function applyProcessStartTimes(
|
||
rows: ProcessTableRow[],
|
||
startTimesByPid: ReadonlyMap<number, string> | undefined,
|
||
dropUnstableStartTimes = false
|
||
): ProcessTableRow[] {
|
||
if ((!startTimesByPid || startTimesByPid.size === 0) && !dropUnstableStartTimes) {
|
||
return rows
|
||
}
|
||
return rows.map((row) => {
|
||
const startTime = startTimesByPid?.get(row.pid)
|
||
if (startTime) {
|
||
return { ...row, startTime }
|
||
}
|
||
if (dropUnstableStartTimes && row.startTime !== undefined) {
|
||
const { startTime: _unstable, ...withoutStartTime } = row
|
||
return withoutStartTime
|
||
}
|
||
return row
|
||
})
|
||
}
|
||
|
||
function createProcessTableCapture(
|
||
stdout: string,
|
||
startTimesByPid?: ReadonlyMap<number, string>,
|
||
dropUnstableStartTimes = false
|
||
): ProcessTableCapture {
|
||
let lenientRows: ProcessTableRow[] | null = null
|
||
let strictResult: { rows: ProcessTableRow[] } | { error: unknown } | null = null
|
||
return {
|
||
lenient: () =>
|
||
(lenientRows ??= applyProcessStartTimes(
|
||
parseProcessTableRows(stdout),
|
||
startTimesByPid,
|
||
dropUnstableStartTimes
|
||
)),
|
||
strict: () => {
|
||
if (strictResult === null) {
|
||
try {
|
||
strictResult = {
|
||
rows: applyProcessStartTimes(
|
||
parseStrictProcessTableRows(stdout),
|
||
startTimesByPid,
|
||
dropUnstableStartTimes
|
||
)
|
||
}
|
||
} catch (error) {
|
||
strictResult = { error }
|
||
}
|
||
}
|
||
if ('error' in strictResult) {
|
||
throw strictResult.error
|
||
}
|
||
return strictResult.rows
|
||
}
|
||
}
|
||
}
|
||
|
||
/** Reject captures truncated at the subprocess ceiling or containing no rows. */
|
||
function assertWholeCapture(stdout: string): string {
|
||
if (Buffer.byteLength(stdout, 'utf-8') >= PS_MAX_BUFFER_BYTES) {
|
||
throw new ProcessTableCaptureError('capture_truncated')
|
||
}
|
||
if (!/\S/.test(stdout)) {
|
||
throw new ProcessTableCaptureError('empty_capture')
|
||
}
|
||
return stdout
|
||
}
|
||
|
||
/** Field 22 (`starttime`) of `/proc/<pid>/stat`, read past the parenthesised comm. */
|
||
export function parseLinuxProcStatStartTime(stat: string): string | null {
|
||
const closingParen = stat.lastIndexOf(')')
|
||
if (closingParen === -1) {
|
||
return null
|
||
}
|
||
const tail = stat
|
||
.slice(closingParen + 1)
|
||
.trim()
|
||
.split(/\s+/)
|
||
return tail[19] || null
|
||
}
|
||
|
||
/** Read Linux's stable PID start-time ticks without spawning another process. */
|
||
async function readLinuxProcessStartTimes(
|
||
rows: readonly ProcessTableRow[]
|
||
): Promise<ReadonlyMap<number, string>> {
|
||
const candidates = rows.filter((row) => row.tty !== undefined && row.tty !== '?')
|
||
const starts = await Promise.all(
|
||
candidates.map(async (row) => {
|
||
try {
|
||
const startTime = parseLinuxProcStatStartTime(
|
||
await readFile(`/proc/${row.pid}/stat`, 'utf8')
|
||
)
|
||
return startTime ? ([row.pid, startTime] as const) : null
|
||
} catch {
|
||
return null
|
||
}
|
||
})
|
||
)
|
||
return new Map(starts.filter((entry) => entry !== null))
|
||
}
|
||
|
||
async function captureProcessTable(args: readonly string[], timeout = PS_TIMEOUT_MS) {
|
||
let stdout: string
|
||
try {
|
||
;({ stdout } = await execFile('ps', [...args], {
|
||
encoding: 'utf-8',
|
||
env: psLocaleEnvironment(),
|
||
timeout,
|
||
maxBuffer: PS_MAX_BUFFER_BYTES
|
||
}))
|
||
} catch (error) {
|
||
// A ceiling hit is truncation, not absence: name it in the domain vocabulary.
|
||
if ((error as { code?: unknown } | null)?.code === 'ERR_CHILD_PROCESS_STDIO_MAXBUFFER') {
|
||
throw new ProcessTableCaptureError('capture_truncated')
|
||
}
|
||
throw error
|
||
}
|
||
return assertWholeCapture(stdout)
|
||
}
|
||
|
||
const processTableReader = createProcessTableSnapshotReader<ProcessTableCapture>({
|
||
runPs: async () => {
|
||
const stdout =
|
||
process.platform === 'darwin'
|
||
? await captureDarwinProcessTable(captureProcessTable, assertWholeCapture, PS_TIMEOUT_MS)
|
||
: await captureProcessTable(PS_ARGS)
|
||
if (process.platform !== 'linux') {
|
||
return createProcessTableCapture(stdout)
|
||
}
|
||
const startTimesByPid = await readLinuxProcessStartTimes(parseProcessTableRows(stdout))
|
||
return createProcessTableCapture(stdout, startTimesByPid, true)
|
||
},
|
||
now: () => Date.now()
|
||
})
|
||
|
||
// Separate shell reader avoids macOS terminal-name costs and waiting on full captures it cannot use.
|
||
const shellForegroundReader = createProcessTableSnapshotReader<ProcessTableRow[]>({
|
||
runPs: async () => parseShellForegroundRows(await captureProcessTable(SHELL_FOREGROUND_PS_ARGS)),
|
||
now: () => Date.now()
|
||
})
|
||
|
||
export async function getFreshShellForegroundSnapshot(): Promise<ProcessTableRow[]> {
|
||
return process.platform === 'darwin'
|
||
? shellForegroundReader.getFreshSnapshot()
|
||
: getFreshProcessTableSnapshot()
|
||
}
|
||
|
||
export async function getProcessTableSnapshot(): Promise<ProcessTableRow[]> {
|
||
return (await processTableReader.getSnapshot()).lenient()
|
||
}
|
||
|
||
export async function getFreshProcessTableSnapshot(): Promise<ProcessTableRow[]> {
|
||
return (await processTableReader.getFreshSnapshot()).lenient()
|
||
}
|
||
|
||
export async function getStrictProcessTableSnapshot(): Promise<ProcessTableRow[]> {
|
||
return (await processTableReader.getSnapshot()).strict()
|
||
}
|
||
|
||
/** Evidence needs current observations, unlike identity probes that wait up to 15s. Idle command= costs ~1.15s/1,948 processes;
|
||
* 2s freshness ceiling minus up to 500ms cached age and transit leaves 1.2s. Slower captures fail age gates anyway
|
||
* (measured 4–18.6s at load 46, 2.5–9s on a 2,002-process laptop), so return unverifiable promptly. */
|
||
export const PROCESS_TABLE_EVIDENCE_BUDGET_MS = 1_200
|
||
|
||
/** Bound only this wait; leave shared identity captures running to fill the cache instead of spawning another expensive ps. */
|
||
export async function withEvidenceBudget<T>(pending: Promise<T>): Promise<T> {
|
||
let timer: ReturnType<typeof setTimeout> | undefined
|
||
try {
|
||
return await Promise.race([
|
||
pending,
|
||
new Promise<never>((_resolve, reject) => {
|
||
timer = setTimeout(
|
||
() => reject(new ProcessTableCaptureError('capture_over_budget')),
|
||
PROCESS_TABLE_EVIDENCE_BUDGET_MS
|
||
)
|
||
})
|
||
])
|
||
} finally {
|
||
clearTimeout(timer)
|
||
}
|
||
}
|
||
|
||
export async function getStrictProcessTableSnapshotWithAge(): Promise<{
|
||
rows: ProcessTableRow[]
|
||
capturedAgeMs: number
|
||
}> {
|
||
const snapshot = await withEvidenceBudget(processTableReader.getSnapshotWithAge())
|
||
return { rows: snapshot.value.strict(), capturedAgeMs: snapshot.capturedAgeMs }
|
||
}
|
||
|
||
export function resetProcessTableSnapshotForTests(): void {
|
||
processTableReader.reset()
|
||
shellForegroundReader.reset()
|
||
resetDarwinProcessTableCaptureForTests()
|
||
}
|