mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 08:03:13 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
36 lines
1.4 KiB
TypeScript
36 lines
1.4 KiB
TypeScript
import { mkdir } from 'node:fs/promises'
|
|
import type { GlobalSettings, Repo } from '../shared/types'
|
|
import { getRepoExecutionHostId, LOCAL_EXECUTION_HOST_ID } from '../shared/execution-host'
|
|
import { isFolderRepo } from '../shared/repo-kind'
|
|
import { computeWorkspaceRoot, getWorktreePathSettings } from './ipc/worktree-logic'
|
|
|
|
type WorktreeRootPreparationSettings = Pick<GlobalSettings, 'workspaceDir' | 'nestWorkspaces'>
|
|
type WorktreeRootPreparationStore = {
|
|
getSettings: () => WorktreeRootPreparationSettings
|
|
getRepos: () => Repo[]
|
|
}
|
|
|
|
export async function prepareLocalWorktreeRootForRepo(
|
|
store: Pick<WorktreeRootPreparationStore, 'getSettings'>,
|
|
repo: Repo
|
|
): Promise<void> {
|
|
if (getRepoExecutionHostId(repo) !== LOCAL_EXECUTION_HOST_ID || isFolderRepo(repo)) {
|
|
return
|
|
}
|
|
|
|
try {
|
|
const root = computeWorkspaceRoot(repo.path, getWorktreePathSettings(repo, store.getSettings()))
|
|
// Why: mkdir touches the current root to preflight macOS TCC, while
|
|
// access remains scoped by recomputed settings instead of a permanent grant.
|
|
await mkdir(root, { recursive: true })
|
|
} catch (error) {
|
|
console.warn(`[worktree-root] failed to prepare worktree root for ${repo.path}:`, error)
|
|
}
|
|
}
|
|
|
|
export async function prepareLocalWorktreeRootsForRepos(
|
|
store: WorktreeRootPreparationStore
|
|
): Promise<void> {
|
|
await Promise.all(store.getRepos().map((repo) => prepareLocalWorktreeRootForRepo(store, repo)))
|
|
}
|