mirror of
https://github.com/stablyai/orca.git
synced 2026-10-03 08:02:12 +00:00
Brennan Benson
55258f34ad
* test(agent-status): characterize title-derived agent identity before the resolver change getAgentLabel is an ordered first-match-wins scan of substring predicates over a display title, so chain position rather than evidence strength decides identity. Pin the current answers — including the wrong ones — so the resolver change lands as a reviewable diff of assertions instead of silent behavior drift. Eight of the nineteen assertions record defects. Five are minimized from real recorded pane titles: four Grok panes that read as Codex and one that reads as Gemini CLI, in every case because a foreign agent name in free-form task text is checked before the `- <agent>` owner suffix that actually names the pane. The suite also pins the pairwise property behind them — both orderings of a name pair resolve to the same agent, which is the tell that the title carries no signal distinguishing them. Also pinned as correct so the resolver does not regress them: hyphenated worktree names (`review-14600-codex`) stay unclassified, and a Claude glyph still wins over foreign task text. Verified non-vacuous: applying PR #15535's narrowing to isGeminiTerminalTitle flips exactly four assertions, one of them a real corpus title, and the suite is green again on revert. No production code changes. * test(agent-status): re-pin the four assertions #15535 changed #15535 landed the Antigravity narrowing, so four characterized answers moved. Re-pinned against the new main rather than deleted, and the two that are now correct say why they are correct — a targeted exception cleared the path, not a structural fix. Added the general form as a new defect case: the same Grok pane without the word "Antigravity" in its task text still reads as Gemini CLI, because only that one pair has an exception. That is the case the resolver has to answer without a per-competitor clause. * test(agent-status): clarify characterization precedence