Files
orca/src
Brennan Benson ab1bf1aff5 fix(settings): recover HTTP proxy settings from safeStorage failures (STA-3442) (#12838)
httpProxyUrl is the only network setting stored via safeStorage. Two
failure modes silently killed the configured proxy on macOS:

- A keychain reset/denial makes decryptString throw at load; the raw
  ciphertext then masqueraded as the configured proxy URL, so
  applyElectronProxySettings silently fell back to DIRECT and the
  garbage re-persisted forever (no self-heal).
- safeStorage.isEncryptionAvailable() throwing (keychain/API errors,
  pre-ready use) was uncaught in encrypt/decrypt, failing the entire
  state save - the data file never gained the proxy keys at all.

Load now validates the decrypted value and clears undecryptable
ciphertext (plaintext URLs still pass, preserving the pre-encryption
upgrade path), the availability check is exception-safe, and startup
logs when persisted proxy settings are invalid instead of silently
using direct networking.
2026-08-05 22:40:27 -07:00
..