mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 08:03:13 +00:00
JinjingandOrca
a03a3dd51b
* Add mobile image-diff previews via shared data-URI builder - Extracts a `buildImageDataUri` helper (src/shared/image-data-uri.ts) shared by the desktop ImageViewer and mobile, so both trim whitespace-wrapped base64 and skip non-previewable mimes (e.g. application/pdf) the same way. - Adds mobile-diff-image-preview.ts to render binary git.diff results (add/modify/ delete) as images instead of falling back to "Binary preview unavailable". - Extracts resolveMobileFileTabDoc to consolidate the session file-tab loading logic (diff/image/html/text) out of the route file for testability. * Fix stale binary image fallback for empty modified diffs and relay reads - mobileDiffImageDataUri now distinguishes a true deletion (modified side absent) from a modify whose binary bytes arrived empty (relay/size-cap cases), returning null instead of the stale pre-change image - readWorkingDiffFile passes the file path to bufferToBlob so relay working-tree reads can detect previewable image extensions instead of always reporting empty binary content - add mobile-file-tab-doc.test.ts covering diff/image/binary/text resolution paths * Regenerate skill bundle manifest for 1.4.144-rc.2 Co-authored-by: Orca <help@stably.ai> * fix(review): trim comments to AGENTS.md's one/two-line why-only rule Comments in mobile-diff-image-preview.ts and mobile-file-tab-doc.ts ran 3-6 lines and narrated mechanism instead of stating only the non-obvious reason, per AGENTS.md's "Code Comments: Document the Why, Briefly" rule. Co-authored-by: Orca <help@stably.ai> * Distinguish read failures from true deletions in binary diff results - Working-tree stat/readFile errors and relay reads previously collapsed onto the same empty-content signal as a genuine deletion, letting previewers fall back to stale original bytes on a failed read. - Add modifiedDeleted/missing flags through status.ts, git-handler-ops, and git-working-file-read so only proven deletions trigger the original-bytes fallback; failed reads now return null. - Tighten buildImageDataUri to accept only image/* mimes instead of special-casing application/pdf. * fix(relay): expect missing:false on index blob maxBuffer overflow readBlobAtIndex now returns a missing flag so staged deletions are distinct from size-capped binary reads; update the overflow test. * Allow opening deleted files to show pre-delete text or image diffs Deleted files can now be opened to view their pre-delete content via git.diff (including images via modifiedDeleted). Only unresolved conflicts remain unopenable. Centralizes the canOpen rule in canOpenMobileGitStatusEntry() to keep opener guards consistent across the mobile source control UI. --------- Co-authored-by: Orca <help@stably.ai>
33 lines
1.1 KiB
TypeScript
33 lines
1.1 KiB
TypeScript
import { buildImageDataUri } from '../../../src/shared/image-data-uri'
|
|
|
|
// modifiedDeleted marks a proven deletion (modified side genuinely absent); an
|
|
// empty modifiedContent alone can't, since a relay/SSH read failure also arrives
|
|
// empty with modifiedIsBinary false.
|
|
export type MobileBinaryDiffResult = {
|
|
kind: 'binary'
|
|
originalContent?: string
|
|
modifiedContent?: string
|
|
originalIsBinary?: boolean
|
|
modifiedIsBinary?: boolean
|
|
modifiedDeleted?: boolean
|
|
isImage?: boolean
|
|
mimeType?: string
|
|
}
|
|
|
|
// Falls back to the original bytes only for a proven deletion; a read failure or
|
|
// size-capped modify — also empty on the modified side — returns null instead of
|
|
// the stale pre-change image.
|
|
export function mobileDiffImageDataUri(result: MobileBinaryDiffResult): string | null {
|
|
if (result.isImage !== true) {
|
|
return null
|
|
}
|
|
const modified = result.modifiedContent || ''
|
|
if (modified) {
|
|
return buildImageDataUri(result.mimeType, modified)
|
|
}
|
|
if (result.modifiedDeleted === true) {
|
|
return buildImageDataUri(result.mimeType, result.originalContent || '')
|
|
}
|
|
return null
|
|
}
|