mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 00:57:45 +00:00
Neil
a308277f9a
* fix(deps): root and mobile resolve one zod, and CI fails if they drift
Mobile type-checks src/shared zod schemas. With mobile on zod 4.6.5 and the
root on 4.6.7, TypeScript treated them as unrelated packages, so wrapped
schemas inferred {} (tests/e2e/helpers/phone-feed-list.ts:154) whenever a
job installed mobile deps.
* fix(deps): guard every package mobile's tsconfig remaps, not only zod
* test(ci): pin the shared-dependency version check to the static phase
56 lines
1.9 KiB
JavaScript
56 lines
1.9 KiB
JavaScript
import path from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
findSharedDependencyVersionProblems,
|
|
main
|
|
} from './check-mobile-shared-dependency-versions.mjs'
|
|
|
|
const projectDir = path.resolve(import.meta.dirname, '../..')
|
|
const locked = (version) => ({ dependencies: { zod: { specifier: '~4.6.0', version } } })
|
|
const checkZod = (rootImporter, mobileImporter) =>
|
|
findSharedDependencyVersionProblems({ rootImporter, mobileImporter, names: ['zod'] })
|
|
|
|
describe('findSharedDependencyVersionProblems', () => {
|
|
it('passes when both lockfiles resolve the same version', () => {
|
|
expect(checkZod(locked('4.6.7'), locked('4.6.7'))).toEqual([])
|
|
})
|
|
|
|
it('reports two resolved versions', () => {
|
|
expect(checkZod(locked('4.6.7'), locked('4.6.5'))).toEqual([
|
|
'zod: the root locks 4.6.7, mobile locks 4.6.5'
|
|
])
|
|
})
|
|
|
|
it('ignores peer and patch suffixes and reads devDependencies', () => {
|
|
expect(
|
|
checkZod(
|
|
{ devDependencies: { zod: { version: '4.6.7(typescript@6.0.3)' } } },
|
|
locked('4.6.7(patch_hash=abc)')
|
|
)
|
|
).toEqual([])
|
|
})
|
|
|
|
it('reports a side that stopped declaring the dependency', () => {
|
|
expect(checkZod(locked('4.6.7'), {})).toEqual(['zod is not a direct dependency of mobile'])
|
|
expect(checkZod({}, locked('4.6.7'))).toEqual(['zod is not a direct dependency of the root'])
|
|
})
|
|
|
|
it('checks every shared dependency by default', () => {
|
|
const problems = findSharedDependencyVersionProblems({
|
|
rootImporter: locked('4.6.7'),
|
|
mobileImporter: locked('4.6.7')
|
|
})
|
|
expect(problems).toEqual([
|
|
'tweetnacl is not a direct dependency of the root',
|
|
'@noble/hashes is not a direct dependency of the root',
|
|
'@types/ws is not a direct dependency of the root'
|
|
])
|
|
})
|
|
})
|
|
|
|
describe('committed lockfiles', () => {
|
|
it('pass the repository check', () => {
|
|
expect(main(projectDir)).toBe(0)
|
|
})
|
|
})
|