mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 00:02:31 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
109 lines
3.3 KiB
TypeScript
109 lines
3.3 KiB
TypeScript
/**
|
|
* Shared test utilities for git-handler tests.
|
|
*
|
|
* Why: oxlint max-lines (300) requires splitting large test suites.
|
|
* This module exports the mock dispatcher factory and git helpers
|
|
* so multiple test files can reuse them without duplication.
|
|
*/
|
|
import { vi } from 'vitest'
|
|
import { execFileSync } from 'node:child_process'
|
|
import type { RelayDispatcher } from './dispatcher'
|
|
|
|
const TEST_GIT_USER_EMAIL = 'test@test.com'
|
|
const TEST_GIT_USER_NAME = 'Test'
|
|
|
|
// Why: declare an explicit type so the inferred return type of
|
|
// createMockDispatcher doesn't transitively reference `@vitest/spy`'s
|
|
// internal `Procedure` type (from `vi.fn(...)`). Without this annotation,
|
|
// TS2883 fires under `pnpm run tc:node` because the generated .d.ts would
|
|
// need to name a type that isn't portably resolvable from this module.
|
|
export type MockDispatcher = {
|
|
onRequest: (
|
|
method: string,
|
|
handler: (
|
|
params: Record<string, unknown>,
|
|
context: { isStale: () => boolean; signal?: AbortSignal }
|
|
) => Promise<unknown>
|
|
) => void
|
|
onNotification: (method: string, handler: (params: Record<string, unknown>) => void) => void
|
|
notify: (method: string, params?: Record<string, unknown>) => void
|
|
_requestHandlers: Map<
|
|
string,
|
|
(
|
|
params: Record<string, unknown>,
|
|
context: { isStale: () => boolean; signal?: AbortSignal }
|
|
) => Promise<unknown>
|
|
>
|
|
callRequest(
|
|
method: string,
|
|
params?: Record<string, unknown>,
|
|
context?: { isStale: () => boolean; signal?: AbortSignal }
|
|
): Promise<unknown>
|
|
}
|
|
|
|
export function createMockDispatcher(): MockDispatcher {
|
|
const requestHandlers = new Map<
|
|
string,
|
|
(
|
|
params: Record<string, unknown>,
|
|
context: { isStale: () => boolean; signal?: AbortSignal }
|
|
) => Promise<unknown>
|
|
>()
|
|
|
|
return {
|
|
onRequest: vi.fn(
|
|
(
|
|
method: string,
|
|
handler: (
|
|
params: Record<string, unknown>,
|
|
context: { isStale: () => boolean; signal?: AbortSignal }
|
|
) => Promise<unknown>
|
|
) => {
|
|
requestHandlers.set(method, handler)
|
|
}
|
|
),
|
|
onNotification: vi.fn(),
|
|
notify: vi.fn(),
|
|
_requestHandlers: requestHandlers,
|
|
async callRequest(
|
|
method: string,
|
|
params: Record<string, unknown> = {},
|
|
context: { isStale: () => boolean; signal?: AbortSignal } = { isStale: () => false }
|
|
) {
|
|
const handler = requestHandlers.get(method)
|
|
if (!handler) {
|
|
throw new Error(`No handler for ${method}`)
|
|
}
|
|
return handler(params, context)
|
|
}
|
|
}
|
|
}
|
|
|
|
export function gitInit(dir: string): void {
|
|
execFileSync('git', ['init'], { cwd: dir, stdio: 'pipe' })
|
|
execFileSync('git', ['config', 'user.email', TEST_GIT_USER_EMAIL], { cwd: dir, stdio: 'pipe' })
|
|
execFileSync('git', ['config', 'user.name', TEST_GIT_USER_NAME], { cwd: dir, stdio: 'pipe' })
|
|
}
|
|
|
|
export function gitCommit(dir: string, message: string): void {
|
|
execFileSync('git', ['add', '.'], { cwd: dir, stdio: 'pipe' })
|
|
// Why: `git submodule add` creates a checkout that does not inherit the
|
|
// source repo's local identity config, and CI may have no global identity.
|
|
execFileSync(
|
|
'git',
|
|
[
|
|
'-c',
|
|
`user.email=${TEST_GIT_USER_EMAIL}`,
|
|
'-c',
|
|
`user.name=${TEST_GIT_USER_NAME}`,
|
|
'commit',
|
|
'-m',
|
|
message,
|
|
'--allow-empty'
|
|
],
|
|
{ cwd: dir, stdio: 'pipe' }
|
|
)
|
|
}
|
|
|
|
export type { RelayDispatcher }
|