mirror of
https://github.com/stablyai/orca.git
synced 2026-10-20 08:03:28 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
140 lines
3.6 KiB
TypeScript
140 lines
3.6 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it } from 'vitest'
|
|
import { spawn } from 'node:child_process'
|
|
import { mkdtempSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { getDaemonPidPath, serializeDaemonPidFile } from './daemon-spawner'
|
|
import { getProcessStartedAtMs, isDaemonStaleForCurrentBundle } from './daemon-health'
|
|
|
|
function spawnDaemonLikeProcess(socketPath: string, tokenPath: string) {
|
|
return spawn(
|
|
process.execPath,
|
|
[
|
|
'-e',
|
|
'setTimeout(() => {}, 30000)',
|
|
'daemon-entry',
|
|
'--socket',
|
|
socketPath,
|
|
'--token',
|
|
tokenPath
|
|
],
|
|
{ stdio: 'ignore' }
|
|
)
|
|
}
|
|
|
|
async function getStartedAtMs(pid: number | undefined): Promise<number | null> {
|
|
if (!pid) {
|
|
return null
|
|
}
|
|
await new Promise((resolve) => setTimeout(resolve, 100))
|
|
return getProcessStartedAtMs(pid)
|
|
}
|
|
|
|
describe('daemon bundle staleness', () => {
|
|
let dir: string
|
|
let socketPath: string
|
|
let tokenPath: string
|
|
|
|
beforeEach(() => {
|
|
dir = mkdtempSync(join(tmpdir(), 'daemon-bundle-staleness-test-'))
|
|
socketPath = join(dir, 'daemon.sock')
|
|
tokenPath = join(dir, 'daemon.token')
|
|
})
|
|
|
|
afterEach(() => {
|
|
rmSync(dir, { recursive: true, force: true })
|
|
})
|
|
|
|
it('detects packaged daemon staleness by app version', async () => {
|
|
if (process.platform === 'win32') {
|
|
return
|
|
}
|
|
|
|
const child = spawnDaemonLikeProcess(socketPath, tokenPath)
|
|
try {
|
|
const startedAtMs = await getStartedAtMs(child.pid)
|
|
if (startedAtMs === null || !child.pid) {
|
|
return
|
|
}
|
|
|
|
const entryPath = join(dir, 'daemon-entry.js')
|
|
writeFileSync(entryPath, '', 'utf8')
|
|
writeFileSync(
|
|
getDaemonPidPath(dir),
|
|
serializeDaemonPidFile({
|
|
pid: child.pid,
|
|
startedAtMs,
|
|
entryPath,
|
|
appVersion: '1.2.2'
|
|
}),
|
|
{ mode: 0o600 }
|
|
)
|
|
|
|
expect(await isDaemonStaleForCurrentBundle(dir, socketPath, tokenPath, '1.2.3')).toBe(true)
|
|
} finally {
|
|
child.kill('SIGKILL')
|
|
}
|
|
})
|
|
|
|
it('preserves same-version packaged daemon reuse', async () => {
|
|
if (process.platform === 'win32') {
|
|
return
|
|
}
|
|
|
|
const child = spawnDaemonLikeProcess(socketPath, tokenPath)
|
|
try {
|
|
const startedAtMs = await getStartedAtMs(child.pid)
|
|
if (startedAtMs === null || !child.pid) {
|
|
return
|
|
}
|
|
|
|
const entryPath = join(dir, 'daemon-entry.js')
|
|
writeFileSync(entryPath, '', 'utf8')
|
|
writeFileSync(
|
|
getDaemonPidPath(dir),
|
|
serializeDaemonPidFile({
|
|
pid: child.pid,
|
|
startedAtMs,
|
|
entryPath,
|
|
appVersion: '1.2.3'
|
|
}),
|
|
{ mode: 0o600 }
|
|
)
|
|
|
|
expect(await isDaemonStaleForCurrentBundle(dir, socketPath, tokenPath, '1.2.3')).toBe(false)
|
|
} finally {
|
|
child.kill('SIGKILL')
|
|
}
|
|
})
|
|
|
|
it('replaces legacy packaged daemons without version metadata', async () => {
|
|
if (process.platform === 'win32') {
|
|
return
|
|
}
|
|
|
|
const child = spawnDaemonLikeProcess(socketPath, tokenPath)
|
|
try {
|
|
const startedAtMs = await getStartedAtMs(child.pid)
|
|
if (startedAtMs === null || !child.pid) {
|
|
return
|
|
}
|
|
|
|
const entryPath = join(dir, 'daemon-entry.js')
|
|
writeFileSync(entryPath, '', 'utf8')
|
|
writeFileSync(
|
|
getDaemonPidPath(dir),
|
|
serializeDaemonPidFile({
|
|
pid: child.pid,
|
|
startedAtMs,
|
|
entryPath
|
|
}),
|
|
{ mode: 0o600 }
|
|
)
|
|
|
|
expect(await isDaemonStaleForCurrentBundle(dir, socketPath, tokenPath, '1.2.3')).toBe(true)
|
|
} finally {
|
|
child.kill('SIGKILL')
|
|
}
|
|
})
|
|
})
|