mirror of
https://github.com/stablyai/orca.git
synced 2026-10-08 08:02:32 +00:00
Neil
7ac9c8d675
* perf: skip macOS DNS probes for unrelated errors * review(dns-probe-admission): single-source the probe gate and widen resolution-failure coverage The admission guard duplicated the hint predicate at a second call site, so a gate that drifted stricter than the hint test would silently drop the DNS diagnostic for a real lookup failure. Route both through isMacTailscaleDnsHintCandidate, evaluated once per call, and add a parity test asserting admission never changes the message the ungated hint decision produces. Also: widen the predicate to the resolution-failure wordings it missed (EAI_NONAME / EAI_FAIL / ENODATA / getaddrinfo / "could not resolve" / "name or service not known" / ERR_NAME_RESOLUTION_FAILED), gate the probe on process.platform === 'darwin' explicitly rather than relying on the reader's internal check, make the hint idempotent so a re-wrapped hinted message neither duplicates copy nor re-probes, and rewrite the cache-window test to assert the resolver state the next relevant error reports instead of pinning an exact probe count.