Files
orca/src/main/ipc/ui.ts
T
Neil 77f23b013f refactor(shared): drop the shared/types barrel and import from the real modules (#14447)
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as
a re-export barrel so the import sites did not have to change. This removes
the barrel: every consumer now imports from the module that actually declares
the type, and `src/shared/types.ts` is deleted.

Barrels hide where a type lives, make every consumer look like it depends on
the whole domain, and let an unrelated edit invalidate a module that ~2,000
files transitively import.

2,323 import declarations across 2,321 files. Rewritten mechanically: each
specifier was resolved to an absolute path via the TypeScript AST and
recomputed, rather than string-substituted, so alias forms (`@/../../shared/
types`) and per-specifier `type` modifiers survive.

Four cases the mechanical pass had to handle, each found by a gate rather than
by reading the diff:

- Modules inside `src/shared` import the barrel as `./types`, not
  `shared/types`. A pre-filter on the latter string skipped 176 of them and
  left imports dangling at a deleted file, which surfaced as confusing
  `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>`
  errors rather than "module not found".
- The barrel RENAMED one type on the way through
  (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name
  in the owning module has to be re-aliased at each consumer.
- Three test files put `;(globalThis as ...)` on the line after the import.
  TypeScript parses that `;` as the import statement's terminator, so
  replacing through `statement.getEnd()` deletes it and breaks ASI. The
  rewrite now stops at the module specifier.
- A file that already imported directly from a module got a SECOND import
  from it, because the barrel re-exported those same names — which trips
  `import/no-duplicates` under `--deny-warnings`. A post-pass merges
  declarations sharing a specifier and type-only-ness; the `import type` plus
  `import` pair from one module is left alone, since that form is allowed.

Splitting one barrel import into several genuinely adds lines, which pushed
`terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character
import must wrap, and neither local type collapses onto one line (101 and 116
characters). Rather than contort a type declaration to fit a line budget,
`collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` —
they are pure structural operations on the layout tree and independent of PTY
ownership. `visible-worktrees.ts` similarly loses its own mini-barrel
re-export of `isDefaultBranchWorkspace`, with the four real consumers
repointed at the declaring module. No `max-lines` bypass added.

Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted
first — these projects are `composite: true` and reuse stale caches); the full
`pnpm lint` green, not just bare oxlint — the narrower local check is what let
the duplicate imports reach CI; max-lines ratchet OK at 344.
2026-08-13 22:48:24 -07:00

130 lines
4.2 KiB
TypeScript

import { BrowserWindow, ipcMain, webContents, type WebContents } from 'electron'
import type { Store } from '../persistence'
import type { PersistedUIState } from '../../shared/persisted-ui-state-types'
import { isFeatureInteractionId } from '../../shared/feature-interactions'
let trustedUIRendererWebContentsId: number | null = null
export function setTrustedUIRendererWebContentsId(webContentsId: number | null): void {
trustedUIRendererWebContentsId = webContentsId
}
export function clearTrustedUIRendererWebContentsId(webContentsId: number): void {
if (trustedUIRendererWebContentsId === webContentsId) {
trustedUIRendererWebContentsId = null
}
}
export function sendToTrustedUIRenderer(
channel: string,
payload: unknown,
excludedWebContentsId?: number
): void {
const renderer = getTrustedUIRendererWebContents(excludedWebContentsId)
renderer?.send(channel, payload)
}
export function getTrustedUIRendererWebContents(
excludedWebContentsId?: number
): WebContents | null {
// Why: exact targeting avoids waking retained browser/utility windows that cannot consume app UI events.
const rendererId = trustedUIRendererWebContentsId
if (rendererId == null || rendererId === excludedWebContentsId) {
return null
}
const renderer = webContents.fromId(rendererId)
if (!renderer || renderer.isDestroyed()) {
return null
}
return renderer
}
export function getTrustedUIRendererWindow(): BrowserWindow | null {
const renderer = getTrustedUIRendererWebContents()
return renderer ? BrowserWindow.fromWebContents(renderer) : null
}
export function registerUIHandlers(
store: Store,
options: { isDashboardPopoutRenderer?: (sender: WebContents) => boolean } = {}
): void {
// Why: UI view-state is shared between the desktop renderer and mobile (ui.set
// RPC). Broadcast every change so the desktop re-hydrates when mobile (or
// another window) updates it — bi-directional sync, mirroring settings:changed.
store.onUIChanged((ui) => {
for (const window of BrowserWindow.getAllWindows()) {
if (!window.isDestroyed()) {
window.webContents.send('ui:stateChanged', ui)
}
}
})
ipcMain.handle('ui:get', () => {
return store.getUI()
})
ipcMain.handle('ui:set', (_event, args: Partial<PersistedUIState>) => {
store.updateUI(args)
})
ipcMain.handle('ui:recordFeatureInteraction', (_event, id: unknown) => {
if (!isFeatureInteractionId(id)) {
throw new Error('invalid_feature_interaction_id')
}
return store.recordFeatureInteraction(id)
})
ipcMain.removeAllListeners('ui:performNativePaste')
ipcMain.on('ui:performNativePaste', (event, options?: { mode?: unknown }) => {
if (!isTrustedUIRenderer(event.sender)) {
return
}
// Why: coordinated renderer paste falls back here only after no Orca owner
// claims the app-menu action; paste back into the requesting window only.
const webContents = BrowserWindow.fromWebContents(event.sender)?.webContents
if (options?.mode === 'paste-and-match-style') {
webContents?.pasteAndMatchStyle()
return
}
webContents?.paste()
})
ipcMain.removeAllListeners('ui:performNativeSelectionAction')
ipcMain.on('ui:performNativeSelectionAction', (event, action: unknown) => {
if (
!isTrustedUIRenderer(event.sender) &&
options.isDashboardPopoutRenderer?.(event.sender) !== true
) {
return
}
const target = BrowserWindow.fromWebContents(event.sender)?.webContents
if (action === 'copy') {
target?.copy()
} else if (action === 'select-all') {
target?.selectAll()
}
})
}
export function isTrustedUIRenderer(sender: WebContents): boolean {
if (sender.isDestroyed() || sender.getType() !== 'window') {
return false
}
if (trustedUIRendererWebContentsId != null) {
return sender.id === trustedUIRendererWebContentsId
}
const senderUrl = sender.getURL()
if (process.env.ELECTRON_RENDERER_URL) {
try {
return new URL(senderUrl).origin === new URL(process.env.ELECTRON_RENDERER_URL).origin
} catch {
return false
}
}
// Why: packaged fallback must be tied to the created main window id, not any
// file:// document that can obtain this IPC channel.
return false
}