Files
orca/src/shared/remote-runtime-shared-control-subscription-start.ts
T
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

48 lines
1.7 KiB
TypeScript

import { randomUUID } from 'node:crypto'
import { remoteRuntimeUnavailableError } from './remote-runtime-request-frames'
import { createSharedControlSubscription } from './remote-runtime-shared-control-subscriptions'
import { finishSharedControlSubscription } from './remote-runtime-shared-control-state'
import type {
RemoteRuntimeSharedSubscription,
SharedControlLogicalSubscription,
SharedControlSubscriptionCallbacks
} from './remote-runtime-shared-control-types'
export async function startSharedControlSubscription<TResult>(args: {
subscriptions: Map<string, SharedControlLogicalSubscription<unknown>>
method: string
params: unknown
callbacks: SharedControlSubscriptionCallbacks<TResult>
ensureReady: () => Promise<void>
sendSubscription: (subscription: SharedControlLogicalSubscription<unknown>) => void
closeSubscription: (requestId: string) => void
}): Promise<RemoteRuntimeSharedSubscription> {
const requestId = randomUUID()
const subscription = createSharedControlSubscription({
requestId,
method: args.method,
params: args.params,
callbacks: args.callbacks
})
args.subscriptions.set(requestId, subscription as SharedControlLogicalSubscription<unknown>)
try {
await args.ensureReady()
} catch (error) {
finishSharedControlSubscription(
args.subscriptions,
subscription as SharedControlLogicalSubscription<unknown>,
false
)
throw error
}
if (args.subscriptions.get(requestId) !== subscription) {
throw remoteRuntimeUnavailableError('Remote runtime subscription closed before it started.')
}
args.sendSubscription(subscription as SharedControlLogicalSubscription<unknown>)
return {
requestId,
close: () => args.closeSubscription(requestId),
sendBinary: () => false
}
}