mirror of
https://github.com/stablyai/orca.git
synced 2026-11-02 01:57:57 +00:00
EvgeniiandOrcaWin
6c469aea6d
* fix(plugins): reject locale ids Intl cannot parse `pluginLocaleIdSchema` checks the shape of a locale id but not its grammar, and the shape check is looser than BCP 47 in one direction: `en-US-US` (duplicate region) and `en-aaa` (a subtag that is neither region nor script) both match it. A pack declaring one installs, loads, and translates every string — and then `Intl.DateTimeFormat` throws inside `getIntlLocale()`, which swallows the error and falls back to English. Nothing is logged, so the pack author sees a working pack with English dates and no way to tell why. Delegate the grammar to `Intl.getCanonicalLocales` in a `.refine`, so the tag is rejected at install where the author can still act on it. The bundled `pt-BR` pack and every other well-formed tag are unaffected. * Condense this branch's comments to one line AGENTS.md asks for one-line comments that say why, and main's comment cleanup (#33249) applied that across the repository. This brings the comments this branch adds in line with it. No code changes. --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>